From patchwork Mon Feb 4 10:40:52 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [42/60] target-mips: fix wrong microMIPS opcode encoding Date: Mon, 04 Feb 2013 00:40:52 -0000 From: Michael Tokarev X-Patchwork-Id: 217856 Message-Id: <1359974470-17044-43-git-send-email-mjt@msgid.tls.msk.ru> To: qemu-devel@nongnu.org Cc: Aurelien Jarno , Michael Tokarev , qemu-stable@nongnu.org, "=?UTF-8?q? =E9=99=B3=E9=9F=8B=E4=BB=BB=20\(Wei-Ren=20Chen\) ?=" From: "陳韋任 (Wei-Ren Chen)" While reading microMIPS decoding, I found a possible wrong opcode encoding. According to [1] page 166, the bits 13..12 for MULTU is 0x01 rather than 0x00. Please review, thanks. [1] MIPS Architecture for Programmers VolumeIV-e: The MIPS DSP Application-Specific Extension to the microMIPS32 Architecture Signed-off-by: Chen Wei-Ren Signed-off-by: Aurelien Jarno (cherry picked from commit 6801038bc52d61f81ac8a25fbe392f1bad982887) Signed-off-by: Michael Tokarev --- target-mips/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index 8ff1fab..6932c28 100644 --- a/target-mips/translate.c +++ b/target-mips/translate.c @@ -9463,7 +9463,7 @@ enum { /* bits 13..12 for 0x32 */ MULT_ACC = 0x0, - MULTU_ACC = 0x0, + MULTU_ACC = 0x1, /* bits 15..12 for 0x2c */ SEB = 0x2,