Patchwork vnc: recognize Hungarian doubleacutes

login
register
mail settings
Submitter Michael Tokarev
Date Feb. 3, 2013, 8:36 p.m.
Message ID <1359923785-3820-1-git-send-email-mjt@msgid.tls.msk.ru>
Download mbox | patch
Permalink /patch/217804/
State New
Headers show

Comments

Michael Tokarev - Feb. 3, 2013, 8:36 p.m.
As reported in http://bugs.debian.org/697641 , some Hungarian keys
does not work with qemu when using vnc display.

This is because while the Hungarian keymap mentions these symbols,
qemu know nothing about them.  So add them.

This patch is applicable to -stable for all previous releases.

Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 ui/vnc_keysym.h |    4 ++++
 1 file changed, 4 insertions(+)
Laszlo Ersek - Feb. 4, 2013, 10:27 a.m.
On 02/03/13 21:36, Michael Tokarev wrote:
>  { "Zabovedot",            0x1af},
>  { "zacute",               0x1bc},
>  { "Zacute",               0x1ac},
> +{ "Odoubleacute",         0x1d5},

Ő

> +{ "Udoubleacute",         0x1db},

Ű

>  { "cacute",               0x1e6},
>  { "Cacute",               0x1c6},
>  { "nacute",               0x1f1},
>  { "Nacute",               0x1d1},
> +{ "odoubleacute",         0x1f5},

ő

> +{ "udoubleacute",         0x1fb},

ű

The name & low byte of each added code matches the corresponding name &
octa value I have in my ~/.XCompose. (I'm Hungarian.)

Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Stefan Hajnoczi - Feb. 6, 2013, 5:26 p.m.
On Mon, Feb 04, 2013 at 12:36:25AM +0400, Michael Tokarev wrote:
> As reported in http://bugs.debian.org/697641 , some Hungarian keys
> does not work with qemu when using vnc display.
> 
> This is because while the Hungarian keymap mentions these symbols,
> qemu know nothing about them.  So add them.
> 
> This patch is applicable to -stable for all previous releases.
> 
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>  ui/vnc_keysym.h |    4 ++++
>  1 file changed, 4 insertions(+)

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan
Anthony Liguori - Feb. 6, 2013, 8:41 p.m.
Applied.  Thanks.

Regards,

Anthony Liguori

Patch

diff --git a/ui/vnc_keysym.h b/ui/vnc_keysym.h
index df33cfe..6250bec 100644
--- a/ui/vnc_keysym.h
+++ b/ui/vnc_keysym.h
@@ -215,10 +215,14 @@  static const name2keysym_t name2keysym[]={
 { "Zabovedot",            0x1af},
 { "zacute",               0x1bc},
 { "Zacute",               0x1ac},
+{ "Odoubleacute",         0x1d5},
+{ "Udoubleacute",         0x1db},
 { "cacute",               0x1e6},
 { "Cacute",               0x1c6},
 { "nacute",               0x1f1},
 { "Nacute",               0x1d1},
+{ "odoubleacute",         0x1f5},
+{ "udoubleacute",         0x1fb},
 
     /* modifiers */
 {"ISO_Level3_Shift", 0xfe03}, /* XK_ISO_Level3_Shift */