Patchwork gdb: build gdbserver with TARGET_MAKE_ENV

login
register
mail settings
Submitter Thomas Petazzoni
Date Feb. 3, 2013, 12:30 p.m.
Message ID <1359894622-4783-1-git-send-email-thomas.petazzoni@free-electrons.com>
Download mbox | patch
Permalink /patch/217747/
State Accepted
Commit 9a70663904fc2e9acad4e32a7da945c7603a0222
Headers show

Comments

Thomas Petazzoni - Feb. 3, 2013, 12:30 p.m.
This commit fixes the exact same problem than
21a0c11a90f9ff19c78a5f32e0a2e9064fd28054, but for the gdbserver
build. The problem is that when you use the Crosstool-NG toolchain
backend, gawk gets built as a dependency of Crosstool-NG. So the gdb
configure scripts detects it, and assumes it is in the PATH (because
the gdb configure step gets run with TARGET_MAKE_ENV).

But then, the build fails, because it tries to run gawk, but gawk
isn't in the PATH, because we forget to use this TARGET_MAKE_ENV
variable when building gdbserver.

Fixes http://autobuild.buildroot.org/results/d0173de533b5e2fffed2eff7327a502ed2d787cd/build-end.log

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 toolchain/gdb/gdb.mk |    1 +
 1 file changed, 1 insertion(+)
Yann E. MORIN - Feb. 3, 2013, 12:53 p.m.
Thomas, All,

Quoting Thomas Petazzoni <thomas.petazzoni@free-electrons.com>:
> This commit fixes the exact same problem than
> 21a0c11a90f9ff19c78a5f32e0a2e9064fd28054, but for the gdbserver
> build. The problem is that when you use the Crosstool-NG toolchain
> backend, gawk gets built as a dependency of Crosstool-NG. So the gdb
> configure scripts detects it, and assumes it is in the PATH (because
> the gdb configure step gets run with TARGET_MAKE_ENV).
>
> But then, the build fails, because it tries to run gawk, but gawk
> isn't in the PATH, because we forget to use this TARGET_MAKE_ENV
> variable when building gdbserver.
>
> Fixes
>
http://autobuild.buildroot.org/results/d0173de533b5e2fffed2eff7327a502ed2d787cd/build-end.log
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.
Peter Korsgaard - Feb. 4, 2013, 10:35 p.m.
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> This commit fixes the exact same problem than
 Thomas> 21a0c11a90f9ff19c78a5f32e0a2e9064fd28054, but for the gdbserver
 Thomas> build. The problem is that when you use the Crosstool-NG toolchain
 Thomas> backend, gawk gets built as a dependency of Crosstool-NG. So the gdb
 Thomas> configure scripts detects it, and assumes it is in the PATH (because
 Thomas> the gdb configure step gets run with TARGET_MAKE_ENV).

 Thomas> But then, the build fails, because it tries to run gawk, but gawk
 Thomas> isn't in the PATH, because we forget to use this TARGET_MAKE_ENV
 Thomas> variable when building gdbserver.

Committed, thanks.

Patch

diff --git a/toolchain/gdb/gdb.mk b/toolchain/gdb/gdb.mk
index 4b8fe3a..a932b1f 100644
--- a/toolchain/gdb/gdb.mk
+++ b/toolchain/gdb/gdb.mk
@@ -144,6 +144,7 @@  $(GDB_SERVER_DIR)/.configured: $(GDB_DIR)/.unpacked
 	touch $@
 
 $(GDB_SERVER_DIR)/gdbserver: $(GDB_SERVER_DIR)/.configured
+	$(TARGET_MAKE_ENV) \
 	$(MAKE) CC="$(TARGET_CC)" MT_CFLAGS="$(TARGET_CFLAGS)" \
 		-C $(GDB_SERVER_DIR)