Patchwork i2c/i2c-mxs: use devm_request_and_ioremap

login
register
mail settings
Submitter Peter Hüwe
Date Feb. 3, 2013, 12:14 a.m.
Message ID <1359850497-927-1-git-send-email-peterhuewe@gmx.de>
Download mbox | patch
Permalink /patch/217717/
State Rejected
Headers show

Comments

Peter Hüwe - Feb. 3, 2013, 12:14 a.m.
Replace a call to devm_request_mem_region followed by a call to
dev_ioremap_nocache with devm_request_and_ioremap which does the same.
And since res_size isn't needed anymore we can remove it as well.

Found with coccicheck and this semantic patch:
 scripts/coccinelle/api/devm_request_and_ioremap.cocci.

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
---
 drivers/i2c/busses/i2c-mxs.c |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)
Wolfram Sang - Feb. 15, 2013, 7:04 p.m.
On Sat, Feb 02, 2013 at 02:14:57PM -0000, =?utf-8?q?Peter_H=C3=BCwe_=3CPeterHuewe=40gmx=2Ede=3E?= wrote:

> Replace a call to devm_request_mem_region followed by a call to
> dev_ioremap_nocache with devm_request_and_ioremap which does the same.
> And since res_size isn't needed anymore we can remove it as well.

Since this is the only change, we better wait for devm_ioremap_resource
in 3.9.

--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/i2c/busses/i2c-mxs.c b/drivers/i2c/busses/i2c-mxs.c
index d6abaf2..4ca92b6 100644
--- a/drivers/i2c/busses/i2c-mxs.c
+++ b/drivers/i2c/busses/i2c-mxs.c
@@ -439,7 +439,6 @@  static int mxs_i2c_probe(struct platform_device *pdev)
 	struct i2c_adapter *adap;
 	struct pinctrl *pinctrl;
 	struct resource *res;
-	resource_size_t res_size;
 	int err, irq, dmairq;
 	dma_cap_mask_t mask;
 
@@ -458,11 +457,7 @@  static int mxs_i2c_probe(struct platform_device *pdev)
 	if (!res || irq < 0 || dmairq < 0)
 		return -ENOENT;
 
-	res_size = resource_size(res);
-	if (!devm_request_mem_region(dev, res->start, res_size, res->name))
-		return -EBUSY;
-
-	i2c->regs = devm_ioremap_nocache(dev, res->start, res_size);
+	i2c->regs = devm_request_and_ioremap(dev, res);
 	if (!i2c->regs)
 		return -EBUSY;