Patchwork [for-1.4?,qom-cpu-next,1/9] target-s390x: Drop unused cpu_s390x_close() prototype

login
register
mail settings
Submitter Andreas Färber
Date Feb. 2, 2013, 11:57 a.m.
Message ID <1359806247-27799-2-git-send-email-afaerber@suse.de>
Download mbox | patch
Permalink /patch/217652/
State New
Headers show

Comments

Andreas Färber - Feb. 2, 2013, 11:57 a.m.
It was never implemented.

Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 target-s390x/cpu.h |    1 -
 1 Datei geändert, 1 Zeile entfernt(-)
Andreas Färber - Feb. 15, 2013, 5:44 p.m.
Alex,

Am 02.02.2013 12:57, schrieb Andreas Färber:
> It was never implemented.
> 
> Signed-off-by: Andreas Färber <afaerber@suse.de>

Too late for 1.4 now obviously. ;)

Do you want to queue this on s390-next (i.e.,do you plan an early pull)?
Or should I put it in qom-cpu-next?

The remainder of the series is waiting on my VMState series, which seems
unlikely to go into qom-cpu-next before the merge window.

Andreas

> ---
>  target-s390x/cpu.h |    1 -
>  1 Datei geändert, 1 Zeile entfernt(-)
> 
> diff --git a/target-s390x/cpu.h b/target-s390x/cpu.h
> index 01e59b9..0070c40 100644
> --- a/target-s390x/cpu.h
> +++ b/target-s390x/cpu.h
> @@ -315,7 +315,6 @@ static inline int get_ilen(uint8_t opc)
>  S390CPU *cpu_s390x_init(const char *cpu_model);
>  void s390x_translate_init(void);
>  int cpu_s390x_exec(CPUS390XState *s);
> -void cpu_s390x_close(CPUS390XState *s);
>  void do_interrupt (CPUS390XState *env);
>  
>  /* you can call this signal handler from your SIGBUS and SIGSEGV
Alexander Graf - Feb. 15, 2013, 5:47 p.m.
On 15.02.2013, at 18:44, Andreas Färber wrote:

> Alex,
> 
> Am 02.02.2013 12:57, schrieb Andreas Färber:
>> It was never implemented.
>> 
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
> 
> Too late for 1.4 now obviously. ;)
> 
> Do you want to queue this on s390-next (i.e.,do you plan an early pull)?
> Or should I put it in qom-cpu-next?

Just put it into qom-cpu-next :)


Alex

> 
> The remainder of the series is waiting on my VMState series, which seems
> unlikely to go into qom-cpu-next before the merge window.
> 
> Andreas
> 
>> ---
>> target-s390x/cpu.h |    1 -
>> 1 Datei geändert, 1 Zeile entfernt(-)
>> 
>> diff --git a/target-s390x/cpu.h b/target-s390x/cpu.h
>> index 01e59b9..0070c40 100644
>> --- a/target-s390x/cpu.h
>> +++ b/target-s390x/cpu.h
>> @@ -315,7 +315,6 @@ static inline int get_ilen(uint8_t opc)
>> S390CPU *cpu_s390x_init(const char *cpu_model);
>> void s390x_translate_init(void);
>> int cpu_s390x_exec(CPUS390XState *s);
>> -void cpu_s390x_close(CPUS390XState *s);
>> void do_interrupt (CPUS390XState *env);
>> 
>> /* you can call this signal handler from your SIGBUS and SIGSEGV
> 
> -- 
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
Andreas Färber - Feb. 16, 2013, 3:47 p.m.
Am 15.02.2013 18:47, schrieb Alexander Graf:
> 
> On 15.02.2013, at 18:44, Andreas Färber wrote:
> 
>> Alex,
>>
>> Am 02.02.2013 12:57, schrieb Andreas Färber:
>>> It was never implemented.
>>>
>>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>>
>> Too late for 1.4 now obviously. ;)
>>
>> Do you want to queue this on s390-next (i.e.,do you plan an early pull)?
>> Or should I put it in qom-cpu-next?
> 
> Just put it into qom-cpu-next :)

Thanks, applied to qom-cpu:
https://github.com/afaerber/qemu-cpu/commits/qom-cpu

Andreas

Patch

diff --git a/target-s390x/cpu.h b/target-s390x/cpu.h
index 01e59b9..0070c40 100644
--- a/target-s390x/cpu.h
+++ b/target-s390x/cpu.h
@@ -315,7 +315,6 @@  static inline int get_ilen(uint8_t opc)
 S390CPU *cpu_s390x_init(const char *cpu_model);
 void s390x_translate_init(void);
 int cpu_s390x_exec(CPUS390XState *s);
-void cpu_s390x_close(CPUS390XState *s);
 void do_interrupt (CPUS390XState *env);
 
 /* you can call this signal handler from your SIGBUS and SIGSEGV