Patchwork [1/2] tap: unbreak -netdev tap,fd=X

login
register
mail settings
Submitter Anthony Liguori
Date Feb. 2, 2013, 12:08 a.m.
Message ID <1359763709-17712-1-git-send-email-aliguori@us.ibm.com>
Download mbox | patch
Permalink /patch/217629/
State New
Headers show

Comments

Anthony Liguori - Feb. 2, 2013, 12:08 a.m.
The multiqueue patch series broke -netdev tap,fd=X which manifests
as libvirt not being able to start a guest.  This was because it
passed NULL for the netdev name which results in an anonymous netdev
device regardless of what the user specified.

Cc: Jason Wang <jasowang@redhat.com>
Cc: Bruce Rogers <brogers@suse.com>
Reported-by: Bruce Rogers <brogers@suse.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
---
 net/tap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Anthony Liguori - Feb. 4, 2013, 10:50 p.m.
Applied.  Thanks.

Regards,

Anthony Liguori

Patch

diff --git a/net/tap.c b/net/tap.c
index 1bf7609..48c254e 100644
--- a/net/tap.c
+++ b/net/tap.c
@@ -711,7 +711,7 @@  int net_init_tap(const NetClientOptions *opts, const char *name,
 
         vnet_hdr = tap_probe_vnet_hdr(fd);
 
-        if (net_init_tap_one(tap, peer, "tap", NULL, NULL,
+        if (net_init_tap_one(tap, peer, "tap", name, NULL,
                              script, downscript,
                              vhostfdname, vnet_hdr, fd)) {
             return -1;