Patchwork configure: Fix build with XFree

login
register
mail settings
Submitter Richard Henderson
Date Feb. 1, 2013, 10:32 p.m.
Message ID <1359757954-2136-1-git-send-email-rth@twiddle.net>
Download mbox | patch
Permalink /patch/217605/
State New
Headers show

Comments

Richard Henderson - Feb. 1, 2013, 10:32 p.m.
The build is broken on ppc64-linux, possibly only with new binutils:

ld: hw/lm32/../milkymist-tmu2.o: undefined reference to symbol 'XFree'
ld: note: 'XFree' is defined in DSO /lib64/libX11.so.6 so try \
  adding it to the linker command line

So let's follow the linker's advice.

Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Richard Henderson - Feb. 3, 2013, 5:17 p.m.
I should have put for-1.4 in the subject...

r~


On 2013-02-01 14:32, Richard Henderson wrote:
> The build is broken on ppc64-linux, possibly only with new binutils:
>
> ld: hw/lm32/../milkymist-tmu2.o: undefined reference to symbol 'XFree'
> ld: note: 'XFree' is defined in DSO /lib64/libX11.so.6 so try \
>    adding it to the linker command line
>
> So let's follow the linker's advice.
>
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>   configure | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 0657b1a..8789324 100755
> --- a/configure
> +++ b/configure
> @@ -2388,7 +2388,7 @@ fi
>   ##########################################
>   # opengl probe, used by milkymist-tmu2
>   if test "$opengl" != "no" ; then
> -  opengl_libs="-lGL"
> +  opengl_libs="-lGL -lX11"
>     cat > $TMPC << EOF
>   #include <X11/Xlib.h>
>   #include <GL/gl.h>
>
Anthony Liguori - Feb. 6, 2013, 8:41 p.m.
Applied.  Thanks.

Regards,

Anthony Liguori

Patch

diff --git a/configure b/configure
index 0657b1a..8789324 100755
--- a/configure
+++ b/configure
@@ -2388,7 +2388,7 @@  fi
 ##########################################
 # opengl probe, used by milkymist-tmu2
 if test "$opengl" != "no" ; then
-  opengl_libs="-lGL"
+  opengl_libs="-lGL -lX11"
   cat > $TMPC << EOF
 #include <X11/Xlib.h>
 #include <GL/gl.h>