Patchwork [6/6,AArch64-4.7] Backport: Fix warning in aarch64.md

login
register
mail settings
Submitter James Greenhalgh
Date Feb. 1, 2013, 5:42 p.m.
Message ID <1359740555-10179-7-git-send-email-james.greenhalgh@arm.com>
Download mbox | patch
Permalink /patch/217550/
State New
Headers show

Comments

James Greenhalgh - Feb. 1, 2013, 5:42 p.m.
Hi,

This patch is a backport of one approved here:
http://gcc.gnu.org/ml/gcc-patches/2012-12/msg01135.html

The patch fixes the warning:

config/aarch64/aarch64.md:840: warning: source missing a mode?

Regression tested with no regressions on aarch64-none-elf.

OK for aarch64-4.7-branch?

Thanks,
James

---
gcc/

2013-02-01  James Greenhalgh  <james.greenhalgh@arm.com>

	Backport from mainline.
	2012-12-18  James Greenhalgh  <james.greenhalgh@arm.com>

	* config/aarch64/aarch64.md (insv_imm<mode>): Add modes
	for source operands.
Richard Earnshaw - Feb. 2, 2013, 2:25 p.m.
On 01/02/13 17:42, James Greenhalgh wrote:
>
> Hi,
>
> This patch is a backport of one approved here:
> http://gcc.gnu.org/ml/gcc-patches/2012-12/msg01135.html
>
> The patch fixes the warning:
>
> config/aarch64/aarch64.md:840: warning: source missing a mode?
>
> Regression tested with no regressions on aarch64-none-elf.
>
> OK for aarch64-4.7-branch?
>
> Thanks,
> James
>
> ---
> gcc/
>
> 2013-02-01  James Greenhalgh  <james.greenhalgh@arm.com>
>
> 	Backport from mainline.
> 	2012-12-18  James Greenhalgh  <james.greenhalgh@arm.com>
>
> 	* config/aarch64/aarch64.md (insv_imm<mode>): Add modes
> 	for source operands.
>

OK.

R.

Patch

diff --git a/gcc/config/aarch64/aarch64.md b/gcc/config/aarch64/aarch64.md
index 6f51469..9bb95e0 100644
--- a/gcc/config/aarch64/aarch64.md
+++ b/gcc/config/aarch64/aarch64.md
@@ -840,8 +840,8 @@ 
 (define_insn "insv_imm<mode>"
   [(set (zero_extract:GPI (match_operand:GPI 0 "register_operand" "+r")
 			  (const_int 16)
-			  (match_operand 1 "const_int_operand" "n"))
-	(match_operand 2 "const_int_operand" "n"))]
+			  (match_operand:GPI 1 "const_int_operand" "n"))
+	(match_operand:GPI 2 "const_int_operand" "n"))]
   "INTVAL (operands[1]) < GET_MODE_BITSIZE (<MODE>mode)
    && INTVAL (operands[1]) % 16 == 0
    && INTVAL (operands[2]) <= 0xffff"