From patchwork Fri Feb 1 17:21:03 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuck Lever X-Patchwork-Id: 217536 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "userp1040.oracle.com", Issuer "VeriSign Class 3 International Server CA - G3" (not verified)) by ozlabs.org (Postfix) with ESMTPS id B0EEB2C0095 for ; Sat, 2 Feb 2013 04:21:10 +1100 (EST) Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by userp1040.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id r11HL7AO001783 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 1 Feb 2013 17:21:08 GMT Received: from oss.oracle.com (oss-external.oracle.com [137.254.96.51]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r11HL6Hj007410 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 1 Feb 2013 17:21:07 GMT Received: from localhost ([127.0.0.1] helo=oss.oracle.com) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1U1KIU-0006fL-M5; Fri, 01 Feb 2013 09:21:06 -0800 Received: from aserp1030.oracle.com ([141.146.126.68]) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1U1KIT-0006fE-Cw for fedfs-utils-devel@oss.oracle.com; Fri, 01 Feb 2013 09:21:05 -0800 Received: from mail-ia0-f174.google.com (mail-ia0-f174.google.com [209.85.210.174]) by aserp1030.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r11HL4G8010651 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=OK) for ; Fri, 1 Feb 2013 17:21:05 GMT Received: by mail-ia0-f174.google.com with SMTP id o25so5668152iad.33 for ; Fri, 01 Feb 2013 09:21:04 -0800 (PST) X-Received: by 10.50.88.226 with SMTP id bj2mr1796053igb.105.1359739264319; Fri, 01 Feb 2013 09:21:04 -0800 (PST) Received: from seurat.1015granger.net (adsl-99-26-161-222.dsl.sfldmi.sbcglobal.net. [99.26.161.222]) by mx.google.com with ESMTPS id xn10sm2988851igb.4.2013.02.01.09.21.03 (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 01 Feb 2013 09:21:03 -0800 (PST) From: Chuck Lever To: fedfs-utils-devel@oss.oracle.com Date: Fri, 01 Feb 2013 12:21:03 -0500 Message-ID: <20130201172102.63192.7503.stgit@seurat.1015granger.net> In-Reply-To: <20130201171714.63192.68358.stgit@seurat.1015granger.net> References: <20130201171714.63192.68358.stgit@seurat.1015granger.net> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 X-Flow-Control-Info: class=Default reputation=ipRepBelow100 ip=209.85.210.174 ct-class=R5 ct-vol1=-89 ct-vol2=8 ct-vol3=8 ct-risk=50 ct-spam1=83 ct-spam2=5 ct-bulk=5 rcpts=1 size=1610 X-MM-CT-Classification: not spam X-MM-CT-RefID: str=0001.0A090208.510BF981.0021, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 Subject: [fedfs-utils] [PATCH 09/13] fedfsc: Explicitly report missing NSDB paramaters X-BeenThere: fedfs-utils-devel@oss.oracle.com X-Mailman-Version: 2.1.9 Precedence: list Reply-To: fedfs-utils Developers List-Id: fedfs-utils Developers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: fedfs-utils-devel-bounces@oss.oracle.com Errors-To: fedfs-utils-devel-bounces@oss.oracle.com X-Source-IP: acsinet21.oracle.com [141.146.126.237] Clean up: code in fedfs-get-limited-nsdb-params and fedfs-get-nsdb-params should report that the server does not have the requested connection parameters, rather than just reporting the error code. Signed-off-by: Chuck Lever --- src/fedfsc/fedfs-get-limited-nsdb-params.c | 5 +++++ src/fedfsc/fedfs-get-nsdb-params.c | 5 +++++ 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/src/fedfsc/fedfs-get-limited-nsdb-params.c b/src/fedfsc/fedfs-get-limited-nsdb-params.c index 7bda6eb..7bfb535 100644 --- a/src/fedfsc/fedfs-get-limited-nsdb-params.c +++ b/src/fedfsc/fedfs-get-limited-nsdb-params.c @@ -91,6 +91,11 @@ fedfs_get_limited_nsdb_params_print_result(FedFsGetNsdbParamsRes result) { FedFsNsdbParams *params = &result.FedFsGetNsdbParamsRes_u.params; + if (result.status == FEDFS_ERR_NSDB_PARAMS) { + printf("No connection parameters found\n"); + return; + } + nsdb_print_fedfsstatus(result.status); if (result.status != FEDFS_OK) return; diff --git a/src/fedfsc/fedfs-get-nsdb-params.c b/src/fedfsc/fedfs-get-nsdb-params.c index b8c7995..459c56d 100644 --- a/src/fedfsc/fedfs-get-nsdb-params.c +++ b/src/fedfsc/fedfs-get-nsdb-params.c @@ -95,6 +95,11 @@ fedfs_get_nsdb_params_print_result(FedFsGetNsdbParamsRes result, { FedFsNsdbParams *params = &result.FedFsGetNsdbParamsRes_u.params; + if (result.status == FEDFS_ERR_NSDB_PARAMS) { + printf("No connection parameters found\n"); + return; + } + nsdb_print_fedfsstatus(result.status); if (result.status != FEDFS_OK) return;