Patchwork [buildbot,4/6] use --disable-debug-info

login
register
mail settings
Submitter Gerd Hoffmann
Date Feb. 1, 2013, 2:02 p.m.
Message ID <1359727345-10477-5-git-send-email-kraxel@redhat.com>
Download mbox | patch
Permalink /patch/217496/
State New
Headers show

Comments

Gerd Hoffmann - Feb. 1, 2013, 2:02 p.m.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 qemu-master.cfg |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Stefan Hajnoczi - Feb. 4, 2013, 9:26 a.m.
On Fri, Feb 01, 2013 at 03:02:23PM +0100, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  qemu-master.cfg |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

What is the rationale for these changes:

--disable-debug-info to save buildslave disk space?

Remove CFLAGS=-O2?

> diff --git a/qemu-master.cfg b/qemu-master.cfg
> index dc5a7a8..2502ced 100644
> --- a/qemu-master.cfg
> +++ b/qemu-master.cfg
> @@ -696,9 +696,11 @@ def create_build_factory(repourl, branch="HEAD",
>                                 env={'LANG': 'C'}))
>          workdir = os.path.join(workdir, 'outoftree')
>          configure = "../configure"
> -    f.addStep(Configure(command=[configure] + list(configure_args),
> +    f.addStep(Configure(command=[configure,
> +                                 "--disable-debug-info"] +
> +                        list(configure_args),
>                          env={'LANG': 'C'}, workdir=workdir))
> -    f.addStep(Compile(command=[make, "CFLAGS=-O2"],
> +    f.addStep(Compile(command=[make],
>                        env={'LANG': 'C'},
>                        timeout=2400,
>                        workdir=workdir))
> -- 
> 1.7.9.7
> 
>
Gerd Hoffmann - Feb. 4, 2013, 9:59 a.m.
On 02/04/13 10:26, Stefan Hajnoczi wrote:
> On Fri, Feb 01, 2013 at 03:02:23PM +0100, Gerd Hoffmann wrote:
>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>> ---
>>  qemu-master.cfg |    6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> What is the rationale for these changes:
> 
> --disable-debug-info to save buildslave disk space?

Yes.

> Remove CFLAGS=-O2?

That was used to remove '-g' before we had --disable-debug-info, so it
isn't needed any more.

So there doesn't change much, except that the "make check" tests now are
build without debug info too.

cheers,
  Gerd
Stefan Hajnoczi - Feb. 4, 2013, 11:43 a.m.
On Mon, Feb 04, 2013 at 10:59:33AM +0100, Gerd Hoffmann wrote:
> On 02/04/13 10:26, Stefan Hajnoczi wrote:
> > On Fri, Feb 01, 2013 at 03:02:23PM +0100, Gerd Hoffmann wrote:
> >> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> >> ---
> >>  qemu-master.cfg |    6 ++++--
> >>  1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > What is the rationale for these changes:
> > 
> > --disable-debug-info to save buildslave disk space?
> 
> Yes.
> 
> > Remove CFLAGS=-O2?
> 
> That was used to remove '-g' before we had --disable-debug-info, so it
> isn't needed any more.
> 
> So there doesn't change much, except that the "make check" tests now are
> build without debug info too.

Thanks for explaining.

Stefan

Patch

diff --git a/qemu-master.cfg b/qemu-master.cfg
index dc5a7a8..2502ced 100644
--- a/qemu-master.cfg
+++ b/qemu-master.cfg
@@ -696,9 +696,11 @@  def create_build_factory(repourl, branch="HEAD",
                                env={'LANG': 'C'}))
         workdir = os.path.join(workdir, 'outoftree')
         configure = "../configure"
-    f.addStep(Configure(command=[configure] + list(configure_args),
+    f.addStep(Configure(command=[configure,
+                                 "--disable-debug-info"] +
+                        list(configure_args),
                         env={'LANG': 'C'}, workdir=workdir))
-    f.addStep(Compile(command=[make, "CFLAGS=-O2"],
+    f.addStep(Compile(command=[make],
                       env={'LANG': 'C'},
                       timeout=2400,
                       workdir=workdir))