From patchwork Fri Feb 1 14:54:54 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jouke Witteveen X-Patchwork-Id: 217484 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from maxx.maxx.shmoo.com (maxx.shmoo.com [205.134.188.171]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "maxx.shmoo.com", Issuer "CA Cert Signing Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 010CF2C0091 for ; Sat, 2 Feb 2013 01:55:29 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by maxx.maxx.shmoo.com (Postfix) with ESMTP id 43EBF9D250; Fri, 1 Feb 2013 09:55:27 -0500 (EST) X-Virus-Scanned: amavisd-new at maxx.shmoo.com Received: from maxx.maxx.shmoo.com ([127.0.0.1]) by localhost (maxx.shmoo.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qGgNzme3xBST; Fri, 1 Feb 2013 09:55:27 -0500 (EST) Received: from maxx.shmoo.com (localhost [127.0.0.1]) by maxx.maxx.shmoo.com (Postfix) with ESMTP id DA3739D240; Fri, 1 Feb 2013 09:55:22 -0500 (EST) X-Original-To: mailman-post+hostap@maxx.shmoo.com Delivered-To: mailman-post+hostap@maxx.shmoo.com Received: from localhost (localhost [127.0.0.1]) by maxx.maxx.shmoo.com (Postfix) with ESMTP id A6C029D240 for ; Fri, 1 Feb 2013 09:55:20 -0500 (EST) X-Virus-Scanned: amavisd-new at maxx.shmoo.com Received: from maxx.maxx.shmoo.com ([127.0.0.1]) by localhost (maxx.shmoo.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lrKFHZgzXDOT for ; Fri, 1 Feb 2013 09:55:16 -0500 (EST) Received: from mail-ee0-f47.google.com (mail-ee0-f47.google.com [74.125.83.47]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by maxx.maxx.shmoo.com (Postfix) with ESMTPS id 914489D20E for ; Fri, 1 Feb 2013 09:55:16 -0500 (EST) Received: by mail-ee0-f47.google.com with SMTP id e52so2078731eek.6 for ; Fri, 01 Feb 2013 06:55:15 -0800 (PST) X-Received: by 10.14.210.132 with SMTP id u4mr39255131eeo.19.1359730514845; Fri, 01 Feb 2013 06:55:14 -0800 (PST) MIME-Version: 1.0 Received: by 10.14.176.4 with HTTP; Fri, 1 Feb 2013 06:54:54 -0800 (PST) In-Reply-To: References: <20130128103433.GA1247@Mindship-03.lan> <1359370308.8120.0.camel@jlt4.sipsolutions.net> <5106DADA.7040704@candelatech.com> <510A7058.8010607@broadcom.com> From: Jouke Witteveen Date: Fri, 1 Feb 2013 15:54:54 +0100 Message-ID: Subject: Re: [PATCH] Migrate from /var/run to /run To: sven falempin Cc: "hostap@lists.shmoo.com" X-BeenThere: hostap@lists.shmoo.com X-Mailman-Version: 2.1.9 Precedence: list List-Id: HostAP Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: hostap-bounces@lists.shmoo.com Errors-To: hostap-bounces@lists.shmoo.com On Fri, Feb 1, 2013 at 3:25 PM, sven falempin wrote: > On Fri, Feb 1, 2013 at 5:03 AM, Holger Schurig > wrote: >> >> Arend, I fear that those "deployed systems" that don't do the switch from >> /var/run to /run will also not do the switch from >> wpa_supplicant_ to wpa_supplicant_2.x. >> >> >> 2013/1/31 Arend van Spriel >>> >>> On 01/31/2013 02:10 PM, Jouke Witteveen wrote: >>> > Nevertheless I do think this should be merged. The critiques by Sven >>> > Falempin and Ben Greear do not seem entirely correct and at least the >>> > following distributions have already made the switch (so things should >>> > only improve there): Arch Linux, Debian, Fedora, Suse, Ubuntu. >>> >>> They may have, but you seem to be simply overstepping the fact that >>> there are a lot of deployed systems out there that do not have made the >>> switch and may have no intention to make it at all. Can you hold the >>> patch for another 5 years so those system are safely turned to compost >>> ;-) >>> >>> >> > Regards, >>> >> > - Jouke >>> > > > i just dont like constant in code, if all the linux system choose to yet > again to become 'different' and adopt /run instead of /var/run 'because /var > is not mounted' i see no reason for keepinf /var//run as a default, > but a DEFINE in config.h or even in .config would make a good deal , wouldnt > it ? Almost all changes are documentation and examples. The functional change is already as you would like it: > >>> >>> Regards, >>> Arend >>> >>> _______________________________________________ >>> HostAP mailing list >>> HostAP@lists.shmoo.com >>> http://lists.shmoo.com/mailman/listinfo/hostap >> >> >> >> _______________________________________________ >> HostAP mailing list >> HostAP@lists.shmoo.com >> http://lists.shmoo.com/mailman/listinfo/hostap >> > > > > -- > --------------------------------------------------------------------------------------------------------------------- > () ascii ribbon campaign - against html e-mail > /\ > > _______________________________________________ > HostAP mailing list > HostAP@lists.shmoo.com > http://lists.shmoo.com/mailman/listinfo/hostap > diff --git a/wpa_supplicant/wpa_cli.c b/wpa_supplicant/wpa_cli.c index 632db80..dc079d6 100644 --- a/wpa_supplicant/wpa_cli.c +++ b/wpa_supplicant/wpa_cli.c @@ -73,7 +73,7 @@ static int wpa_cli_attached = 0; static int wpa_cli_connected = 0; static int wpa_cli_last_id = 0; #ifndef CONFIG_CTRL_IFACE_DIR -#define CONFIG_CTRL_IFACE_DIR "/var/run/wpa_supplicant" +#define CONFIG_CTRL_IFACE_DIR "/run/wpa_supplicant" #endif /* CONFIG_CTRL_IFACE_DIR */ static const char *ctrl_iface_dir = CONFIG_CTRL_IFACE_DIR; static char *ctrl_ifname = NULL;