Patchwork Migrate from /var/run to /run

login
register
mail settings
Submitter Jouke Witteveen
Date Feb. 1, 2013, 2:54 p.m.
Message ID <CAJ2ouawawcH32dR5d9FpNxmMdpwBV841aOeRG3aX3wBuwX_xYA@mail.gmail.com>
Download mbox | patch
Permalink /patch/217484/
State Superseded
Headers show

Comments

Jouke Witteveen - Feb. 1, 2013, 2:54 p.m.
On Fri, Feb 1, 2013 at 3:25 PM, sven falempin <sven.falempin@gmail.com> wrote:
> On Fri, Feb 1, 2013 at 5:03 AM, Holger Schurig <holgerschurig@gmail.com>
> wrote:
>>
>> Arend, I fear that those "deployed systems" that don't do the switch from
>> /var/run to /run will also not do the switch from
>> wpa_supplicant_<antique-version> to wpa_supplicant_2.x.
>>
>>
>> 2013/1/31 Arend van Spriel <arend@broadcom.com>
>>>
>>> On 01/31/2013 02:10 PM, Jouke Witteveen wrote:
>>> > Nevertheless I do think this should be merged. The critiques by Sven
>>> > Falempin and Ben Greear do not seem entirely correct and at least the
>>> > following distributions have already made the switch (so things should
>>> > only improve there): Arch Linux, Debian, Fedora, Suse, Ubuntu.
>>>
>>> They may have, but you seem to be simply overstepping the fact that
>>> there are a lot of deployed systems out there that do not have made the
>>> switch and may have no intention to make it at all. Can you hold the
>>> patch for another 5 years so those system are safely turned to compost
>>> ;-)
>>>
>>> >> > Regards,
>>> >> > - Jouke
>>>
>
>
> i just dont like constant in code, if all the linux system choose to yet
> again to become 'different' and adopt /run instead of /var/run 'because /var
> is not mounted' i see no reason for keepinf /var//run as a default,
> but a DEFINE in config.h or even in .config would make a good deal , wouldnt
> it ?

Almost all changes are documentation and examples. The functional
change is already as you would like it:


>
>>>
>>> Regards,
>>> Arend
>>>
>>> _______________________________________________
>>> HostAP mailing list
>>> HostAP@lists.shmoo.com
>>> http://lists.shmoo.com/mailman/listinfo/hostap
>>
>>
>>
>> _______________________________________________
>> HostAP mailing list
>> HostAP@lists.shmoo.com
>> http://lists.shmoo.com/mailman/listinfo/hostap
>>
>
>
>
> --
> ---------------------------------------------------------------------------------------------------------------------
> () ascii ribbon campaign - against html e-mail
> /\
>
> _______________________________________________
> HostAP mailing list
> HostAP@lists.shmoo.com
> http://lists.shmoo.com/mailman/listinfo/hostap
>

Patch

diff --git a/wpa_supplicant/wpa_cli.c b/wpa_supplicant/wpa_cli.c
index 632db80..dc079d6 100644
--- a/wpa_supplicant/wpa_cli.c
+++ b/wpa_supplicant/wpa_cli.c
@@ -73,7 +73,7 @@  static int wpa_cli_attached = 0;
 static int wpa_cli_connected = 0;
 static int wpa_cli_last_id = 0;
 #ifndef CONFIG_CTRL_IFACE_DIR
-#define CONFIG_CTRL_IFACE_DIR "/var/run/wpa_supplicant"
+#define CONFIG_CTRL_IFACE_DIR "/run/wpa_supplicant"
 #endif /* CONFIG_CTRL_IFACE_DIR */
 static const char *ctrl_iface_dir = CONFIG_CTRL_IFACE_DIR;
 static char *ctrl_ifname = NULL;