Patchwork net/cadence: don't build by default

login
register
mail settings
Submitter Riccardo Magliocchetti
Date Jan. 31, 2013, 6:26 p.m.
Message ID <1359656815-27919-1-git-send-email-riccardo.magliocchetti@gmail.com>
Download mbox | patch
Permalink /patch/217235/
State Rejected
Delegated to: David Miller
Headers show

Comments

Riccardo Magliocchetti - Jan. 31, 2013, 6:26 p.m.
No need to build net/cadence driver by default.

Signed-off-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
---
 drivers/net/ethernet/cadence/Kconfig |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
David Miller - Jan. 31, 2013, 6:57 p.m.
From: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
Date: Thu, 31 Jan 2013 19:26:55 +0100

> No need to build net/cadence driver by default.
> 
> Signed-off-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>

Vendor guards are set yes on purpose, because it mimicks for compatability
the behavior that existed before the vendor guards were in place.

These checks guard families of drivers from being offered, rather than
the drivers themselves.

I'm not applying this patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Riccardo Magliocchetti - Jan. 31, 2013, 7:03 p.m.
Il 31/01/2013 19:57, David Miller ha scritto:
> From: Riccardo Magliocchetti<riccardo.magliocchetti@gmail.com>
> Date: Thu, 31 Jan 2013 19:26:55 +0100
>
>> No need to build net/cadence driver by default.
>>
>> Signed-off-by: Riccardo Magliocchetti<riccardo.magliocchetti@gmail.com>
>
> Vendor guards are set yes on purpose, because it mimicks for compatability
> the behavior that existed before the vendor guards were in place.
>
> These checks guard families of drivers from being offered, rather than
> the drivers themselves.
>
> I'm not applying this patch.

Indeed, seen the default Y during make oldconfig and overreacted. Sorry 
for the noise.

riccardo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/ethernet/cadence/Kconfig b/drivers/net/ethernet/cadence/Kconfig
index ceb0de0..8901951 100644
--- a/drivers/net/ethernet/cadence/Kconfig
+++ b/drivers/net/ethernet/cadence/Kconfig
@@ -5,13 +5,12 @@ 
 config NET_CADENCE
 	bool "Cadence devices"
 	depends on HAS_IOMEM
-	default y
 	---help---
 	  If you have a network (Ethernet) card belonging to this class, say Y.
 	  Make sure you know the name of your card. Read the Ethernet-HOWTO,
 	  available from <http://www.tldp.org/docs.html#howto>.
 
-	  If unsure, say Y.
+	  If unsure, say N.
 
 	  Note that the answer to this question doesn't directly affect the
 	  kernel: saying N will just cause the configurator to skip all