Patchwork [net,v2] tcp: Update MIB counters for drops

login
register
mail settings
Submitter Vijay Subramanian
Date Jan. 31, 2013, 6:24 p.m.
Message ID <1359656646-29339-1-git-send-email-subramanian.vijay@gmail.com>
Download mbox | patch
Permalink /patch/217233/
State Accepted
Delegated to: David Miller
Headers show

Comments

Vijay Subramanian - Jan. 31, 2013, 6:24 p.m.
This patch updates LINUX_MIB_LISTENDROPS in tcp_v4_conn_request() and
tcp_v4_err(). tcp_v4_conn_request() in particular can drop SYNs for various
reasons which are not currently tracked.

Signed-off-by: Vijay Subramanian <subramanian.vijay@gmail.com>
---
Changes from V1: Removed one needless update to ListenOverflows.

 net/ipv4/tcp_ipv4.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
David Miller - Feb. 4, 2013, 6:06 p.m.
From: Vijay Subramanian <subramanian.vijay@gmail.com>
Date: Thu, 31 Jan 2013 10:24:06 -0800

> This patch updates LINUX_MIB_LISTENDROPS in tcp_v4_conn_request() and
> tcp_v4_err(). tcp_v4_conn_request() in particular can drop SYNs for various
> reasons which are not currently tracked.
> 
> Signed-off-by: Vijay Subramanian <subramanian.vijay@gmail.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
index 629937d..eadb693 100644
--- a/net/ipv4/tcp_ipv4.c
+++ b/net/ipv4/tcp_ipv4.c
@@ -496,6 +496,7 @@  void tcp_v4_err(struct sk_buff *icmp_skb, u32 info)
 		 * errors returned from accept().
 		 */
 		inet_csk_reqsk_queue_drop(sk, req, prev);
+		NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_LISTENDROPS);
 		goto out;
 
 	case TCP_SYN_SENT:
@@ -1502,7 +1503,6 @@  int tcp_v4_conn_request(struct sock *sk, struct sk_buff *skb)
 	 */
 	if (sk_acceptq_is_full(sk) && inet_csk_reqsk_queue_young(sk) > 1) {
 		NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_LISTENOVERFLOWS);
-		NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_LISTENDROPS);
 		goto drop;
 	}
 
@@ -1669,6 +1669,7 @@  drop_and_release:
 drop_and_free:
 	reqsk_free(req);
 drop:
+	NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_LISTENDROPS);
 	return 0;
 }
 EXPORT_SYMBOL(tcp_v4_conn_request);