Patchwork [3.5.y.z,extended,stable] Patch "i2c: mxs: Fix type of error code" has been added to staging queue

mail settings
Submitter Herton Ronaldo Krzesinski
Date Jan. 30, 2013, 9:58 p.m.
Message ID <>
Download mbox | patch
Permalink /patch/217022/
State New
Headers show


Herton Ronaldo Krzesinski - Jan. 30, 2013, 9:58 p.m.
This is a note to let you know that I have just added a patch titled

    i2c: mxs: Fix type of error code

to the linux-3.5.y-queue branch of the 3.5.y.z extended stable tree 
which can be found at:;a=shortlog;h=refs/heads/linux-3.5.y-queue

If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.5.y.z tree, see



From 0846aaf93ebc528463962535ba146f984ce53cd5 Mon Sep 17 00:00:00 2001
From: Fabio Estevam <>
Date: Mon, 7 Jan 2013 22:32:06 -0200
Subject: [PATCH] i2c: mxs: Fix type of error code

commit 0f40cbc4f85e13b1a42ae2f41231645a14965872 upstream.

cmd_err is used to handle error code, so it should not be unsigned.

This fixes the following warning when building with W=1 option:

drivers/i2c/busses/i2c-mxs.c: In function 'mxs_i2c_xfer_msg':
drivers/i2c/busses/i2c-mxs.c:331:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

Signed-off-by: Fabio Estevam <>
Acked-by: Marek Vasut <>
Signed-off-by: Wolfram Sang <>
[ herton: adjust context ]
Signed-off-by: Herton Ronaldo Krzesinski <>
 drivers/i2c/busses/i2c-mxs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/drivers/i2c/busses/i2c-mxs.c b/drivers/i2c/busses/i2c-mxs.c
index 04eb441..a505bce 100644
--- a/drivers/i2c/busses/i2c-mxs.c
+++ b/drivers/i2c/busses/i2c-mxs.c
@@ -110,7 +110,7 @@  struct mxs_i2c_dev {
 	struct device *dev;
 	void __iomem *regs;
 	struct completion cmd_complete;
-	u32 cmd_err;
+	int cmd_err;
 	struct i2c_adapter adapter;