Patchwork [14/18] qapi: Fix unchecked strdup() by converting to g_strdup()

login
register
mail settings
Submitter Stefan Hajnoczi
Date Jan. 30, 2013, 10:24 a.m.
Message ID <1359541470-30775-19-git-send-email-stefanha@redhat.com>
Download mbox | patch
Permalink /patch/216838/
State New
Headers show

Comments

Stefan Hajnoczi - Jan. 30, 2013, 10:24 a.m.
From: Markus Armbruster <armbru@redhat.com>

Note that we already free with g_free().

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 qapi/qmp-registry.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/qapi/qmp-registry.c b/qapi/qmp-registry.c
index 70cdbca..28bbbe8 100644
--- a/qapi/qmp-registry.c
+++ b/qapi/qmp-registry.c
@@ -92,7 +92,7 @@  char **qmp_get_command_list(void)
     list_head = list = g_malloc0(count * sizeof(char *));
 
     QTAILQ_FOREACH(cmd, &qmp_commands, node) {
-        *list = strdup(cmd->name);
+        *list = g_strdup(cmd->name);
         list++;
     }