Patchwork [15/18] qemu-ga: Fix unchecked strdup() by converting to g_strdup()

login
register
mail settings
Submitter Stefan Hajnoczi
Date Jan. 30, 2013, 10:24 a.m.
Message ID <1359541470-30775-20-git-send-email-stefanha@redhat.com>
Download mbox | patch
Permalink /patch/216831/
State New
Headers show

Comments

Stefan Hajnoczi - Jan. 30, 2013, 10:24 a.m.
From: Markus Armbruster <armbru@redhat.com>

I figure it's freed somewhere deep down in QAPI, with g_free().

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 qga/commands.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/qga/commands.c b/qga/commands.c
index 7ffb35e..528b082 100644
--- a/qga/commands.c
+++ b/qga/commands.c
@@ -61,7 +61,7 @@  struct GuestAgentInfo *qmp_guest_info(Error **err)
 
     while (*cmd_list) {
         cmd_info = g_malloc0(sizeof(GuestAgentCommandInfo));
-        cmd_info->name = strdup(*cmd_list);
+        cmd_info->name = g_strdup(*cmd_list);
         cmd_info->enabled = qmp_command_is_enabled(cmd_info->name);
 
         cmd_info_list = g_malloc0(sizeof(GuestAgentCommandInfoList));