From patchwork Wed Jan 30 01:51:55 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?TWFoZXNoIEJhbmRld2FyICjgpK7gpLngpYfgpLYg4KSs4KSC4KSh4KWH4KS14KS+4KSwKQ==?= X-Patchwork-Id: 216755 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 5C6D62C0086 for ; Wed, 30 Jan 2013 13:58:43 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751790Ab3A3C6k (ORCPT ); Tue, 29 Jan 2013 21:58:40 -0500 Received: from mail-ve0-f202.google.com ([209.85.128.202]:34639 "EHLO mail-ve0-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751560Ab3A3C6i (ORCPT ); Tue, 29 Jan 2013 21:58:38 -0500 X-Greylist: delayed 3500 seconds by postgrey-1.27 at vger.kernel.org; Tue, 29 Jan 2013 21:58:38 EST Received: by mail-ve0-f202.google.com with SMTP id m1so26108ves.3 for ; Tue, 29 Jan 2013 18:58:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer; bh=/F0WIdKWl4G6FdBweq4ZjM62e0pR8XCFlFHmDjFnJHA=; b=dsd99G111zuq13cRMq3zHt+GPXrdu1VSDaRE4K89d69tTqRv1/l88FWDSZKtpYmJHE 8I1NUxa5tOeRE8XRFmLjCEoPQ+H0z7DBaWXYHCpqzINYXKrZ5xiqkAVJetRaVlS9lSOt SHgBTIG7+rVdILD9H8oFqF0I7E/JTuPazBK+LUtzfmMToJafq2P4ggjNtptVoiu+Z+MP s4/pt8rwwPcympYLD0KNYNqrnHzk81wZdTt0/l+gqjQxH1jLDpR5RN2wKF1n9SWhXuha l/2vfIdTKFclgk+Y1gxg7msbL7y1ksBH82SLVA0YMeCoWC2MBCtGh4R2nn7bkgTyAEfI Wmtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state; bh=/F0WIdKWl4G6FdBweq4ZjM62e0pR8XCFlFHmDjFnJHA=; b=nstYFtXN26fPbEtNa54MQlqMVOo1yQTP3+V14jbW8vVJJs6lZ4BxDqXIMOgTu8/Bwu v9usL3uz6bjfE9wQzzBgBjPw8P9JMXM0F5Bb8rQI3WHa3Uo936rDvkYqkD3Y2d8WqnDo UODJg0kiZLGc4N+WhtniS1pTUejkxBa43+pXGzedPJ1jux+E8vl/fqKpT7s/3Fg9pwLw wsIzPhgMXSGwP04B+iLpy1K2sQfTTYKsdJuIZ/E8yy/DCDDUmXWIUolTM89yaWl8k3vj 0UhZoaIkgEHCZNR9X8WrAZom+EggLni0Y4NWIJ/3EBUmx7H8l2dHjS7imL69xDHWdVlF XFdQ== X-Received: by 10.236.161.195 with SMTP id w43mr1384735yhk.16.1359510720353; Tue, 29 Jan 2013 17:52:00 -0800 (PST) Received: from corp2gmr1-2.hot.corp.google.com (corp2gmr1-2.hot.corp.google.com [172.24.189.93]) by gmr-mx.google.com with ESMTPS id f64si158971yhj.7.2013.01.29.17.52.00 (version=TLSv1.1 cipher=AES128-SHA bits=128/128); Tue, 29 Jan 2013 17:52:00 -0800 (PST) Received: from coldfire.mtv.corp.google.com (coldfire.mtv.corp.google.com [172.17.131.114]) by corp2gmr1-2.hot.corp.google.com (Postfix) with ESMTP id 372BE5A410E; Tue, 29 Jan 2013 17:52:00 -0800 (PST) Received: by coldfire.mtv.corp.google.com (Postfix, from userid 109155) id C9411140797; Tue, 29 Jan 2013 17:51:59 -0800 (PST) From: Mahesh Bandewar To: Eilon Greenstein , David Miller Cc: netdev , Mahesh Bandewar Subject: [PATCH] net-bnx2x: Force link UP when the interface is in LOOPBACK mode Date: Tue, 29 Jan 2013 17:51:55 -0800 Message-Id: <1359510715-12099-1-git-send-email-maheshb@google.com> X-Mailer: git-send-email 1.8.1 X-Gm-Message-State: ALoCoQm0FLeXbWjm4fQcp5gG6anF5iDd2QcbHhhXcpoFBegCmQ/cT/puNXzXUScAFjI70tVz5vMeZnLNgfGIB3kYDRviVzZUoP3/5uHIZ0vKkP0YYQqrBNwN/8ABLWhpOAZBVZf8Z5QEwm/9Q17Lkdo+7pIyqDYLfvn/T9aGFZi85vIm1WpdkcGuNo4O+l/ha6T7FDPcsIGJ Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When the interface does not have carrier but when it's put into loopback mode (for tests), it does not make sense to not have the carrier. So force it! Signed-off-by: Mahesh Bandewar --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c index 859df751345e..91af55586bbc 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c @@ -4748,6 +4748,11 @@ void bnx2x_link_status_update(struct link_params *params, vars->link_status = REG_RD(bp, params->shmem_base + offsetof(struct shmem_region, port_mb[port].link_status)); + + /* Force link UP in loopback mode */ + if (bp->link_params.loopback_mode != LOOPBACK_NONE) + vars->link_status |= LINK_STATUS_LINK_UP; + if (bnx2x_eee_has_cap(params)) vars->eee_status = REG_RD(bp, params->shmem2_base + offsetof(struct shmem2_region,