Patchwork ext4: only define label failed_mount8 when used

login
register
mail settings
Submitter Stephen Warren
Date Jan. 30, 2013, 12:09 a.m.
Message ID <1359504540-23474-1-git-send-email-swarren@wwwdotorg.org>
Download mbox | patch
Permalink /patch/216735/
State Rejected
Headers show

Comments

Stephen Warren - Jan. 30, 2013, 12:09 a.m.
From: Stephen Warren <swarren@nvidia.com>

This fixes:

fs/ext4/super.c: In function 'ext4_fill_super':
fs/ext4/super.c:4040:1: warning: label 'failed_mount8' defined but not used

This label is only jumped to by code under ifdef CONFIG_QUOTA, so only
define the label in that case too.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
 fs/ext4/super.c |    2 ++
 1 file changed, 2 insertions(+)
Theodore Ts'o - Jan. 30, 2013, 3:52 a.m.
On Tue, Jan 29, 2013 at 05:09:00PM -0700, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
> 
> This fixes:
> 
> fs/ext4/super.c: In function 'ext4_fill_super':
> fs/ext4/super.c:4040:1: warning: label 'failed_mount8' defined but not used
> 
> This label is only jumped to by code under ifdef CONFIG_QUOTA, so only
> define the label in that case too.
> 
> Signed-off-by: Stephen Warren <swarren@nvidia.com>

This is already fixed in the ext4 dev tree.  I assume you noticed this
in linux-next?  It should be fixed up in tomorrow's cut.

   		   	     	      	 - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 861ffa0..3b04d15 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -4037,8 +4037,10 @@  cantfind_ext4:
 		ext4_msg(sb, KERN_ERR, "VFS: Can't find ext4 filesystem");
 	goto failed_mount;
 
+#ifdef CONFIG_QUOTA
 failed_mount8:
 	kobject_del(&sbi->s_kobj);
+#endif
 failed_mount7:
 	ext4_unregister_li_request(sb);
 failed_mount6: