Patchwork [02/10] dialog: add license information

login
register
mail settings
Submitter Gustavo Zacarias
Date Jan. 29, 2013, 6:23 p.m.
Message ID <1359483839-25357-2-git-send-email-gustavo@zacarias.com.ar>
Download mbox | patch
Permalink /patch/216613/
State Accepted
Headers show

Comments

Gustavo Zacarias - Jan. 29, 2013, 6:23 p.m.
Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 package/dialog/dialog.mk | 2 ++
 1 file changed, 2 insertions(+)
Peter Korsgaard - Jan. 29, 2013, 10:20 p.m.
>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:

 Gustavo> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
 Gustavo> ---
 Gustavo>  package/dialog/dialog.mk | 2 ++
 Gustavo>  1 file changed, 2 insertions(+)

 Gustavo> diff --git a/package/dialog/dialog.mk b/package/dialog/dialog.mk
 Gustavo> index 8d87b77..bac788b 100644
 Gustavo> --- a/package/dialog/dialog.mk
 Gustavo> +++ b/package/dialog/dialog.mk
 Gustavo> @@ -10,6 +10,8 @@ DIALOG_SITE = ftp://invisible-island.net/dialog
 Gustavo>  DIALOG_CONF_OPT = --with-ncurses
 Gustavo>  DIALOG_CONF_ENV = ac_cv_path_NCURSES_CONFIG=true LIBS=-lncurses
 Gustavo>  DIALOG_DEPENDENCIES = ncurses
 Gustavo> +DIALOG_LICENSE = LGPLv2.1+

grep -rls 'later version' *
CHANGES
config.guess
config.sub
COPYING
progressbox.c
samples/copifuncs/copi.funcs
samples/copifuncs/admin.funcs
samples/copifuncs/common.funcs
samples/copismall

None of the source files mention anything else than LGPLv2.1, so I will
drop the +

Committed with that change, thanks.
Gustavo Zacarias - Jan. 29, 2013, 10:39 p.m.
On 01/29/2013 07:20 PM, Peter Korsgaard wrote:

> None of the source files mention anything else than LGPLv2.1, so I will
> drop the +
> 
> Committed with that change, thanks.

Actually progressbox.c...
Regards.
Peter Korsgaard - Feb. 4, 2013, 11:05 p.m.
>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:

 Gustavo> On 01/29/2013 07:20 PM, Peter Korsgaard wrote:
 >> None of the source files mention anything else than LGPLv2.1, so I will
 >> drop the +
 >> 
 >> Committed with that change, thanks.

 Gustavo> Actually progressbox.c...

Ahh, you're right. So we have 33 .c files (including the main one) not
listing 'or later', and a single one which does.

What does that mean?
Gustavo Zacarias - Feb. 4, 2013, 11:30 p.m.
On 02/04/2013 08:05 PM, Peter Korsgaard wrote:

> Ahh, you're right. So we have 33 .c files (including the main one) not
> listing 'or later', and a single one which does.
> 
> What does that mean?

Unfortunately it seems to be quite a debate, see:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=632198
Problem is that one file says "or later" and the rest doesn't.
I'm not a lawyer and with the authors comment clarifying that most of
the worst isn't "or later" it's safe to say it's not since one file
can't virally affect all the others.
It's a very thin line to walk on though.
Regards.

Patch

diff --git a/package/dialog/dialog.mk b/package/dialog/dialog.mk
index 8d87b77..bac788b 100644
--- a/package/dialog/dialog.mk
+++ b/package/dialog/dialog.mk
@@ -10,6 +10,8 @@  DIALOG_SITE = ftp://invisible-island.net/dialog
 DIALOG_CONF_OPT = --with-ncurses
 DIALOG_CONF_ENV = ac_cv_path_NCURSES_CONFIG=true LIBS=-lncurses
 DIALOG_DEPENDENCIES = ncurses
+DIALOG_LICENSE = LGPLv2.1+
+DIALOG_LICENSE_FILES = COPYING
 
 ifneq ($(BR2_ENABLE_LOCALE),y)
 DIALOG_DEPENDENCIES+=libiconv