| Message ID | 8f03011d18d9d8cb51a4c2339f2ae4be7cfe1052.1359478671.git.mprivozn@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 01/29/2013 09:58 AM, Michal Privoznik wrote: > Currently, we are using 'tray_open' in QMP and 'tray-open' in > HMP. However, the QMP documentation was mistakenly using the > HMP version. > > Signed-off-by: Michal Privoznik <mprivozn@redhat.com> > --- > > diff to v1: > -add S-o-b line > > qmp-commands.hx | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake <eblake@redhat.com> > > diff --git a/qmp-commands.hx b/qmp-commands.hx > index f58a841..f90efe5 100644 > --- a/qmp-commands.hx > +++ b/qmp-commands.hx > @@ -1659,7 +1659,7 @@ Each json-object contain the following: > - Possible values: "unknown" > - "removable": true if the device is removable, false otherwise (json-bool) > - "locked": true if the device is locked, false otherwise (json-bool) > -- "tray-open": only present if removable, true if the device has a tray, > +- "tray_open": only present if removable, true if the device has a tray, > and it is open (json-bool) > - "inserted": only present if the device is inserted, it is a json-object > containing the following: >
On Tue, Jan 29, 2013 at 05:58:41PM +0100, Michal Privoznik wrote: > Currently, we are using 'tray_open' in QMP and 'tray-open' in > HMP. However, the QMP documentation was mistakenly using the > HMP version. > > Signed-off-by: Michal Privoznik <mprivozn@redhat.com> > --- Thanks, applied to the trivial patches tree: https://github.com/stefanha/qemu/commits/trivial-patches Stefan
On Tue, 29 Jan 2013 17:58:41 +0100 Michal Privoznik <mprivozn@redhat.com> wrote: > Currently, we are using 'tray_open' in QMP and 'tray-open' in > HMP. However, the QMP documentation was mistakenly using the > HMP version. > > Signed-off-by: Michal Privoznik <mprivozn@redhat.com> Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com> > --- > > diff to v1: > -add S-o-b line > > qmp-commands.hx | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qmp-commands.hx b/qmp-commands.hx > index f58a841..f90efe5 100644 > --- a/qmp-commands.hx > +++ b/qmp-commands.hx > @@ -1659,7 +1659,7 @@ Each json-object contain the following: > - Possible values: "unknown" > - "removable": true if the device is removable, false otherwise (json-bool) > - "locked": true if the device is locked, false otherwise (json-bool) > -- "tray-open": only present if removable, true if the device has a tray, > +- "tray_open": only present if removable, true if the device has a tray, > and it is open (json-bool) > - "inserted": only present if the device is inserted, it is a json-object > containing the following:
diff to v1: -add S-o-b line qmp-commands.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qmp-commands.hx b/qmp-commands.hx index f58a841..f90efe5 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -1659,7 +1659,7 @@ Each json-object contain the following: - Possible values: "unknown" - "removable": true if the device is removable, false otherwise (json-bool) - "locked": true if the device is locked, false otherwise (json-bool) -- "tray-open": only present if removable, true if the device has a tray, +- "tray_open": only present if removable, true if the device has a tray, and it is open (json-bool) - "inserted": only present if the device is inserted, it is a json-object containing the following:
Currently, we are using 'tray_open' in QMP and 'tray-open' in HMP. However, the QMP documentation was mistakenly using the HMP version. Signed-off-by: Michal Privoznik <mprivozn@redhat.com> ---