From patchwork Tue Jan 29 15:24:04 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [1/5] net: mvmdio: unmap base register address at driver removal Date: Tue, 29 Jan 2013 05:24:04 -0000 From: Florian Fainelli X-Patchwork-Id: 216589 Message-Id: <1359473048-26551-2-git-send-email-florian@openwrt.org> To: davem@davemloft.net Cc: Thomas Petazzoni , Andrew Lunn , Russell King , Jason Cooper , linux-doc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, Rob Herring , netdev@vger.kernel.org, Paul Mackerras , linux-arm-kernel@lists.infradead.org, Rob Landley , Greg Kroah-Hartman , linuxppc-dev@lists.ozlabs.org, Florian Fainelli , Lennert Buytenhek Fix the driver remove callback to unmap the base register address and not leak this mapping after the driver has been removed. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/marvell/mvmdio.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/marvell/mvmdio.c b/drivers/net/ethernet/marvell/mvmdio.c index 74f1c15..be5c690 100644 --- a/drivers/net/ethernet/marvell/mvmdio.c +++ b/drivers/net/ethernet/marvell/mvmdio.c @@ -200,9 +200,12 @@ static int orion_mdio_probe(struct platform_device *pdev) static int orion_mdio_remove(struct platform_device *pdev) { struct mii_bus *bus = platform_get_drvdata(pdev); + struct orion_mdio_dev *dev = bus->priv; + mdiobus_unregister(bus); kfree(bus->irq); mdiobus_free(bus); + iounmap(dev->smireg); return 0; }