From patchwork Tue Jan 29 13:52:58 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alexander Graf X-Patchwork-Id: 216535 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 190D72C0095 for ; Wed, 30 Jan 2013 00:53:19 +1100 (EST) Received: from localhost ([::1]:48782 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U0Bcj-0005Yr-7x for incoming@patchwork.ozlabs.org; Tue, 29 Jan 2013 08:53:17 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48591) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U0Bcc-0005XV-3T for qemu-devel@nongnu.org; Tue, 29 Jan 2013 08:53:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U0Bca-0004ud-AF for qemu-devel@nongnu.org; Tue, 29 Jan 2013 08:53:09 -0500 Received: from cantor2.suse.de ([195.135.220.15]:57374 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U0Bca-0004uJ-49; Tue, 29 Jan 2013 08:53:08 -0500 Received: from relay1.suse.de (unknown [195.135.220.254]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id F053AA535C; Tue, 29 Jan 2013 14:53:06 +0100 (CET) From: Alexander Graf To: qemu-ppc@nongnu.org Date: Tue, 29 Jan 2013 14:52:58 +0100 Message-Id: <1359467578-32246-1-git-send-email-agraf@suse.de> X-Mailer: git-send-email 1.6.0.2 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-Received-From: 195.135.220.15 Cc: =?utf-8?q?Amadeusz=20S=C5=82awi=C5=84ski?= , qemu-devel Subject: [Qemu-devel] [PATCH] PPC: Allow book3s ppc32 to run dcbzl X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The bit that makes a dcbz instruction a dcbzl instruction was declared as reserved in ppc32 ISAs. However, hardware simply ignores the bit, making code valid if it simply invokes dcbzl instead of dcbz even on 750 and G4. Thus, mark the bit as unreserved so that we properly emulate a simple dcbz in case we're running on non-G5s. Reported-by: Amadeusz Sławiński Signed-off-by: Alexander Graf --- target-ppc/translate.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index 798b7ac..9b98493 100644 --- a/target-ppc/translate.c +++ b/target-ppc/translate.c @@ -8648,7 +8648,7 @@ GEN_HANDLER(dcbi, 0x1F, 0x16, 0x0E, 0x03E00001, PPC_CACHE), GEN_HANDLER(dcbst, 0x1F, 0x16, 0x01, 0x03E00001, PPC_CACHE), GEN_HANDLER(dcbt, 0x1F, 0x16, 0x08, 0x02000001, PPC_CACHE), GEN_HANDLER(dcbtst, 0x1F, 0x16, 0x07, 0x02000001, PPC_CACHE), -GEN_HANDLER(dcbz, 0x1F, 0x16, 0x1F, 0x03E00001, PPC_CACHE_DCBZ), +GEN_HANDLER(dcbz, 0x1F, 0x16, 0x1F, 0x03C00001, PPC_CACHE_DCBZ), GEN_HANDLER2(dcbz_970, "dcbz", 0x1F, 0x16, 0x1F, 0x03C00001, PPC_CACHE_DCBZT), GEN_HANDLER(dst, 0x1F, 0x16, 0x0A, 0x01800001, PPC_ALTIVEC), GEN_HANDLER(dstst, 0x1F, 0x16, 0x0B, 0x02000001, PPC_ALTIVEC),