Patchwork [U-Boot,v3,1/3] mxs: Rename CONFIG_SPL_MX28_PSWITCH_WAIT to CONFIG_SPL_MXS_PSWITCH_WAIT

login
register
mail settings
Submitter Otavio Salvador
Date Jan. 29, 2013, 10:37 a.m.
Message ID <1359455824-24058-1-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/216490/
State Not Applicable
Headers show

Comments

Otavio Salvador - Jan. 29, 2013, 10:37 a.m.
The power switch option is compatible with i.MX23 and i.MX28 so the
configration option needs to reflect it. We choose
'CONFIG_SPL_MXS_PSWITCH_WAIT' for the option name.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
Changes in v3: None
Changes in v2:
- Rewrite short description as per Marek's request

 arch/arm/cpu/arm926ejs/mxs/mxs_init.h       | 2 +-
 arch/arm/cpu/arm926ejs/mxs/spl_power_init.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Marek Vasut - Jan. 29, 2013, 12:37 p.m.
Dear Otavio Salvador,

> The power switch option is compatible with i.MX23 and i.MX28 so the
> configration option needs to reflect it. We choose
> 'CONFIG_SPL_MXS_PSWITCH_WAIT' for the option name.
> 
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>

Acked-by: Marek Vasut <marex@denx.de>

Please read [1] too, I'm completely lost in the flurry of patches. I just can't 
figure out anymore what's going on. I don't know what patches to review, in what 
order and what patches are obsolete and what are not.

Moreover, it's generally better to use "Cc:" in the patches. Also, if you want 
my threading to work well so I want be lost, Cc me on the whole series.

http://www.denx.de/wiki/U-Boot/Patches#General_Patch_Submission_Rules

> ---
> Changes in v3: None
> Changes in v2:
> - Rewrite short description as per Marek's request
> 
>  arch/arm/cpu/arm926ejs/mxs/mxs_init.h       | 2 +-
>  arch/arm/cpu/arm926ejs/mxs/spl_power_init.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/cpu/arm926ejs/mxs/mxs_init.h
> b/arch/arm/cpu/arm926ejs/mxs/mxs_init.h index 2ddc5bc..084def5 100644
> --- a/arch/arm/cpu/arm926ejs/mxs/mxs_init.h
> +++ b/arch/arm/cpu/arm926ejs/mxs/mxs_init.h
> @@ -30,7 +30,7 @@ void early_delay(int delay);
> 
>  void mxs_power_init(void);
> 
> -#ifdef	CONFIG_SPL_MX28_PSWITCH_WAIT
> +#ifdef	CONFIG_SPL_MXS_PSWITCH_WAIT
>  void mxs_power_wait_pswitch(void);
>  #else
>  static inline void mxs_power_wait_pswitch(void) { }
> diff --git a/arch/arm/cpu/arm926ejs/mxs/spl_power_init.c
> b/arch/arm/cpu/arm926ejs/mxs/spl_power_init.c index e9d6302..287c698
> 100644
> --- a/arch/arm/cpu/arm926ejs/mxs/spl_power_init.c
> +++ b/arch/arm/cpu/arm926ejs/mxs/spl_power_init.c
> @@ -921,7 +921,7 @@ void mxs_power_init(void)
>  	early_delay(1000);
>  }
> 
> -#ifdef	CONFIG_SPL_MX28_PSWITCH_WAIT
> +#ifdef	CONFIG_SPL_MXS_PSWITCH_WAIT
>  void mxs_power_wait_pswitch(void)
>  {
>  	struct mxs_power_regs *power_regs =

Best regards,
Marek Vasut

Patch

diff --git a/arch/arm/cpu/arm926ejs/mxs/mxs_init.h b/arch/arm/cpu/arm926ejs/mxs/mxs_init.h
index 2ddc5bc..084def5 100644
--- a/arch/arm/cpu/arm926ejs/mxs/mxs_init.h
+++ b/arch/arm/cpu/arm926ejs/mxs/mxs_init.h
@@ -30,7 +30,7 @@  void early_delay(int delay);
 
 void mxs_power_init(void);
 
-#ifdef	CONFIG_SPL_MX28_PSWITCH_WAIT
+#ifdef	CONFIG_SPL_MXS_PSWITCH_WAIT
 void mxs_power_wait_pswitch(void);
 #else
 static inline void mxs_power_wait_pswitch(void) { }
diff --git a/arch/arm/cpu/arm926ejs/mxs/spl_power_init.c b/arch/arm/cpu/arm926ejs/mxs/spl_power_init.c
index e9d6302..287c698 100644
--- a/arch/arm/cpu/arm926ejs/mxs/spl_power_init.c
+++ b/arch/arm/cpu/arm926ejs/mxs/spl_power_init.c
@@ -921,7 +921,7 @@  void mxs_power_init(void)
 	early_delay(1000);
 }
 
-#ifdef	CONFIG_SPL_MX28_PSWITCH_WAIT
+#ifdef	CONFIG_SPL_MXS_PSWITCH_WAIT
 void mxs_power_wait_pswitch(void)
 {
 	struct mxs_power_regs *power_regs =