Patchwork question about section 10.12

login
register
mail settings
Submitter Hans-Peter Nilsson
Date Jan. 28, 2013, 10:14 p.m.
Message ID <201301282214.r0SMELBx013976@ignucius.se.axis.com>
Download mbox | patch
Permalink /patch/216385/
State New
Headers show

Comments

Hans-Peter Nilsson - Jan. 28, 2013, 10:14 p.m.
> From: Kenneth Zadeck <zadeck@naturalbridge.com>
> Date: Mon, 28 Jan 2013 02:02:41 +0100

> this looks good to me.  does your patch also address the vec_concat 
> issue that marc raised?

You mean the issue being "same thing there"?  I can confirm that
(I've stumbled upon) the same issue being there (i.e. similarly
applies to scalars).  But nope, there's no cross-reference, so
the effective wording needs to be added there too.  I also
noticed the parameter/s misleadingly being keyed to "vec" and
fill-paragraphed the paragraph.  Something like this seems
obvious:

(Oops, noticed gcc@ was in CC, changing to gcc-patches@.)

	* doc/rtl.texi (vec_concat, vec_duplicate): Mention that
	scalars are valid operands.

brgds, H-P

Patch

Index: doc/rtl.texi
===================================================================
--- doc/rtl.texi	(revision 195514)
+++ doc/rtl.texi	(working copy)
@@ -2627,17 +2627,18 @@  The result mode @var{m} is either the su
 with that element submode (if multiple subparts are selected).
 
 @findex vec_concat
-@item (vec_concat:@var{m} @var{vec1} @var{vec2})
+@item (vec_concat:@var{m} @var{x1} @var{x2})
 Describes a vector concat operation.  The result is a concatenation of the
-vectors @var{vec1} and @var{vec2}; its length is the sum of the lengths of
-the two inputs.
+vectors or scalars @var{x1} and @var{x2}; its length is the sum of the
+lengths of the two inputs.
 
 @findex vec_duplicate
-@item (vec_duplicate:@var{m} @var{vec})
-This operation converts a small vector into a larger one by duplicating the
-input values.  The output vector mode must have the same submodes as the
-input vector mode, and the number of output parts must be an integer multiple
-of the number of input parts.
+@item (vec_duplicate:@var{m} @var{x})
+This operation converts a scalar into a vector or a small vector into a
+larger one by duplicating the input values.  The output vector mode must have
+the same submodes as the input vector mode or the scalar modes, and the
+number of output parts must be an integer multiple of the number of input
+parts.
 
 @end table