From patchwork Mon Jan 28 17:07:23 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Beno=C3=AEt_Canet?= X-Patchwork-Id: 216277 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 688032C0090 for ; Tue, 29 Jan 2013 04:43:02 +1100 (EST) Received: from localhost ([::1]:44585 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TzsBl-0008AR-GG for incoming@patchwork.ozlabs.org; Mon, 28 Jan 2013 12:08:09 -0500 Received: from eggs.gnu.org ([208.118.235.92]:45854) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TzsBV-00088E-Ib for qemu-devel@nongnu.org; Mon, 28 Jan 2013 12:08:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TzsBS-0000L1-D6 for qemu-devel@nongnu.org; Mon, 28 Jan 2013 12:07:53 -0500 Received: from nodalink.pck.nerim.net ([62.212.105.220]:48534 helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TzsBR-0000Kl-VQ for qemu-devel@nongnu.org; Mon, 28 Jan 2013 12:07:50 -0500 Received: by paradis.irqsave.net (Postfix, from userid 1002) id 69A7B874320; Mon, 28 Jan 2013 18:07:49 +0100 (CET) Received: from localhost.localdomain (unknown [192.168.77.1]) by paradis.irqsave.net (Postfix) with ESMTP id A222C874329; Mon, 28 Jan 2013 18:06:43 +0100 (CET) From: =?UTF-8?q?Beno=C3=AEt=20Canet?= To: qemu-devel@nongnu.org Date: Mon, 28 Jan 2013 18:07:23 +0100 Message-Id: <1359392845-15905-12-git-send-email-benoit@irqsave.net> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1359392845-15905-1-git-send-email-benoit@irqsave.net> References: <1359392845-15905-1-git-send-email-benoit@irqsave.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 62.212.105.220 Cc: kwolf@redhat.com, =?UTF-8?q?Beno=C3=AEt=20Canet?= , stefanha@redhat.com Subject: [Qemu-devel] [RFC V8 11/13] quorum: Add quorum_snapshot_img_create. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Benoit Canet --- block/quorum.c | 188 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 188 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 306a2df..cc02c5f 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -609,6 +609,192 @@ static coroutine_fn int quorum_co_flush(BlockDriverState *bs) return result; } +static int quorum_parse_uint_step_next(const char *start, + const char *name, + const char separator, + unsigned long long *value, + char **next, + Error **errp) +{ + int ret; + if (start[0] == '\0') { + error_set(errp, QERR_MISSING_PARAMETER, name); + return -EINVAL; + } + ret = parse_uint(start, value, next, 10); + if (ret < 0) { + error_set(errp, QERR_INVALID_PARAMETER_TYPE, name, "int"); + return ret; + } + if (**next != separator) { + error_set(errp, ERROR_CLASS_GENERIC_ERROR, + "%c separator required after %s", + separator, name); + return -EINVAL; + } + *next += 1; + return 0; +} + +static int quorum_parse_url(BDRVQuorumState *s, const char *url, Error **errp) +{ + int i, j, k, len, ret = 0; + char *a, *b, *names; + const char *start; + bool escape; + + /* Parse the quorum: prefix */ + if (!strstart(url, "quorum:", &start)) { + error_set(errp, ERROR_CLASS_GENERIC_ERROR, + "Invalid quorum url"); + return -EINVAL; + } + + /* Get threshold */ + ret = quorum_parse_uint_step_next(start, "threshold", '/', + &s->threshold, &a, errp); + if (ret < 0) { + return ret; + } + + /* Get total */ + ret = quorum_parse_uint_step_next(a, "total", ':', + &s->total, &b, errp); + if (ret < 0) { + return ret; + } + + if (s->threshold < 1) { + error_set(errp, QERR_INVALID_PARAMETER_VALUE, + "threshold", "value >= 1"); + return -ERANGE; + } + + if (s->total < 2) { + error_set(errp, QERR_INVALID_PARAMETER_VALUE, "total", "value >= 2"); + return -ERANGE; + } + + if (s->threshold > s->total) { + error_set(errp, ERROR_CLASS_GENERIC_ERROR, + "threshold <= total must be true"); + return -ERANGE; + } + + s->bs = g_malloc0(sizeof(BlockDriverState *) * s->total); + /* Two allocations for all filenames: simpler to free */ + s->filenames = g_malloc0(sizeof(char *) * s->total); + names = g_strdup(b); + + /* Get the filenames pointers */ + escape = false; + s->filenames[0] = names; + len = strlen(names); + for (i = j = k = 0; i < len && j < s->total; i++) { + /* separation between two files */ + if (!escape && names[i] == ':') { + char *prev = s->filenames[j]; + prev[k] = '\0'; + s->filenames[++j] = prev + k + 1; + k = 0; + continue; + } + + escape = !escape && names[i] == '\\'; + + /* if we are not escaping copy */ + if (!escape) { + s->filenames[j][k++] = names[i]; + } + } + /* terminate last string */ + s->filenames[j][k] = '\0'; + + return j + 1; +} + +static int quorum_validate_url(BDRVQuorumState *s, int ret, Error **errp) +{ + if (ret == s->total) { + return 0; + } + + error_set(errp, ERROR_CLASS_GENERIC_ERROR, + "Number of provided file must be equal to total"); + return -EINVAL; +} + +static void quorum_free(BDRVQuorumState *s) +{ + g_free(s->filenames[0]); + g_free(s->filenames); + s->filenames = NULL; + g_free(s->bs); +} + +static bool quorum_are_states_compatibles(BDRVQuorumState *a, + BDRVQuorumState *b, + Error **errp) +{ + if (a->threshold != b->threshold) { + error_set(errp, ERROR_CLASS_GENERIC_ERROR, + "Theshold must be the same as previously"); + return false; + } + + if (a->total != b->total) { + error_set(errp, ERROR_CLASS_GENERIC_ERROR, + "Total must be the same as previously"); + return false; + } + + return true; + +} + +static void quorum_snapshot_img_create(BlockDriverState *bs, + const char *filename, const char *fmt, + const char *base_filename, + const char *base_fmt, + char *options, uint64_t img_size, + int flags, Error **errp) +{ + BDRVQuorumState *s = bs->file->opaque; + int i; + int ret = 0; + bool compatible; + BDRVQuorumState new_s; + + memset(&new_s, 0, sizeof(BDRVQuorumState)); + + ret = quorum_parse_url(&new_s, filename, errp); + if (ret < 0) { + return; + } + + ret = quorum_validate_url(&new_s, ret, errp); + if (ret < 0) { + goto free_new_s_exit; + } + + compatible = quorum_are_states_compatibles(s, &new_s, errp); + if (!compatible) { + goto free_new_s_exit; + } + + for (i = 0; i < new_s.total; i++) { + bdrv_img_create(new_s.filenames[i], fmt, + s->filenames[i], s->bs[i]->drv->format_name, + options, img_size, flags, errp); + if (error_is_set(errp)) { + break; + } + } + +free_new_s_exit: + quorum_free(&new_s); +} + static BlockDriver bdrv_quorum = { .format_name = "quorum", .protocol_name = "quorum", @@ -623,6 +809,8 @@ static BlockDriver bdrv_quorum = { .bdrv_aio_writev = quorum_aio_writev, .bdrv_invalidate_cache = quorum_invalidate_cache, .bdrv_co_is_allocated = quorum_co_is_allocated, + + .bdrv_ext_snapshot_img_create = quorum_snapshot_img_create, }; static void bdrv_quorum_init(void)