Patchwork [1/1] NET: qmi_wwan: add Telit LE920 support

login
register
mail settings
Submitter Daniele Palmas
Date Jan. 28, 2013, 3:45 p.m.
Message ID <1359387918-2791-1-git-send-email-dnlplm@gmail.com>
Download mbox | patch
Permalink /patch/216234/
State Changes Requested
Delegated to: David Miller
Headers show

Comments

Daniele Palmas - Jan. 28, 2013, 3:45 p.m.
Add VID, PID and fixed interface for Telit LE920

Signed-off-by: Daniele Palmas <dnlplm@gmail.com>
---
 drivers/net/usb/qmi_wwan.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Bjørn Mork - Jan. 28, 2013, 4:59 p.m.
Daniele Palmas <dnlplm@gmail.com> writes:

> Add VID, PID and fixed interface for Telit LE920
>
> Signed-off-by: Daniele Palmas <dnlplm@gmail.com>
> ---
>  drivers/net/usb/qmi_wwan.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index 6a1ca50..e32f9a1 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -459,6 +459,7 @@ static const struct usb_device_id products[] = {
>  	{QMI_FIXED_INTF(0x1199, 0x68a2, 19)},	/* Sierra Wireless MC7710 in QMI mode */
>  	{QMI_FIXED_INTF(0x1199, 0x901c, 8)},    /* Sierra Wireless EM7700 */
>  	{QMI_FIXED_INTF(0x1bbb, 0x011e, 4)},	/* Telekom Speedstick LTE II (Alcatel One Touch L100V LTE) */
> +	{QMI_FIXED_INTF(0x1bc7, 0x1200, 5)},	/* Telit LE920 */
>  
>  	/* 4. Gobi 1000 devices */
>  	{QMI_GOBI1K_DEVICE(0x05c6, 0x9212)},	/* Acer Gobi Modem Device */

Thanks for adding this device. But the patch doesn't apply to the
current "net" tree.  Care to rebase it?


Thanks,
Bjørn
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Daniele Palmas - Jan. 29, 2013, 8:40 a.m.
Hello,

2013/1/28 Bjørn Mork <bjorn@mork.no>:
> Daniele Palmas <dnlplm@gmail.com> writes:
>
>> Add VID, PID and fixed interface for Telit LE920
>>
>> Signed-off-by: Daniele Palmas <dnlplm@gmail.com>
>> ---
>>  drivers/net/usb/qmi_wwan.c |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
>> index 6a1ca50..e32f9a1 100644
>> --- a/drivers/net/usb/qmi_wwan.c
>> +++ b/drivers/net/usb/qmi_wwan.c
>> @@ -459,6 +459,7 @@ static const struct usb_device_id products[] = {
>>       {QMI_FIXED_INTF(0x1199, 0x68a2, 19)},   /* Sierra Wireless MC7710 in QMI mode */
>>       {QMI_FIXED_INTF(0x1199, 0x901c, 8)},    /* Sierra Wireless EM7700 */
>>       {QMI_FIXED_INTF(0x1bbb, 0x011e, 4)},    /* Telekom Speedstick LTE II (Alcatel One Touch L100V LTE) */
>> +     {QMI_FIXED_INTF(0x1bc7, 0x1200, 5)},    /* Telit LE920 */
>>
>>       /* 4. Gobi 1000 devices */
>>       {QMI_GOBI1K_DEVICE(0x05c6, 0x9212)},    /* Acer Gobi Modem Device */
>
> Thanks for adding this device. But the patch doesn't apply to the
> current "net" tree.  Care to rebase it?
>

Sure. Should I use the following git repository

git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/net-next.git

?

Thanks,
Daniele
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Bjørn Mork - Jan. 29, 2013, 9:35 a.m.
Daniele Palmas <dnlplm@gmail.com> writes:
> 2013/1/28 Bjørn Mork <bjorn@mork.no>:
>
>> Thanks for adding this device. But the patch doesn't apply to the
>> current "net" tree.  Care to rebase it?
>>
>
> Sure. Should I use the following git repository
>
> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/net-next.git
>
> ?

No, the correct tree to base device additions for drivers/net/usb is

 git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git

Note that this is different from most other USB devices.

This wouldn't normally be such a big deal, but you were "lucky" and hit
a timeslot when there were unmerged conflicting changes that tree. I am
not trying to be difficult.  It just feels like it :-)

Thanks again for doing this.


Bjørn
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 6a1ca50..e32f9a1 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -459,6 +459,7 @@  static const struct usb_device_id products[] = {
 	{QMI_FIXED_INTF(0x1199, 0x68a2, 19)},	/* Sierra Wireless MC7710 in QMI mode */
 	{QMI_FIXED_INTF(0x1199, 0x901c, 8)},    /* Sierra Wireless EM7700 */
 	{QMI_FIXED_INTF(0x1bbb, 0x011e, 4)},	/* Telekom Speedstick LTE II (Alcatel One Touch L100V LTE) */
+	{QMI_FIXED_INTF(0x1bc7, 0x1200, 5)},	/* Telit LE920 */
 
 	/* 4. Gobi 1000 devices */
 	{QMI_GOBI1K_DEVICE(0x05c6, 0x9212)},	/* Acer Gobi Modem Device */