Patchwork [U-Boot,v4,2/3] mxs: Fix iomux.h to not break build during assembly stage

login
register
mail settings
Submitter Otavio Salvador
Date Jan. 28, 2013, 3:51 p.m.
Message ID <1359388311-25487-2-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/216232/
State Not Applicable
Headers show

Comments

Otavio Salvador - Jan. 28, 2013, 3:51 p.m.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
Changes in v4:
- New patch

Changes in v3: None
Changes in v2: None

 arch/arm/include/asm/arch-mxs/iomux.h | 5 +++++
 1 file changed, 5 insertions(+)
Marek Vasut - Jan. 28, 2013, 3:57 p.m.
Dear Otavio Salvador,

Missing commit message.

> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> Changes in v4:
> - New patch
> 
> Changes in v3: None
> Changes in v2: None
> 
>  arch/arm/include/asm/arch-mxs/iomux.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/include/asm/arch-mxs/iomux.h
> b/arch/arm/include/asm/arch-mxs/iomux.h index 7abdf58..4288715 100644
> --- a/arch/arm/include/asm/arch-mxs/iomux.h
> +++ b/arch/arm/include/asm/arch-mxs/iomux.h
> @@ -21,6 +21,10 @@
>  #ifndef __MACH_MXS_IOMUX_H__
>  #define __MACH_MXS_IOMUX_H__
> 
> +#ifndef __ASSEMBLY__
> +
> +#include <asm/types.h>
> +

Is this needed?

>  /*
>   * IOMUX/PAD Bit field definitions
>   *
> @@ -165,4 +169,5 @@ int mxs_iomux_setup_pad(iomux_cfg_t pad);
>   */
>  int mxs_iomux_setup_multiple_pads(const iomux_cfg_t *pad_list, unsigned
> count);
> 
> +#endif /* __ASSEMBLY__ */
>  #endif /* __MACH_MXS_IOMUX_H__*/

Best regards,
Marek Vasut
Otavio Salvador - Jan. 28, 2013, 4 p.m.
On Mon, Jan 28, 2013 at 1:57 PM, Marek Vasut <marex@denx.de> wrote:
> Dear Otavio Salvador,
>
> Missing commit message.

I think short description is clear enough. What you'd like me to put
in long one?

>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> ---
>> Changes in v4:
>> - New patch
>>
>> Changes in v3: None
>> Changes in v2: None
>>
>>  arch/arm/include/asm/arch-mxs/iomux.h | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm/include/asm/arch-mxs/iomux.h
>> b/arch/arm/include/asm/arch-mxs/iomux.h index 7abdf58..4288715 100644
>> --- a/arch/arm/include/asm/arch-mxs/iomux.h
>> +++ b/arch/arm/include/asm/arch-mxs/iomux.h
>> @@ -21,6 +21,10 @@
>>  #ifndef __MACH_MXS_IOMUX_H__
>>  #define __MACH_MXS_IOMUX_H__
>>
>> +#ifndef __ASSEMBLY__
>> +
>> +#include <asm/types.h>
>> +
>
> Is this needed?

Yes; or I would not have added it right? :)

>>  /*
>>   * IOMUX/PAD Bit field definitions
>>   *
>> @@ -165,4 +169,5 @@ int mxs_iomux_setup_pad(iomux_cfg_t pad);
>>   */
>>  int mxs_iomux_setup_multiple_pads(const iomux_cfg_t *pad_list, unsigned
>> count);
>>
>> +#endif /* __ASSEMBLY__ */
>>  #endif /* __MACH_MXS_IOMUX_H__*/
>
> Best regards,
> Marek Vasut



--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
Marek Vasut - Jan. 28, 2013, 4:16 p.m.
Dear Otavio Salvador,

> On Mon, Jan 28, 2013 at 1:57 PM, Marek Vasut <marex@denx.de> wrote:
> > Dear Otavio Salvador,
> > 
> > Missing commit message.
> 
> I think short description is clear enough. What you'd like me to put
> in long one?

Reasoning why this patch is necessary.

> >> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> >> ---
> >> Changes in v4:
> >> - New patch
> >> 
> >> Changes in v3: None
> >> Changes in v2: None
> >> 
> >>  arch/arm/include/asm/arch-mxs/iomux.h | 5 +++++
> >>  1 file changed, 5 insertions(+)
> >> 
> >> diff --git a/arch/arm/include/asm/arch-mxs/iomux.h
> >> b/arch/arm/include/asm/arch-mxs/iomux.h index 7abdf58..4288715 100644
> >> --- a/arch/arm/include/asm/arch-mxs/iomux.h
> >> +++ b/arch/arm/include/asm/arch-mxs/iomux.h
> >> @@ -21,6 +21,10 @@
> >> 
> >>  #ifndef __MACH_MXS_IOMUX_H__
> >>  #define __MACH_MXS_IOMUX_H__
> >> 
> >> +#ifndef __ASSEMBLY__
> >> +
> >> +#include <asm/types.h>
> >> +
> > 
> > Is this needed?
> 
> Yes; or I would not have added it right? :)

Why is it needed?

> >>  /*
> >>  
> >>   * IOMUX/PAD Bit field definitions
> >>   *
> >> 
> >> @@ -165,4 +169,5 @@ int mxs_iomux_setup_pad(iomux_cfg_t pad);
> >> 
> >>   */
> >>  
> >>  int mxs_iomux_setup_multiple_pads(const iomux_cfg_t *pad_list, unsigned
> >> 
> >> count);
> >> 
> >> +#endif /* __ASSEMBLY__ */
> >> 
> >>  #endif /* __MACH_MXS_IOMUX_H__*/
> > 
> > Best regards,
> > Marek Vasut
> 
> --
> Otavio Salvador                             O.S. Systems
> E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
> Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Best regards,
Marek Vasut
Otavio Salvador - Jan. 28, 2013, 4:30 p.m.
On Mon, Jan 28, 2013 at 2:16 PM, Marek Vasut <marex@denx.de> wrote:
> Dear Otavio Salvador,
>
>> On Mon, Jan 28, 2013 at 1:57 PM, Marek Vasut <marex@denx.de> wrote:
>> > Dear Otavio Salvador,
>> >
>> > Missing commit message.
>>
>> I think short description is clear enough. What you'd like me to put
>> in long one?
>
> Reasoning why this patch is necessary.

Well, it seems quite clear it fix a build failure when it is used in
assembly stage; it is clear enough for me, in the shortlog

>> >> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> >> ---
>> >> Changes in v4:
>> >> - New patch
>> >>
>> >> Changes in v3: None
>> >> Changes in v2: None
>> >>
>> >>  arch/arm/include/asm/arch-mxs/iomux.h | 5 +++++
>> >>  1 file changed, 5 insertions(+)
>> >>
>> >> diff --git a/arch/arm/include/asm/arch-mxs/iomux.h
>> >> b/arch/arm/include/asm/arch-mxs/iomux.h index 7abdf58..4288715 100644
>> >> --- a/arch/arm/include/asm/arch-mxs/iomux.h
>> >> +++ b/arch/arm/include/asm/arch-mxs/iomux.h
>> >> @@ -21,6 +21,10 @@
>> >>
>> >>  #ifndef __MACH_MXS_IOMUX_H__
>> >>  #define __MACH_MXS_IOMUX_H__
>> >>
>> >> +#ifndef __ASSEMBLY__
>> >> +
>> >> +#include <asm/types.h>
>> >> +
>> >
>> > Is this needed?
>>
>> Yes; or I would not have added it right? :)
>
> Why is it needed?
>
>> >>  /*
>> >>
>> >>   * IOMUX/PAD Bit field definitions
>> >>   *
>> >>
>> >> @@ -165,4 +169,5 @@ int mxs_iomux_setup_pad(iomux_cfg_t pad);
>> >>
>> >>   */
>> >>
>> >>  int mxs_iomux_setup_multiple_pads(const iomux_cfg_t *pad_list, unsigned
>> >>
>> >> count);
>> >>
>> >> +#endif /* __ASSEMBLY__ */
>> >>
>> >>  #endif /* __MACH_MXS_IOMUX_H__*/
>> >
>> > Best regards,
>> > Marek Vasut
>>
>> --
>> Otavio Salvador                             O.S. Systems
>> E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
>> Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
>
> Best regards,
> Marek Vasut



--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
Marek Vasut - Jan. 28, 2013, 4:35 p.m.
Dear Otavio Salvador,

> On Mon, Jan 28, 2013 at 2:16 PM, Marek Vasut <marex@denx.de> wrote:
> > Dear Otavio Salvador,
> > 
> >> On Mon, Jan 28, 2013 at 1:57 PM, Marek Vasut <marex@denx.de> wrote:
> >> > Dear Otavio Salvador,
> >> > 
> >> > Missing commit message.
> >> 
> >> I think short description is clear enough. What you'd like me to put
> >> in long one?
> > 
> > Reasoning why this patch is necessary.
> 
> Well, it seems quite clear it fix a build failure when it is used in
> assembly stage; it is clear enough for me, in the shortlog

I don't understand why did you also add the header below. That's not clear.

> >> >> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> >> >> ---
> >> >> Changes in v4:
> >> >> - New patch
> >> >> 
> >> >> Changes in v3: None
> >> >> Changes in v2: None
> >> >> 
> >> >>  arch/arm/include/asm/arch-mxs/iomux.h | 5 +++++
> >> >>  1 file changed, 5 insertions(+)
> >> >> 
> >> >> diff --git a/arch/arm/include/asm/arch-mxs/iomux.h
> >> >> b/arch/arm/include/asm/arch-mxs/iomux.h index 7abdf58..4288715 100644
> >> >> --- a/arch/arm/include/asm/arch-mxs/iomux.h
> >> >> +++ b/arch/arm/include/asm/arch-mxs/iomux.h
> >> >> @@ -21,6 +21,10 @@
> >> >> 
> >> >>  #ifndef __MACH_MXS_IOMUX_H__
> >> >>  #define __MACH_MXS_IOMUX_H__
> >> >> 
> >> >> +#ifndef __ASSEMBLY__
> >> >> +
> >> >> +#include <asm/types.h>
> >> >> +
> >> > 
> >> > Is this needed?
> >> 
> >> Yes; or I would not have added it right? :)
> > 
> > Why is it needed?

Here, I fail to understand what this has to do with fixing the inclusion of this 
in assembly files.

Best regards,
Marek Vasut
Otavio Salvador - Jan. 28, 2013, 5:09 p.m.
On Mon, Jan 28, 2013 at 2:35 PM, Marek Vasut <marex@denx.de> wrote:
> Dear Otavio Salvador,
>
>> On Mon, Jan 28, 2013 at 2:16 PM, Marek Vasut <marex@denx.de> wrote:
>> > Dear Otavio Salvador,
>> >
>> >> On Mon, Jan 28, 2013 at 1:57 PM, Marek Vasut <marex@denx.de> wrote:
>> >> > Dear Otavio Salvador,
>> >> >
>> >> > Missing commit message.
>> >>
>> >> I think short description is clear enough. What you'd like me to put
>> >> in long one?
>> >
>> > Reasoning why this patch is necessary.
>>
>> Well, it seems quite clear it fix a build failure when it is used in
>> assembly stage; it is clear enough for me, in the shortlog
>
> I don't understand why did you also add the header below. That's not clear.
>
>> >> >> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> >> >> ---
>> >> >> Changes in v4:
>> >> >> - New patch
>> >> >>
>> >> >> Changes in v3: None
>> >> >> Changes in v2: None
>> >> >>
>> >> >>  arch/arm/include/asm/arch-mxs/iomux.h | 5 +++++
>> >> >>  1 file changed, 5 insertions(+)
>> >> >>
>> >> >> diff --git a/arch/arm/include/asm/arch-mxs/iomux.h
>> >> >> b/arch/arm/include/asm/arch-mxs/iomux.h index 7abdf58..4288715 100644
>> >> >> --- a/arch/arm/include/asm/arch-mxs/iomux.h
>> >> >> +++ b/arch/arm/include/asm/arch-mxs/iomux.h
>> >> >> @@ -21,6 +21,10 @@
>> >> >>
>> >> >>  #ifndef __MACH_MXS_IOMUX_H__
>> >> >>  #define __MACH_MXS_IOMUX_H__
>> >> >>
>> >> >> +#ifndef __ASSEMBLY__
>> >> >> +
>> >> >> +#include <asm/types.h>
>> >> >> +
>> >> >
>> >> > Is this needed?
>> >>
>> >> Yes; or I would not have added it right? :)
>> >
>> > Why is it needed?
>
> Here, I fail to understand what this has to do with fixing the inclusion of this
> in assembly files.

I sent v5; hope it is fine now.

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Patch

diff --git a/arch/arm/include/asm/arch-mxs/iomux.h b/arch/arm/include/asm/arch-mxs/iomux.h
index 7abdf58..4288715 100644
--- a/arch/arm/include/asm/arch-mxs/iomux.h
+++ b/arch/arm/include/asm/arch-mxs/iomux.h
@@ -21,6 +21,10 @@ 
 #ifndef __MACH_MXS_IOMUX_H__
 #define __MACH_MXS_IOMUX_H__
 
+#ifndef __ASSEMBLY__
+
+#include <asm/types.h>
+
 /*
  * IOMUX/PAD Bit field definitions
  *
@@ -165,4 +169,5 @@  int mxs_iomux_setup_pad(iomux_cfg_t pad);
  */
 int mxs_iomux_setup_multiple_pads(const iomux_cfg_t *pad_list, unsigned count);
 
+#endif /* __ASSEMBLY__ */
 #endif /* __MACH_MXS_IOMUX_H__*/