Patchwork debugfs: add sanity check to make sure we never shift 64 bits right

login
register
mail settings
Submitter Theodore Ts'o
Date Jan. 28, 2013, 2:06 p.m.
Message ID <1359382009-28651-1-git-send-email-tytso@mit.edu>
Download mbox | patch
Permalink /patch/216210/
State Accepted
Headers show

Comments

Theodore Ts'o - Jan. 28, 2013, 2:06 p.m.
In the tables which are used to parse the fields for the set_fields
command, there should never be a entry which has a size set to 8
bytes, and two pointers defined.  Not only would it result in
undefined behavior in the compiled code, it doesn't make any sense and
is definitely a bug.

Reported-by: Xi Wang <xi.wang@gmail.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
 debugfs/set_fields.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Patch

diff --git a/debugfs/set_fields.c b/debugfs/set_fields.c
index 08bfd8d..5c86d74 100644
--- a/debugfs/set_fields.c
+++ b/debugfs/set_fields.c
@@ -389,7 +389,10 @@  static errcode_t parse_uint(struct field_set_info *info, char *field,
 	n = num & mask;
 	switch (size) {
 	case 8:
-		*u.ptr64 = n;
+		/* Should never get here */
+		fprintf(stderr, "64-bit field %s has a second 64-bit field\n"
+			"defined; BUG?!?\n", info->name);
+		*u.ptr64 = 0;
 		break;
 	case 4:
 		*u.ptr32 = n;