Patchwork [Quantal,Pull-Request] Add realtek pcie card reader driver to fix #1057089

login
register
mail settings
Submitter Adam Lee
Date Jan. 28, 2013, 7:08 a.m.
Message ID <20130128070836.GD10628@adam-laptop>
Download mbox
Permalink /patch/216115/
State New
Headers show

Pull-request

git://kernel.ubuntu.com/adamlee/ubuntu-quantal.git master

Comments

Adam Lee - Jan. 28, 2013, 7:08 a.m.
BugLink: http://launchpad.net/bugs/1057089

Backported the upstream realtek pcie card reader driver.

====

The following changes since commit 75d867d0a7f144085a4ad8b90886b608cdd28243:

  drivers/mfd: Add realtek pcie card reader driver (2013-01-28 14:28:21 +0800)

are available in the git repository at:

  git://kernel.ubuntu.com/adamlee/ubuntu-quantal.git master

for you to fetch changes up to 332d589eebf677e1c62d858fbc85130b42031e1e:

  [Config] Enable RTSX_PCI modules (2013-01-28 14:28:22 +0800)

----------------------------------------------------------------
Adam Lee (1):
      [Config] Enable RTSX_PCI modules

Wei WANG (6):
      mmc: Add realtek pcie sdmmc host driver
      mmc: rtsx: Remove a duplicate command in sd_rw_multi
      mmc: rtsx: Configure SD_CFG2 register in sd_rw_multi
      mmc: rtsx: Explicitely include slab.h in rtsx_pci_sdmmc.c
      MFD:rtsx:Avoid kernel panic if rtsx_pci_sdmmc not probed
      drivers/memstick: Add realtek pcie memstick host driver

 debian.master/config/config.common.ubuntu |    3 +
 drivers/memstick/host/Kconfig             |   10 +
 drivers/memstick/host/Makefile            |    1 +
 drivers/memstick/host/rtsx_pci_ms.c       |  641 ++++++++++++++
 drivers/mfd/rtsx_pcr.c                    |    4 +-
 drivers/mmc/host/Kconfig                  |    7 +
 drivers/mmc/host/Makefile                 |    2 +
 drivers/mmc/host/rtsx_pci_sdmmc.c         | 1326 +++++++++++++++++++++++++++++
 8 files changed, 1992 insertions(+), 2 deletions(-)
 create mode 100644 drivers/memstick/host/rtsx_pci_ms.c
 create mode 100644 drivers/mmc/host/rtsx_pci_sdmmc.c
Brad Figg - Jan. 29, 2013, 3:55 a.m.
On 01/27/2013 11:08 PM, Adam Lee wrote:
> BugLink: http://launchpad.net/bugs/1057089
> 
> Backported the upstream realtek pcie card reader driver.
> 
> ====
> 
> The following changes since commit 75d867d0a7f144085a4ad8b90886b608cdd28243:
> 
>   drivers/mfd: Add realtek pcie card reader driver (2013-01-28 14:28:21 +0800)
> 
> are available in the git repository at:
> 
>   git://kernel.ubuntu.com/adamlee/ubuntu-quantal.git master
> 
> for you to fetch changes up to 332d589eebf677e1c62d858fbc85130b42031e1e:
> 
>   [Config] Enable RTSX_PCI modules (2013-01-28 14:28:22 +0800)
> 
> ----------------------------------------------------------------
> Adam Lee (1):
>       [Config] Enable RTSX_PCI modules
> 
> Wei WANG (6):
>       mmc: Add realtek pcie sdmmc host driver
>       mmc: rtsx: Remove a duplicate command in sd_rw_multi
>       mmc: rtsx: Configure SD_CFG2 register in sd_rw_multi
>       mmc: rtsx: Explicitely include slab.h in rtsx_pci_sdmmc.c
>       MFD:rtsx:Avoid kernel panic if rtsx_pci_sdmmc not probed
>       drivers/memstick: Add realtek pcie memstick host driver
> 
>  debian.master/config/config.common.ubuntu |    3 +
>  drivers/memstick/host/Kconfig             |   10 +
>  drivers/memstick/host/Makefile            |    1 +
>  drivers/memstick/host/rtsx_pci_ms.c       |  641 ++++++++++++++
>  drivers/mfd/rtsx_pcr.c                    |    4 +-
>  drivers/mmc/host/Kconfig                  |    7 +
>  drivers/mmc/host/Makefile                 |    2 +
>  drivers/mmc/host/rtsx_pci_sdmmc.c         | 1326 +++++++++++++++++++++++++++++
>  8 files changed, 1992 insertions(+), 2 deletions(-)
>  create mode 100644 drivers/memstick/host/rtsx_pci_ms.c
>  create mode 100644 drivers/mmc/host/rtsx_pci_sdmmc.c
> 

I think there is a pretty low chance of regression with this. Other than the
"Avoid kernel panic" commit everything is in Linus' tree. Also, this is for
HW enablement which is what Q is there for.

The commits need a little cleanup (Buglink and cherry-pick lines).

Brad
Adam Lee - Jan. 29, 2013, 7:12 a.m.
On Mon, Jan 28, 2013 at 07:55:22PM -0800, Brad Figg wrote:
> I think there is a pretty low chance of regression with this. Other than the
> "Avoid kernel panic" commit everything is in Linus' tree. Also, this is for
> HW enablement which is what Q is there for.
> 
> The commits need a little cleanup (Buglink and cherry-pick lines).

FYI, that "avoid kernel panic" commit is merged in Linus's tree now.

https://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=325a86b65c01408dc77690fac1a7a45c844a613b
Tim Gardner - Jan. 29, 2013, 2 p.m.
Fix the patches in your pull request such that they have the upstream 
SHA1 as well as the bug number in the commit log. For example,

git cherry-pick -s -x 2c94b6452cc6de582584f21066cc5e36d9530c59

You can add a buglink using the kernel team tools repo script:

git format-patch -1
~/kteam-tools/maintscripts/maint-modify-patch -b 1057089 0*

rtg