Patchwork [qom-cpu,for-1.4] target-m68k: Use type_register() instead of type_register_static()

login
register
mail settings
Submitter Andreas Färber
Date Jan. 27, 2013, 6:35 p.m.
Message ID <1359311727-21276-1-git-send-email-afaerber@suse.de>
Download mbox | patch
Permalink /patch/216027/
State New
Headers show

Comments

Andreas Färber - Jan. 27, 2013, 6:35 p.m.
According to its documentation, type_register_static()'s TypeInfo
argument should exist for the life type of the type.
Therefore use type_register() when registering the list of CPU subtypes.

No functional change with the current implementation.

Cf. 918fd0839eeafc83bd4984364321a947d29041fe for arm.

Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 target-m68k/cpu.c |    2 +-
 1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-)
Andreas Färber - Jan. 28, 2013, 1:41 p.m.
Am 27.01.2013 19:35, schrieb Andreas Färber:
> According to its documentation, type_register_static()'s TypeInfo
> argument should exist for the life type of the type.
> Therefore use type_register() when registering the list of CPU subtypes.
> 
> No functional change with the current implementation.
> 
> Cf. 918fd0839eeafc83bd4984364321a947d29041fe for arm.
> 
> Signed-off-by: Andreas Färber <afaerber@suse.de>

Applied this along with the or32 and uc32 counterparts to qom-cpu:
https://github.com/afaerber/qemu-cpu/commits/qom-cpu

Andreas

Patch

diff --git a/target-m68k/cpu.c b/target-m68k/cpu.c
index e6df1ee..5c78031 100644
--- a/target-m68k/cpu.c
+++ b/target-m68k/cpu.c
@@ -162,7 +162,7 @@  static void register_cpu_type(const M68kCPUInfo *info)
         .instance_init = info->instance_init,
     };
 
-    type_register_static(&type_info);
+    type_register(&type_info);
 }
 
 static const TypeInfo m68k_cpu_type_info = {