Patchwork script: allow to pass any float value for CT_LOAD

login
register
mail settings
Submitter Samuel Martin
Date Jan. 27, 2013, 4 p.m.
Message ID <d87c8d118f4b68b5ab29.1359302429@laptop>
Download mbox | patch
Permalink /patch/216015/
State Changes Requested
Headers show

Comments

Samuel Martin - Jan. 27, 2013, 4 p.m.
# HG changeset patch
# User Samuel Martin <s.martin49@gmail.com>
# Date 1359292548 -3600
# Node ID d87c8d118f4b68b5ab297e956e5ae32149647bf8
# Parent  67df47c6ccd0c65a92c1d84813ad64f5d96dfd2b
script: allow to pass any float value for CT_LOAD


Signed-off-by: Samuel Martin <s.martin49@gmail.com>


--
For unsubscribe information see http://sourceware.org/lists.html#faq
Yann E. MORIN - Jan. 27, 2013, 4:23 p.m.
Samuel, All,

On Sunday 27 January 2013 Samuel Martin wrote:
> # HG changeset patch
> # User Samuel Martin <s.martin49@gmail.com>
> # Date 1359292548 -3600
> # Node ID d87c8d118f4b68b5ab297e956e5ae32149647bf8
> # Parent  67df47c6ccd0c65a92c1d84813ad64f5d96dfd2b
> script: allow to pass any float value for CT_LOAD
> 
> 
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> 
> diff -r 67df47c6ccd0 -r d87c8d118f4b config/global/build-behave.in
> --- a/config/global/build-behave.in	Mon Jan 21 23:03:18 2013 +0100
> +++ b/config/global/build-behave.in	Sun Jan 27 14:15:48 2013 +0100
> @@ -19,19 +19,15 @@
>        Enter 0 to set automatically based on how many processors the host has.
>  
>  config LOAD
> -    int
> +    string
>      prompt "Maximum allowed load" if ! BACKEND
> -    default 0
> +    default "0"
>      help
>        Specifies that no new jobs should be started if there are others jobs
>        running and the load average is at least this value.
> -      
> -      Makes sense on SMP machines only.
> -      
> -      Enter 0 to have no limit on the load average.
> -      
> -      Note: only the integer part of the load is allowed here (you can't enter
> -            0.75 for example).
> +
> +      Note: any float value is allowed and will be passed to the '-l' option
> +            of make (for further details, refer to the make manpage).

There's now no reference to how to not have limit on the load, since you
removed the "Enter 0 to have no limit" line.

What about making the default empty, and adding this to the help:
    Leave to empty for no load limit.

and...

>  config USE_PIPES
>      bool
> diff -r 67df47c6ccd0 -r d87c8d118f4b scripts/crosstool-NG.sh.in
> --- a/scripts/crosstool-NG.sh.in	Mon Jan 21 23:03:18 2013 +0100
> +++ b/scripts/crosstool-NG.sh.in	Sun Jan 27 14:15:48 2013 +0100
> @@ -516,7 +516,7 @@
>      AUTO_JOBS=$((`getconf _NPROCESSORS_ONLN 2> /dev/null || echo 0` + 1))
>      [ ${CT_PARALLEL_JOBS} -eq 0 ] && JOBSFLAGS="${JOBSFLAGS} -j${AUTO_JOBS}"
>      [ ${CT_PARALLEL_JOBS} -gt 0 ] && JOBSFLAGS="${JOBSFLAGS} -j${CT_PARALLEL_JOBS}"
> -    [ ${CT_LOAD} -ne 0 ] && JOBSFLAGS="${JOBSFLAGS} -l${CT_LOAD}"
> +    [ ${CT_LOAD} != "0" ] && JOBSFLAGS="${JOBSFLAGS} -l${CT_LOAD}"

... change this to simply:
    JOBSFLAGS="${JOBSFLAGS} -l${CT_LOAD}"

Regards,
Yann E. MORIN.
Samuel Martin - Jan. 27, 2013, 5:08 p.m.
Hi Yann,

2013/1/27 Yann E. MORIN <yann.morin.1998@free.fr>:
> Samuel, All,
>
> On Sunday 27 January 2013 Samuel Martin wrote:
>> # HG changeset patch
>> # User Samuel Martin <s.martin49@gmail.com>
>> # Date 1359292548 -3600
>> # Node ID d87c8d118f4b68b5ab297e956e5ae32149647bf8
>> # Parent  67df47c6ccd0c65a92c1d84813ad64f5d96dfd2b
>> script: allow to pass any float value for CT_LOAD
>>
>>
>> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
>>
>> diff -r 67df47c6ccd0 -r d87c8d118f4b config/global/build-behave.in
>> --- a/config/global/build-behave.in   Mon Jan 21 23:03:18 2013 +0100
>> +++ b/config/global/build-behave.in   Sun Jan 27 14:15:48 2013 +0100
>> @@ -19,19 +19,15 @@
>>        Enter 0 to set automatically based on how many processors the host has.
>>
>>  config LOAD
>> -    int
>> +    string
>>      prompt "Maximum allowed load" if ! BACKEND
>> -    default 0
>> +    default "0"
>>      help
>>        Specifies that no new jobs should be started if there are others jobs
>>        running and the load average is at least this value.
>> -
>> -      Makes sense on SMP machines only.
>> -
>> -      Enter 0 to have no limit on the load average.
>> -
>> -      Note: only the integer part of the load is allowed here (you can't enter
>> -            0.75 for example).
>> +
>> +      Note: any float value is allowed and will be passed to the '-l' option
>> +            of make (for further details, refer to the make manpage).
>
> There's now no reference to how to not have limit on the load, since you
> removed the "Enter 0 to have no limit" line.
>
> What about making the default empty, and adding this to the help:
>     Leave to empty for no load limit.
>
> and...
>
>>  config USE_PIPES
>>      bool
>> diff -r 67df47c6ccd0 -r d87c8d118f4b scripts/crosstool-NG.sh.in
>> --- a/scripts/crosstool-NG.sh.in      Mon Jan 21 23:03:18 2013 +0100
>> +++ b/scripts/crosstool-NG.sh.in      Sun Jan 27 14:15:48 2013 +0100
>> @@ -516,7 +516,7 @@
>>      AUTO_JOBS=$((`getconf _NPROCESSORS_ONLN 2> /dev/null || echo 0` + 1))
>>      [ ${CT_PARALLEL_JOBS} -eq 0 ] && JOBSFLAGS="${JOBSFLAGS} -j${AUTO_JOBS}"
>>      [ ${CT_PARALLEL_JOBS} -gt 0 ] && JOBSFLAGS="${JOBSFLAGS} -j${CT_PARALLEL_JOBS}"
>> -    [ ${CT_LOAD} -ne 0 ] && JOBSFLAGS="${JOBSFLAGS} -l${CT_LOAD}"
>> +    [ ${CT_LOAD} != "0" ] && JOBSFLAGS="${JOBSFLAGS} -l${CT_LOAD}"
>
> ... change this to simply:
>     JOBSFLAGS="${JOBSFLAGS} -l${CT_LOAD}"
>
ok, I'll repost it.

Regards,

Patch

diff -r 67df47c6ccd0 -r d87c8d118f4b config/global/build-behave.in
--- a/config/global/build-behave.in	Mon Jan 21 23:03:18 2013 +0100
+++ b/config/global/build-behave.in	Sun Jan 27 14:15:48 2013 +0100
@@ -19,19 +19,15 @@ 
       Enter 0 to set automatically based on how many processors the host has.
 
 config LOAD
-    int
+    string
     prompt "Maximum allowed load" if ! BACKEND
-    default 0
+    default "0"
     help
       Specifies that no new jobs should be started if there are others jobs
       running and the load average is at least this value.
-      
-      Makes sense on SMP machines only.
-      
-      Enter 0 to have no limit on the load average.
-      
-      Note: only the integer part of the load is allowed here (you can't enter
-            0.75 for example).
+
+      Note: any float value is allowed and will be passed to the '-l' option
+            of make (for further details, refer to the make manpage).
 
 config USE_PIPES
     bool
diff -r 67df47c6ccd0 -r d87c8d118f4b scripts/crosstool-NG.sh.in
--- a/scripts/crosstool-NG.sh.in	Mon Jan 21 23:03:18 2013 +0100
+++ b/scripts/crosstool-NG.sh.in	Sun Jan 27 14:15:48 2013 +0100
@@ -516,7 +516,7 @@ 
     AUTO_JOBS=$((`getconf _NPROCESSORS_ONLN 2> /dev/null || echo 0` + 1))
     [ ${CT_PARALLEL_JOBS} -eq 0 ] && JOBSFLAGS="${JOBSFLAGS} -j${AUTO_JOBS}"
     [ ${CT_PARALLEL_JOBS} -gt 0 ] && JOBSFLAGS="${JOBSFLAGS} -j${CT_PARALLEL_JOBS}"
-    [ ${CT_LOAD} -ne 0 ] && JOBSFLAGS="${JOBSFLAGS} -l${CT_LOAD}"
+    [ ${CT_LOAD} != "0" ] && JOBSFLAGS="${JOBSFLAGS} -l${CT_LOAD}"
 
     # Now that we've set up $PATH and $CT_CFLAGS_FOR_HOST, sanity test that gcc
     # is runnable so that the user can troubleshoot problems if not.