Patchwork [wwwdocs] SH 4.8 changes - document thread pointer built-ins

login
register
mail settings
Submitter Oleg Endo
Date Jan. 27, 2013, 1:45 p.m.
Message ID <1359294321.2367.31.camel@yam-132-YW-E178-FTW>
Download mbox | patch
Permalink /patch/215990/
State New
Headers show

Comments

Oleg Endo - Jan. 27, 2013, 1:45 p.m.
On Sat, 2013-01-05 at 15:19 +0100, Oleg Endo wrote:
> Hi,
> 
> On Wed, 2013-01-02 at 19:13 -1000, Gerald Pfeifer wrote:
> > Hi Oleg,
> > 
> > On Wed, 17 Oct 2012, Oleg Endo wrote:
> > >> +    <li>Added support for the built-in functions
> > >> +    <code>__builtin_thread_pointer</code> and
> > >> +    <code>__builtin_set_thread_pointer</code>.  This assumes that
> > >> +    <code>GBR</code> is used to hold the thread pointer of the current thread,
> > >> +    which has been the case since a while already. 
> > >> 
> > >> "since a while" -> "for a while", and I made that change.
> > >> That said, why is this important, and is there a fixed date or version?
> > > It might be important for some embedded systems software that does not
> > > use the GBR for storing the thread pointer, but for something else (like
> > > a pointer to some global table of frequently used stuff or something
> > > like that).  I just thought it might be better to mention this.  But
> > > you're right, the last "for a while" part sounds strange, and should
> > > probably just be removed, reducing it to "This assumes that
> > > <code>GBR</code> is used to hold the thread pointer of the current
> > > thread."
> > 
> > That sounds good.  I noticed this has not been changed yet, so I
> > assume you were probably waiting for my response?  Will you be
> > making this change?
> 
> I also assume I was waiting for your response ;)
> (it's been a while, can't remember exactly).
> 
> I'll send a patch with the change.  Thanks for reminding me.
> 
> Cheers,
> Oleg
> 
> 

I have just committed the attached patch to fix the issue mentioned
above.

Cheers,
Oleg

Patch

? www_4_8_sh_changes_4.patch
Index: htdocs/gcc-4.8/changes.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-4.8/changes.html,v
retrieving revision 1.88
diff -u -r1.88 changes.html
--- htdocs/gcc-4.8/changes.html	20 Jan 2013 13:41:25 -0000	1.88
+++ htdocs/gcc-4.8/changes.html	27 Jan 2013 13:42:23 -0000
@@ -671,10 +671,10 @@ 
     <li>Added support for the built-in functions
     <code>__builtin_thread_pointer</code> and
     <code>__builtin_set_thread_pointer</code>.  This assumes that
-    <code>GBR</code> is used to hold the thread pointer of the current thread,
-    which has been the case for a while already.  Memory loads and stores
-    relative to the address returned by <code>__builtin_thread_pointer</code>
-    will now also utilize <code>GBR</code> based displacement address modes.
+    <code>GBR</code> is used to hold the thread pointer of the current thread.
+    Memory loads and stores relative to the address returned by
+    <code>__builtin_thread_pointer</code> will now also utilize <code>GBR</code>
+    based displacement address modes.
     </li>
 
   </ul>