Patchwork [i386] : Fix PR 56114, x86_64-linux-gnu-gcc generate wrong asm instruction MOVABS for intel syntax

login
register
mail settings
Submitter Uros Bizjak
Date Jan. 27, 2013, 1:21 p.m.
Message ID <CAFULd4bwYUiC25h8pCwbqM-U1-eoEcO_UtGh=51k4P1tELrDbA@mail.gmail.com>
Download mbox | patch
Permalink /patch/215987/
State New
Headers show

Comments

Uros Bizjak - Jan. 27, 2013, 1:21 p.m.
Hello!

2013-01-27  Uros Bizjak  <ubizjak@gmail.com>

	PR target/56114
	* config/i386/i386.md (*movabs<mode>_1): Add square brackets around
	operand 0 in movabs insn template for -masm=intel asm alternative.
	(*movabs<mode>_2): Ditto for operand 1.

testsuite/ChangeLog:

2013-01-27  Uros Bizjak  <ubizjak@gmail.com>

	PR target/56114
	* gcc.target/i386/pr56114.c: New test.

Tested on x86_64-pc-linux-gnu, committed to mainline SVN, will be
backported to other release branches.

Uros.

Patch

Index: config/i386/i386.md
===================================================================
--- config/i386/i386.md	(revision 195488)
+++ config/i386/i386.md	(working copy)
@@ -2308,7 +2308,7 @@ 
 	(match_operand:SWI1248x 1 "nonmemory_operand" "a,r<i>"))]
   "TARGET_LP64 && ix86_check_movabs (insn, 0)"
   "@
-   movabs{<imodesuffix>}\t{%1, %P0|%P0, %1}
+   movabs{<imodesuffix>}\t{%1, %P0|[%P0], %1}
    mov{<imodesuffix>}\t{%1, %a0|%a0, %1}"
   [(set_attr "type" "imov")
    (set_attr "modrm" "0,*")
@@ -2322,7 +2322,7 @@ 
         (mem:SWI1248x (match_operand:DI 1 "x86_64_movabs_operand" "i,r")))]
   "TARGET_LP64 && ix86_check_movabs (insn, 1)"
   "@
-   movabs{<imodesuffix>}\t{%P1, %0|%0, %P1}
+   movabs{<imodesuffix>}\t{%P1, %0|%0, [%P1]}
    mov{<imodesuffix>}\t{%a1, %0|%0, %a1}"
   [(set_attr "type" "imov")
    (set_attr "modrm" "0,*")
Index: testsuite/gcc.target/i386/pr56114.c
===================================================================
--- testsuite/gcc.target/i386/pr56114.c	(revision 0)
+++ testsuite/gcc.target/i386/pr56114.c	(working copy)
@@ -0,0 +1,10 @@ 
+/* { dg-do assemble } */
+/* { dg-options "-O2 -masm=intel" } */
+/* { dg-require-effective-target lp64 } */
+/* { dg-require-effective-target masm_intel } */
+
+long
+foo2 (void)
+{
+  return *(volatile int *) 0xFEE00000;
+}