From patchwork Thu Jan 26 22:55:03 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Ext4: remove a useless check for the function ext4_data_block_valid Date: Thu, 26 Jan 2012 12:55:03 -0000 From: Wang shilong X-Patchwork-Id: 215890 Message-Id: <4F21D9C7.1000303@gmail.com> To: tytso@mit.edu Cc: linux-ext4@vger.kernel.org From: Wang Shilong Because it is no doubt 'start_blk + count < start_blk' always comes to false. It is useless to have this check,remove it. Signed-off-by: Wang Shilong --- fs/ext4/block_validity.c | 1 - 1 file changed, 1 deletion(-) -- 1.7.11.7 -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/fs/ext4/block_validity.c b/fs/ext4/block_validity.c index 3f11656..5ffce82 100644 --- a/fs/ext4/block_validity.c +++ b/fs/ext4/block_validity.c @@ -226,7 +226,6 @@ int ext4_data_block_valid(struct ext4_sb_info *sbi, ext4_fsblk_t start_blk, struct rb_node *n = sbi->system_blks.rb_node; if ((start_blk <= le32_to_cpu(sbi->s_es->s_first_data_block)) || - (start_blk + count < start_blk) || (start_blk + count > ext4_blocks_count(sbi->s_es))) { sbi->s_es->s_last_error_block = cpu_to_le64(start_blk); return 0;