Patchwork [ARM,5/5] Cleanup in cortex-a7 pipeline description

login
register
mail settings
Submitter Greta Yorsh
Date Jan. 25, 2013, 6:25 p.m.
Message ID <001a01cdfb29$5b7f6940$127e3bc0$@yorsh@arm.com>
Download mbox | patch
Permalink /patch/215825/
State New
Headers show

Comments

Greta Yorsh - Jan. 25, 2013, 6:25 p.m.
In cortex_a7_idiv, the use of cortex_a7_all reservation can be replaced by
cortex_a7_both, because all other reservations require at least one of
cortex_a7_ex1 or cortex_a7_ex2. Then, remove unused reservation units
cortex_a7_neon and cortex_a7_all.

gcc/

2013-01-03  Greta Yorsh  <Greta.Yorsh@arm.com>

        * config/arm/cortex-a7.md (cortex_a7_neon, cortex_a7_all): Remove.
        (cortex_a7_idiv): Use cortex_a7_both instead of cortex_a7_all.
Ramana Radhakrishnan - Jan. 29, 2013, 5:48 p.m.
On 01/25/13 18:25, Greta Yorsh wrote:
> In cortex_a7_idiv, the use of cortex_a7_all reservation can be replaced by
> cortex_a7_both, because all other reservations require at least one of
> cortex_a7_ex1 or cortex_a7_ex2. Then, remove unused reservation units
> cortex_a7_neon and cortex_a7_all.
>
> gcc/
>
> 2013-01-03  Greta Yorsh  <Greta.Yorsh@arm.com>
>
>          * config/arm/cortex-a7.md (cortex_a7_neon, cortex_a7_all): Remove.
>          (cortex_a7_idiv): Use cortex_a7_both instead of cortex_a7_all.
>


Ok for the same reason as others given they only touch A7 pipeline 
descriptions.

Ramana

Patch

diff --git a/gcc/config/arm/cortex-a7.md b/gcc/config/arm/cortex-a7.md
index 8c45cb8..21f84b5 100644
--- a/gcc/config/arm/cortex-a7.md
+++ b/gcc/config/arm/cortex-a7.md
@@ -57,15 +57,6 @@ 
 
 (define_cpu_unit "cortex_a7_fp_div_sqrt" "cortex_a7")
 
-;; Neon pipeline
-(define_cpu_unit "cortex_a7_neon" "cortex_a7")
-
-(define_reservation "cortex_a7_all" "cortex_a7_both+\
-                                     cortex_a7_fpmul_pipe+\
-                                     cortex_a7_fpadd_pipe+\
-                                     cortex_a7_fp_div_sqrt+\
-                                     cortex_a7_neon")
-
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
 ;; Branches.
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
@@ -151,7 +142,7 @@ 
 (define_insn_reservation "cortex_a7_idiv" 5
   (and (eq_attr "tune" "cortexa7")
        (eq_attr "insn" "udiv,sdiv"))
-  "cortex_a7_all*5")
+  "cortex_a7_both*5")
 
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
 ;; Load/store instructions.