Patchwork [1/1] sclpconsole: Dont instantiate sclpconsole with nodefaults

login
register
mail settings
Submitter Christian Borntraeger
Date Jan. 25, 2013, 4 p.m.
Message ID <1359129619-11276-2-git-send-email-borntraeger@de.ibm.com>
Download mbox | patch
Permalink /patch/215788/
State New
Headers show

Comments

Christian Borntraeger - Jan. 25, 2013, 4 p.m.
libvirt specifies nodefaults and creates an sclp console with special
parameters. Let qemu follow nodefaults and dont create an sclp
console if nodefaults is specified.

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
 vl.c | 1 +
 1 file changed, 1 insertion(+)
Andreas Färber - Jan. 25, 2013, 4:08 p.m.
Am 25.01.2013 17:00, schrieb Christian Borntraeger:
> libvirt specifies nodefaults and creates an sclp console with special
> parameters. Let qemu follow nodefaults and dont create an sclp
> console if nodefaults is specified.
> 
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>

don't, -nodefaults, QEMU - Alex, please fix when applying.

> ---
>  vl.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/vl.c b/vl.c
> index affc524..ea26dae 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3658,6 +3658,7 @@ int main(int argc, char **argv, char **envp)
>                  default_serial = 0;
>                  default_parallel = 0;
>                  default_virtcon = 0;
> +                default_sclp = 0;
>                  default_monitor = 0;
>                  default_net = 0;
>                  default_floppy = 0;

ACK

Please remember to submit patches that don't apply to qemu.git as [PATCH
s390-next ...] to avoid Anthony's bot complaining.

Cheers,
Andreas
Alexander Graf - Jan. 25, 2013, 4:58 p.m.
On 25.01.2013, at 17:00, Christian Borntraeger wrote:

> libvirt specifies nodefaults and creates an sclp console with special
> parameters. Let qemu follow nodefaults and dont create an sclp
> console if nodefaults is specified.
> 
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>

Thanks, applied to s390-next (with spelling fixes).


Alex

> ---
> vl.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/vl.c b/vl.c
> index affc524..ea26dae 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3658,6 +3658,7 @@ int main(int argc, char **argv, char **envp)
>                 default_serial = 0;
>                 default_parallel = 0;
>                 default_virtcon = 0;
> +                default_sclp = 0;
>                 default_monitor = 0;
>                 default_net = 0;
>                 default_floppy = 0;
> -- 
> 1.7.11.4
>

Patch

diff --git a/vl.c b/vl.c
index affc524..ea26dae 100644
--- a/vl.c
+++ b/vl.c
@@ -3658,6 +3658,7 @@  int main(int argc, char **argv, char **envp)
                 default_serial = 0;
                 default_parallel = 0;
                 default_virtcon = 0;
+                default_sclp = 0;
                 default_monitor = 0;
                 default_net = 0;
                 default_floppy = 0;