Patchwork [AARCH64] Fix warning: "TARGET_FIXED_CONDITION_CODE_REGS" redefined

login
register
mail settings
Submitter Hurugalawadi, Naveen
Date Jan. 25, 2013, 6:15 a.m.
Message ID <F3068DEED1A463459E0887A091B15493394CD5@BY2PRD0710MB364.namprd07.prod.outlook.com>
Download mbox | patch
Permalink /patch/215555/
State New
Headers show

Comments

Hurugalawadi, Naveen - Jan. 25, 2013, 6:15 a.m.
Hi,

Please find attached the patch that fixes following warning in aarch64:-
warning: "TARGET_FIXED_CONDITION_CODE_REGS" redefined

Thanks,
Naveen.H.S

2013-01-25   Naveen H.S  <Naveen.Hurugalawadi@caviumnetworks.com>

	* config/aarch64/aarch64.c (TARGET_FIXED_CONDITION_CODE_REGS):
	undef to avoid warning
Marcus Shawcroft - Jan. 25, 2013, 8:28 a.m.
On 25/01/13 06:15, Hurugalawadi, Naveen wrote:
> Hi,
>
> Please find attached the patch that fixes following warning in aarch64:-
> warning: "TARGET_FIXED_CONDITION_CODE_REGS" redefined
>
> Thanks,
> Naveen.H.S
>
> 2013-01-25   Naveen H.S  <Naveen.Hurugalawadi@caviumnetworks.com>
>
> 	* config/aarch64/aarch64.c (TARGET_FIXED_CONDITION_CODE_REGS):
> 	undef to avoid warning
>

ChangeLog entries are full sentences, hence they should start with a 
capital and end in a period.

While you are making this change to TARGET_FIXED_CONDITIONAL_CODE_REGS, 
would you mind moving it to retain alphabetical?

Otherwise OK.

How about back porting this #define to ARM/aarch64-4.7-branch ?

Thanks
/Marcus

Patch

--- gcc/config/aarch64/aarch64.c	2013-01-24 20:10:09.163833393 +0530
+++ gcc/config/aarch64/aarch64.c	2013-01-25 11:27:06.090580850 +0530
@@ -7964,6 +7964,7 @@  aarch64_vectorize_vec_perm_const_ok (enu
   aarch64_vectorize_vec_perm_const_ok
 
 
+#undef TARGET_FIXED_CONDITION_CODE_REGS
 #define TARGET_FIXED_CONDITION_CODE_REGS aarch64_fixed_condition_code_regs
 
 struct gcc_target targetm = TARGET_INITIALIZER;