Patchwork Makefile: remove *.lo files when make clean

login
register
mail settings
Submitter liguang
Date Jan. 25, 2013, 5:25 a.m.
Message ID <1359091548-29316-1-git-send-email-lig.fnst@cn.fujitsu.com>
Download mbox | patch
Permalink /patch/215554/
State New
Headers show

Comments

liguang - Jan. 25, 2013, 5:25 a.m.
remove *.lo files, they will bring errors during
build after a make clean, e.g.
make clean
make
lt LINK libcacard.la
gcc: stubs/.libs/arch-query-cpu-def.o: No such file or directory
gcc: stubs/.libs/clock-warp.o: No such file or directory
gcc: stubs/.libs/cpu-get-clock.o: No such file or directory

Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
---
 Makefile |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Stefan Hajnoczi - Jan. 25, 2013, 7:19 a.m.
On Fri, Jan 25, 2013 at 6:25 AM, liguang <lig.fnst@cn.fujitsu.com> wrote:
> remove *.lo files, they will bring errors during
> build after a make clean, e.g.
> make clean
> make
> lt LINK libcacard.la
> gcc: stubs/.libs/arch-query-cpu-def.o: No such file or directory
> gcc: stubs/.libs/clock-warp.o: No such file or directory
> gcc: stubs/.libs/cpu-get-clock.o: No such file or directory
>
> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
> ---
>  Makefile |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)

This should go into QEMU 1.4 - it's needed for in-tree builds.

Reviewed-by: Stefan Hajnoczi
Paolo Bonzini - Jan. 25, 2013, 9:10 a.m.
Il 25/01/2013 06:25, liguang ha scritto:
> remove *.lo files, they will bring errors during
> build after a make clean, e.g.
> make clean
> make
> lt LINK libcacard.la
> gcc: stubs/.libs/arch-query-cpu-def.o: No such file or directory
> gcc: stubs/.libs/clock-warp.o: No such file or directory
> gcc: stubs/.libs/cpu-get-clock.o: No such file or directory
> 
> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
> ---
>  Makefile |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 73adf42..5d64b58 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -215,7 +215,8 @@ clean:
>  	rm -f config.mak op-i386.h opc-i386.h gen-op-i386.h op-arm.h opc-arm.h gen-op-arm.h
>  	rm -f qemu-options.def
>  	find . -name '*.[od]' -type f -exec rm -f {} +
> -	rm -f *.a *.lo $(TOOLS) $(HELPERS-y) qemu-ga TAGS cscope.* *.pod *~ */*~
> +	find . -name '*.lo' -type f -exec rm -f {} +
> +	rm -f *.a $(TOOLS) $(HELPERS-y) qemu-ga TAGS cscope.* *.pod *~ */*~
>  	rm -f *.la
>  	rm -Rf .libs
>  	rm -f qemu-img-cmds.h
> 

See the similar patch at
http://permalink.gmane.org/gmane.comp.emulators.qemu/188686

Paolo
liguang - Jan. 25, 2013, 9:22 a.m.
在 2013-01-25五的 10:10 +0100,Paolo Bonzini写道:
> Il 25/01/2013 06:25, liguang ha scritto:
> > remove *.lo files, they will bring errors during
> > build after a make clean, e.g.
> > make clean
> > make
> > lt LINK libcacard.la
> > gcc: stubs/.libs/arch-query-cpu-def.o: No such file or directory
> > gcc: stubs/.libs/clock-warp.o: No such file or directory
> > gcc: stubs/.libs/cpu-get-clock.o: No such file or directory
> > 
> > Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
> > ---
> >  Makefile |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> > 
> > diff --git a/Makefile b/Makefile
> > index 73adf42..5d64b58 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -215,7 +215,8 @@ clean:
> >  	rm -f config.mak op-i386.h opc-i386.h gen-op-i386.h op-arm.h opc-arm.h gen-op-arm.h
> >  	rm -f qemu-options.def
> >  	find . -name '*.[od]' -type f -exec rm -f {} +
> > -	rm -f *.a *.lo $(TOOLS) $(HELPERS-y) qemu-ga TAGS cscope.* *.pod *~ */*~
> > +	find . -name '*.lo' -type f -exec rm -f {} +
> > +	rm -f *.a $(TOOLS) $(HELPERS-y) qemu-ga TAGS cscope.* *.pod *~ */*~
> >  	rm -f *.la
> >  	rm -Rf .libs
> >  	rm -f qemu-img-cmds.h
> > 
> 
> See the similar patch at
> http://permalink.gmane.org/gmane.comp.emulators.qemu/188686
> 
> Paolo

Oh, sorry, didn't notice it.
but, seems rm libcacard.la is overshoot, 
it doesn't hurt, am I right?

Patch

diff --git a/Makefile b/Makefile
index 73adf42..5d64b58 100644
--- a/Makefile
+++ b/Makefile
@@ -215,7 +215,8 @@  clean:
 	rm -f config.mak op-i386.h opc-i386.h gen-op-i386.h op-arm.h opc-arm.h gen-op-arm.h
 	rm -f qemu-options.def
 	find . -name '*.[od]' -type f -exec rm -f {} +
-	rm -f *.a *.lo $(TOOLS) $(HELPERS-y) qemu-ga TAGS cscope.* *.pod *~ */*~
+	find . -name '*.lo' -type f -exec rm -f {} +
+	rm -f *.a $(TOOLS) $(HELPERS-y) qemu-ga TAGS cscope.* *.pod *~ */*~
 	rm -f *.la
 	rm -Rf .libs
 	rm -f qemu-img-cmds.h