Patchwork [U-Boot,3/5] MIPS: start.S: save reused arguments earlier in relocate_code

login
register
mail settings
Submitter Gabor Juhos
Date Jan. 24, 2013, 4:27 p.m.
Message ID <1359044875-28631-4-git-send-email-juhosg@openwrt.org>
Download mbox | patch
Permalink /patch/215428/
State Accepted
Delegated to: Daniel Schwierzeck
Headers show

Comments

Gabor Juhos - Jan. 24, 2013, 4:27 p.m.
Save the reused parameters at the beginning
of the 'relocate_code' function. This makes
the function a bit more readable.

Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
Cc: Daniel Schwierzeck <daniel.schwierzeck@googlemail.com>
---
 arch/mips/cpu/mips32/start.S |    5 +++--
 arch/mips/cpu/mips64/start.S |    5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)

Patch

diff --git a/arch/mips/cpu/mips32/start.S b/arch/mips/cpu/mips32/start.S
index 88e8036..64a606f 100644
--- a/arch/mips/cpu/mips32/start.S
+++ b/arch/mips/cpu/mips32/start.S
@@ -279,11 +279,13 @@  reset:
 relocate_code:
 	move	sp, a0			# set new stack pointer
 
+	move	s0, a1			# save gd in s0
+	move	s2, a2			# save destination address in s2
+
 	li	t0, CONFIG_SYS_MONITOR_BASE
 	la	t3, in_ram
 	lw	t2, -12(t3)		# t2 <-- uboot_end_data
 	move	t1, a2
-	move	s2, a2			# s2 <-- destination address
 
 	/*
 	 * Fix $gp:
@@ -304,7 +306,6 @@  relocate_code:
 	/*
 	 * Save destination address and size for later usage in flush_cache()
 	 */
-	move	s0, a1			# save gd in s0
 	move	a0, t1			# a0 <-- destination addr
 	sub	a1, t2, t0		# a1 <-- size
 
diff --git a/arch/mips/cpu/mips64/start.S b/arch/mips/cpu/mips64/start.S
index d3c5cea..3c0f1c3 100644
--- a/arch/mips/cpu/mips64/start.S
+++ b/arch/mips/cpu/mips64/start.S
@@ -158,11 +158,13 @@  reset:
 relocate_code:
 	move	sp, a0			# set new stack pointer
 
+	move	s0, a1			# save gd in s0
+	move	s2, a2			# save destination address in s2
+
 	dli	t0, CONFIG_SYS_MONITOR_BASE
 	dla	t3, in_ram
 	ld	t2, -24(t3)		# t2 <-- uboot_end_data
 	move	t1, a2
-	move	s2, a2			# s2 <-- destination address
 
 	/*
 	 * Fix $gp:
@@ -183,7 +185,6 @@  relocate_code:
 	/*
 	 * Save destination address and size for dlater usage in flush_cache()
 	 */
-	move	s0, a1			# save gd in s0
 	move	a0, t1			# a0 <-- destination addr
 	dsub	a1, t2, t0		# a1 <-- size