Patchwork gdb: Add support for gdb 7.5.1 and make it the default.

login
register
mail settings
Submitter Will Newton
Date Jan. 24, 2013, 11:33 a.m.
Message ID <CAFbHwiQ2bqy9HMrWHLan-M3Oy1mFBd2QOkQMoVU=NiAKkd4cQw@mail.gmail.com>
Download mbox | patch
Permalink /patch/215327/
State Accepted
Headers show

Comments

Will Newton - Jan. 24, 2013, 11:33 a.m.
Signed-off-by: Will Newton <will.newton@imgtec.com>
---
 toolchain/gdb/Config.in |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)

I'm imagine a few of those older version could be safely removed but I am not
sure which versions people are using. Aside from avr32 and bfin is anyone
using a non-7.4 version?
Peter Korsgaard - Jan. 24, 2013, 1:42 p.m.
>>>>> "Will" == Will Newton <will.newton@gmail.com> writes:

 Will> Signed-off-by: Will Newton <will.newton@imgtec.com>

Committed, thanks.

 Will> ---
 Will>  toolchain/gdb/Config.in |    9 ++++++++-
 Will>  1 files changed, 8 insertions(+), 1 deletions(-)

 Will> I'm imagine a few of those older version could be safely removed
 Will> but I am not sure which versions people are using. Aside from
 Will> avr32 and bfin is anyone using a non-7.4 version?

Yes, I think we could probably remove some of the deprecated versions
(6.8/7.0/7.1).
Arnout Vandecappelle - Jan. 24, 2013, 6:56 p.m.
On 01/24/13 12:33, Will Newton wrote:
>   	prompt "GDB debugger Version"
>   	default BR2_GDB_VERSION_6_6 if BR2_bfin
>   	default BR2_GDB_VERSION_6_7_1_AVR32_2_1_5 if BR2_avr32

  Not related but I see it now: does gdb 7.* actually work for avr32? If 
so, why do we keep this old version around?

  Regards,
  Arnout
Peter Korsgaard - Jan. 24, 2013, 8:09 p.m.
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:

 Arnout> On 01/24/13 12:33, Will Newton wrote:
 >> prompt "GDB debugger Version"
 >> default BR2_GDB_VERSION_6_6 if BR2_bfin
 >> default BR2_GDB_VERSION_6_7_1_AVR32_2_1_5 if BR2_avr32

 Arnout>  Not related but I see it now: does gdb 7.* actually work for avr32?
 Arnout> If so, why do we keep this old version around?

I believe it doesn't, but I've never tried. All the 7.x versions
shouldn't be selectable for avr32 (unless I'm wrong and they do work).

Patch

diff --git a/toolchain/gdb/Config.in b/toolchain/gdb/Config.in
index 6a8e48e..53dcb93 100644
--- a/toolchain/gdb/Config.in
+++ b/toolchain/gdb/Config.in
@@ -45,7 +45,7 @@  choice
 	prompt "GDB debugger Version"
 	default BR2_GDB_VERSION_6_6 if BR2_bfin
 	default BR2_GDB_VERSION_6_7_1_AVR32_2_1_5 if BR2_avr32
-	default BR2_GDB_VERSION_7_4
+	default BR2_GDB_VERSION_7_5
 	depends on BR2_PACKAGE_GDB || BR2_PACKAGE_GDB_SERVER || BR2_PACKAGE_GDB_HOST
 	help
 	  Select the version of gdb you wish to use.
@@ -95,6 +95,12 @@  choice
 		depends on BR2_TOOLCHAIN_HAS_THREADS_DEBUG_IF_NEEDED
 		select BR2_PTHREAD_DEBUG if (BR2_TOOLCHAIN_BUILDROOT && !BR2_PTHREADS_NONE)

+	config BR2_GDB_VERSION_7_5
+		bool "gdb 7.5.x"
+		depends on !BR2_bfin
+		depends on BR2_TOOLCHAIN_HAS_THREADS_DEBUG_IF_NEEDED
+		select BR2_PTHREAD_DEBUG if (BR2_TOOLCHAIN_BUILDROOT && !BR2_PTHREADS_NONE)
+
 endchoice

 comment "gdb support needs pthread debug support in toolchain"
@@ -110,3 +116,4 @@  config BR2_GDB_VERSION
 	default "7.2a"     if BR2_GDB_VERSION_7_2
 	default "7.3.1"    if BR2_GDB_VERSION_7_3
 	default "7.4.1"    if BR2_GDB_VERSION_7_4
+	default "7.5.1"    if BR2_GDB_VERSION_7_5