Patchwork [for-1.4] target-cris: Fix typo in D_LOG() macro

login
register
mail settings
Submitter Andreas Färber
Date Jan. 24, 2013, 9:51 a.m.
Message ID <1359021107-29413-1-git-send-email-afaerber@suse.de>
Download mbox | patch
Permalink /patch/215296/
State New
Headers show

Comments

Andreas Färber - Jan. 24, 2013, 9:51 a.m.
It's __VAR_ARGS__. Fixes the build with CRIS_[OP_]HELPER_DEBUG defined.

Broken since r6338 / 93fcfe39a0383377e647b821c9f165fd927cd4e0 (Convert
references to logfile/loglevel to use qemu_log*() macros).

Cc: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 target-cris/helper.c    |    2 +-
 target-cris/op_helper.c |    2 +-
 2 Dateien geändert, 2 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-)
Andreas Färber - Jan. 24, 2013, 9:53 a.m.
Am 24.01.2013 10:51, schrieb Andreas Färber:
> It's __VAR_ARGS__. Fixes the build with CRIS_[OP_]HELPER_DEBUG defined.

__VA_ARGS__ obviously. :) Please fix when committing.

Andreas

> 
> Broken since r6338 / 93fcfe39a0383377e647b821c9f165fd927cd4e0 (Convert
> references to logfile/loglevel to use qemu_log*() macros).
> 
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>  target-cris/helper.c    |    2 +-
>  target-cris/op_helper.c |    2 +-
>  2 Dateien geändert, 2 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-)
> 
> diff --git a/target-cris/helper.c b/target-cris/helper.c
> index 8407a6d..6e75e98 100644
> --- a/target-cris/helper.c
> +++ b/target-cris/helper.c
> @@ -28,7 +28,7 @@
>  
>  #ifdef CRIS_HELPER_DEBUG
>  #define D(x) x
> -#define D_LOG(...) qemu_log(__VA__ARGS__)
> +#define D_LOG(...) qemu_log(__VA_ARGS__)
>  #else
>  #define D(x)
>  #define D_LOG(...) do { } while (0)
> diff --git a/target-cris/op_helper.c b/target-cris/op_helper.c
> index 79bff38..0f6a1ee 100644
> --- a/target-cris/op_helper.c
> +++ b/target-cris/op_helper.c
> @@ -28,7 +28,7 @@
>  
>  #ifdef CRIS_OP_HELPER_DEBUG
>  #define D(x) x
> -#define D_LOG(...) qemu_log(__VA__ARGS__)
> +#define D_LOG(...) qemu_log(__VA_ARGS__)
>  #else
>  #define D(x)
>  #define D_LOG(...) do { } while (0)
>
Edgar Iglesias - Jan. 24, 2013, 10:30 a.m.
On Thu, Jan 24, 2013 at 10:51:47AM +0100, Andreas Färber wrote:
> It's __VAR_ARGS__. Fixes the build with CRIS_[OP_]HELPER_DEBUG defined.
> 
> Broken since r6338 / 93fcfe39a0383377e647b821c9f165fd927cd4e0 (Convert
> references to logfile/loglevel to use qemu_log*() macros).

Applied, thanks!


> 
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>  target-cris/helper.c    |    2 +-
>  target-cris/op_helper.c |    2 +-
>  2 Dateien geändert, 2 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-)
> 
> diff --git a/target-cris/helper.c b/target-cris/helper.c
> index 8407a6d..6e75e98 100644
> --- a/target-cris/helper.c
> +++ b/target-cris/helper.c
> @@ -28,7 +28,7 @@
>  
>  #ifdef CRIS_HELPER_DEBUG
>  #define D(x) x
> -#define D_LOG(...) qemu_log(__VA__ARGS__)
> +#define D_LOG(...) qemu_log(__VA_ARGS__)
>  #else
>  #define D(x)
>  #define D_LOG(...) do { } while (0)
> diff --git a/target-cris/op_helper.c b/target-cris/op_helper.c
> index 79bff38..0f6a1ee 100644
> --- a/target-cris/op_helper.c
> +++ b/target-cris/op_helper.c
> @@ -28,7 +28,7 @@
>  
>  #ifdef CRIS_OP_HELPER_DEBUG
>  #define D(x) x
> -#define D_LOG(...) qemu_log(__VA__ARGS__)
> +#define D_LOG(...) qemu_log(__VA_ARGS__)
>  #else
>  #define D(x)
>  #define D_LOG(...) do { } while (0)
> -- 
> 1.7.10.4
>

Patch

diff --git a/target-cris/helper.c b/target-cris/helper.c
index 8407a6d..6e75e98 100644
--- a/target-cris/helper.c
+++ b/target-cris/helper.c
@@ -28,7 +28,7 @@ 
 
 #ifdef CRIS_HELPER_DEBUG
 #define D(x) x
-#define D_LOG(...) qemu_log(__VA__ARGS__)
+#define D_LOG(...) qemu_log(__VA_ARGS__)
 #else
 #define D(x)
 #define D_LOG(...) do { } while (0)
diff --git a/target-cris/op_helper.c b/target-cris/op_helper.c
index 79bff38..0f6a1ee 100644
--- a/target-cris/op_helper.c
+++ b/target-cris/op_helper.c
@@ -28,7 +28,7 @@ 
 
 #ifdef CRIS_OP_HELPER_DEBUG
 #define D(x) x
-#define D_LOG(...) qemu_log(__VA__ARGS__)
+#define D_LOG(...) qemu_log(__VA_ARGS__)
 #else
 #define D(x)
 #define D_LOG(...) do { } while (0)