Patchwork [19/57] target-i386: no need to flush out cc_op before gen_eob

login
register
mail settings
Submitter Richard Henderson
Date Jan. 24, 2013, 4:03 a.m.
Message ID <1359000221-19834-20-git-send-email-rth@twiddle.net>
Download mbox | patch
Permalink /patch/215250/
State New
Headers show

Comments

Richard Henderson - Jan. 24, 2013, 4:03 a.m.
This makes code more similar to the other callers of gen_eob, especially
loopz/loopnz/jcxz.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 target-i386/translate.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Patch

diff --git a/target-i386/translate.c b/target-i386/translate.c
index 39893fd..af6ca49 100644
--- a/target-i386/translate.c
+++ b/target-i386/translate.c
@@ -2302,8 +2302,8 @@  static inline void gen_jcc(DisasContext *s, int b,
 {
     int l1, l2;
 
-    gen_update_cc_op(s);
     if (s->jmp_opt) {
+        gen_update_cc_op(s);
         l1 = gen_new_label();
         gen_jcc1(s, b, l1);
         set_cc_op(s, CC_OP_DYNAMIC);
@@ -2314,11 +2314,9 @@  static inline void gen_jcc(DisasContext *s, int b,
         gen_goto_tb(s, 1, val);
         s->is_jmp = DISAS_TB_JUMP;
     } else {
-
         l1 = gen_new_label();
         l2 = gen_new_label();
         gen_jcc1(s, b, l1);
-        set_cc_op(s, CC_OP_DYNAMIC);
 
         gen_jmp_im(next_eip);
         tcg_gen_br(l2);