Patchwork [Precise,SRU,Pull-Request] bug #1101666: revert fsnotify patchset

login
register
mail settings
Submitter Luis Henriques
Date Jan. 23, 2013, 9:32 p.m.
Message ID <1358976778-27325-1-git-send-email-luis.henriques@canonical.com>
Download mbox
Permalink /patch/215040/
State New
Headers show

Pull-request

git://kernel.ubuntu.com/henrix/ubuntu-precise fsnotify

Comments

Luis Henriques - Jan. 23, 2013, 9:32 p.m.
== Precise SRU Justification ==

BugLink: http://bugs.launchpad.net/bugs/1101666

This pull request reverts all the fsnotify patches that have been added
into the kernel in the last release due to a regression.  A fix has
already been identified and is currently being tested, but it's not yet
ready for release.

== Fix ==

The following changes since commit 4d47c361f449b82c2d7760949f076c778ee70fbe:

  UBUNTU: Ubuntu-3.2.0-36.57 (2013-01-08 18:48:42 +0000)

are available in the git repository at:

  git://kernel.ubuntu.com/henrix/ubuntu-precise fsnotify

for you to fetch changes up to 3e909ea1d927c0950035f333c7070a1495ac3b2e:

  Revert "fsnotify: introduce fsnotify_get_group()" (2013-01-23 21:07:10 +0000)

----------------------------------------------------------------
Luis Henriques (9):
      Revert "fsnotify: change locking order"
      Revert "fsnotify: dont put marks on temporary list when clearing marks by group"
      Revert "fsnotify: introduce locked versions of fsnotify_add_mark() and fsnotify_remove_mark()"
      Revert "fsnotify: pass group to fsnotify_destroy_mark()"
      Revert "fsnotify: use a mutex instead of a spinlock to protect a groups mark list"
      Revert "fanotify: add an extra flag to mark_remove_from_mask that indicates wheather a mark should be destroyed"
      Revert "fsnotify: take groups mark_lock before mark lock"
      Revert "fsnotify: use reference counting for groups"
      Revert "fsnotify: introduce fsnotify_get_group()"

 fs/notify/dnotify/dnotify.c          |  4 +-
 fs/notify/fanotify/fanotify_user.c   | 19 ++------
 fs/notify/group.c                    | 38 +++++++--------
 fs/notify/inode_mark.c               | 14 ++----
 fs/notify/inotify/inotify_fsnotify.c |  4 +-
 fs/notify/inotify/inotify_user.c     |  3 +-
 fs/notify/mark.c                     | 91 ++++++++++++++++--------------------
 fs/notify/vfsmount_mark.c            | 14 ++----
 include/linux/fsnotify_backend.h     | 23 ++++-----
 kernel/audit_tree.c                  | 14 +++---
 kernel/audit_watch.c                 |  4 +-
 11 files changed, 92 insertions(+), 136 deletions(-)
Leann Ogasawara - Jan. 23, 2013, 9:41 p.m.
Acked-by: Leann Ogasawara <leann.ogasawara@canonical.com>

On 01/23/2013 01:32 PM, Luis Henriques wrote:
> == Precise SRU Justification ==
>
> BugLink: http://bugs.launchpad.net/bugs/1101666
>
> This pull request reverts all the fsnotify patches that have been added
> into the kernel in the last release due to a regression.  A fix has
> already been identified and is currently being tested, but it's not yet
> ready for release.
>
> == Fix ==
>
> The following changes since commit 4d47c361f449b82c2d7760949f076c778ee70fbe:
>
>   UBUNTU: Ubuntu-3.2.0-36.57 (2013-01-08 18:48:42 +0000)
>
> are available in the git repository at:
>
>   git://kernel.ubuntu.com/henrix/ubuntu-precise fsnotify
>
> for you to fetch changes up to 3e909ea1d927c0950035f333c7070a1495ac3b2e:
>
>   Revert "fsnotify: introduce fsnotify_get_group()" (2013-01-23 21:07:10 +0000)
>
> ----------------------------------------------------------------
> Luis Henriques (9):
>       Revert "fsnotify: change locking order"
>       Revert "fsnotify: dont put marks on temporary list when clearing marks by group"
>       Revert "fsnotify: introduce locked versions of fsnotify_add_mark() and fsnotify_remove_mark()"
>       Revert "fsnotify: pass group to fsnotify_destroy_mark()"
>       Revert "fsnotify: use a mutex instead of a spinlock to protect a groups mark list"
>       Revert "fanotify: add an extra flag to mark_remove_from_mask that indicates wheather a mark should be destroyed"
>       Revert "fsnotify: take groups mark_lock before mark lock"
>       Revert "fsnotify: use reference counting for groups"
>       Revert "fsnotify: introduce fsnotify_get_group()"
>
>  fs/notify/dnotify/dnotify.c          |  4 +-
>  fs/notify/fanotify/fanotify_user.c   | 19 ++------
>  fs/notify/group.c                    | 38 +++++++--------
>  fs/notify/inode_mark.c               | 14 ++----
>  fs/notify/inotify/inotify_fsnotify.c |  4 +-
>  fs/notify/inotify/inotify_user.c     |  3 +-
>  fs/notify/mark.c                     | 91 ++++++++++++++++--------------------
>  fs/notify/vfsmount_mark.c            | 14 ++----
>  include/linux/fsnotify_backend.h     | 23 ++++-----
>  kernel/audit_tree.c                  | 14 +++---
>  kernel/audit_watch.c                 |  4 +-
>  11 files changed, 92 insertions(+), 136 deletions(-)
>
Brad Figg - Jan. 23, 2013, 10:26 p.m.
On 01/23/2013 01:32 PM, Luis Henriques wrote:
> == Precise SRU Justification ==
> 
> BugLink: http://bugs.launchpad.net/bugs/1101666
> 
> This pull request reverts all the fsnotify patches that have been added
> into the kernel in the last release due to a regression.  A fix has
> already been identified and is currently being tested, but it's not yet
> ready for release.
> 
> == Fix ==
> 
> The following changes since commit 4d47c361f449b82c2d7760949f076c778ee70fbe:
> 
>   UBUNTU: Ubuntu-3.2.0-36.57 (2013-01-08 18:48:42 +0000)
> 
> are available in the git repository at:
> 
>   git://kernel.ubuntu.com/henrix/ubuntu-precise fsnotify
> 
> for you to fetch changes up to 3e909ea1d927c0950035f333c7070a1495ac3b2e:
> 
>   Revert "fsnotify: introduce fsnotify_get_group()" (2013-01-23 21:07:10 +0000)
> 
> ----------------------------------------------------------------
> Luis Henriques (9):
>       Revert "fsnotify: change locking order"
>       Revert "fsnotify: dont put marks on temporary list when clearing marks by group"
>       Revert "fsnotify: introduce locked versions of fsnotify_add_mark() and fsnotify_remove_mark()"
>       Revert "fsnotify: pass group to fsnotify_destroy_mark()"
>       Revert "fsnotify: use a mutex instead of a spinlock to protect a groups mark list"
>       Revert "fanotify: add an extra flag to mark_remove_from_mask that indicates wheather a mark should be destroyed"
>       Revert "fsnotify: take groups mark_lock before mark lock"
>       Revert "fsnotify: use reference counting for groups"
>       Revert "fsnotify: introduce fsnotify_get_group()"
> 
>  fs/notify/dnotify/dnotify.c          |  4 +-
>  fs/notify/fanotify/fanotify_user.c   | 19 ++------
>  fs/notify/group.c                    | 38 +++++++--------
>  fs/notify/inode_mark.c               | 14 ++----
>  fs/notify/inotify/inotify_fsnotify.c |  4 +-
>  fs/notify/inotify/inotify_user.c     |  3 +-
>  fs/notify/mark.c                     | 91 ++++++++++++++++--------------------
>  fs/notify/vfsmount_mark.c            | 14 ++----
>  include/linux/fsnotify_backend.h     | 23 ++++-----
>  kernel/audit_tree.c                  | 14 +++---
>  kernel/audit_watch.c                 |  4 +-
>  11 files changed, 92 insertions(+), 136 deletions(-)
>
Luis Henriques - Jan. 24, 2013, 10:27 a.m.
Applied to Precise master-next

On Wed, Jan 23, 2013 at 09:32:58PM +0000, Luis Henriques wrote:
> == Precise SRU Justification ==
> 
> BugLink: http://bugs.launchpad.net/bugs/1101666
> 
> This pull request reverts all the fsnotify patches that have been added
> into the kernel in the last release due to a regression.  A fix has
> already been identified and is currently being tested, but it's not yet
> ready for release.
> 
> == Fix ==
> 
> The following changes since commit 4d47c361f449b82c2d7760949f076c778ee70fbe:
> 
>   UBUNTU: Ubuntu-3.2.0-36.57 (2013-01-08 18:48:42 +0000)
> 
> are available in the git repository at:
> 
>   git://kernel.ubuntu.com/henrix/ubuntu-precise fsnotify
> 
> for you to fetch changes up to 3e909ea1d927c0950035f333c7070a1495ac3b2e:
> 
>   Revert "fsnotify: introduce fsnotify_get_group()" (2013-01-23 21:07:10 +0000)
> 
> ----------------------------------------------------------------
> Luis Henriques (9):
>       Revert "fsnotify: change locking order"
>       Revert "fsnotify: dont put marks on temporary list when clearing marks by group"
>       Revert "fsnotify: introduce locked versions of fsnotify_add_mark() and fsnotify_remove_mark()"
>       Revert "fsnotify: pass group to fsnotify_destroy_mark()"
>       Revert "fsnotify: use a mutex instead of a spinlock to protect a groups mark list"
>       Revert "fanotify: add an extra flag to mark_remove_from_mask that indicates wheather a mark should be destroyed"
>       Revert "fsnotify: take groups mark_lock before mark lock"
>       Revert "fsnotify: use reference counting for groups"
>       Revert "fsnotify: introduce fsnotify_get_group()"
> 
>  fs/notify/dnotify/dnotify.c          |  4 +-
>  fs/notify/fanotify/fanotify_user.c   | 19 ++------
>  fs/notify/group.c                    | 38 +++++++--------
>  fs/notify/inode_mark.c               | 14 ++----
>  fs/notify/inotify/inotify_fsnotify.c |  4 +-
>  fs/notify/inotify/inotify_user.c     |  3 +-
>  fs/notify/mark.c                     | 91 ++++++++++++++++--------------------
>  fs/notify/vfsmount_mark.c            | 14 ++----
>  include/linux/fsnotify_backend.h     | 23 ++++-----
>  kernel/audit_tree.c                  | 14 +++---
>  kernel/audit_watch.c                 |  4 +-
>  11 files changed, 92 insertions(+), 136 deletions(-)
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Cheers,
--
Luis
Chris J Arges - Jan. 31, 2013, 5:20 p.m.
On 01/24/2013 04:27 AM, Luis Henriques wrote:
> Applied to Precise master-next
> 
> On Wed, Jan 23, 2013 at 09:32:58PM +0000, Luis Henriques wrote:
>> == Precise SRU Justification ==
>>
>> BugLink: http://bugs.launchpad.net/bugs/1101666
<snip>

Call for testing!

Ok, I've formatted a new set of patches that address the regressions in
1101666, while maintaining the fixes for 922906/1096137.
This is being tracked in bug 1110605 now.

The new build is here :
http://people.canonical.com/~arges/lp1101666.1/

The test cases are in 110605, I've tested on both P/Q with both tests
separately and both tests together. I'm also running this on my P
desktop to eek out any other issues.

Thanks,
--chris j arges