Patchwork [2/2] fw_cfg: Drop a few superfluous initializers

login
register
mail settings
Submitter Markus Armbruster
Date Jan. 23, 2013, 5:25 p.m.
Message ID <1358961909-17519-3-git-send-email-armbru@redhat.com>
Download mbox | patch
Permalink /patch/215009/
State New
Headers show

Comments

Markus Armbruster - Jan. 23, 2013, 5:25 p.m.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 hw/fw_cfg.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Laszlo Ersek - Jan. 24, 2013, 11:01 a.m.
On 01/23/13 18:25, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  hw/fw_cfg.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/hw/fw_cfg.c b/hw/fw_cfg.c
> index b7da5c7..bdcd836 100644
> --- a/hw/fw_cfg.c
> +++ b/hw/fw_cfg.c
> @@ -60,8 +60,8 @@ static char *read_splashfile(char *filename, size_t *file_sizep,
>      GError *err = NULL;
>      gboolean res;
>      gchar *content;
> -    int file_type = -1;
> -    unsigned int filehead = 0;
> +    int file_type;
> +    unsigned int filehead;
>      int bmp_bpp;
>  
>      res = g_file_get_contents(filename, &content, file_sizep, &err);
> @@ -113,7 +113,7 @@ static void fw_cfg_bootsplash(FWCfgState *s)
>      char *p;
>      char *filename, *file_data;
>      size_t file_size;
> -    int file_type = -1;
> +    int file_type;
>      const char *temp;
>  
>      /* get user configuration */

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Patch

diff --git a/hw/fw_cfg.c b/hw/fw_cfg.c
index b7da5c7..bdcd836 100644
--- a/hw/fw_cfg.c
+++ b/hw/fw_cfg.c
@@ -60,8 +60,8 @@  static char *read_splashfile(char *filename, size_t *file_sizep,
     GError *err = NULL;
     gboolean res;
     gchar *content;
-    int file_type = -1;
-    unsigned int filehead = 0;
+    int file_type;
+    unsigned int filehead;
     int bmp_bpp;
 
     res = g_file_get_contents(filename, &content, file_sizep, &err);
@@ -113,7 +113,7 @@  static void fw_cfg_bootsplash(FWCfgState *s)
     char *p;
     char *filename, *file_data;
     size_t file_size;
-    int file_type = -1;
+    int file_type;
     const char *temp;
 
     /* get user configuration */