Patchwork [U-Boot] sf: spansion: Correct the first byte of idcode1 for S25FL256S part

login
register
mail settings
Submitter Michal Simek
Date Jan. 23, 2013, 12:24 p.m.
Message ID <1358943863-8893-1-git-send-email-michal.simek@xilinx.com>
Download mbox | patch
Permalink /patch/214918/
State Accepted
Delegated to: Tom Rini
Headers show

Comments

Michal Simek - Jan. 23, 2013, 12:24 p.m.
From: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>

This patch corrected the first byte of idcode1 for S25FL256S SPI flash.

Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
 drivers/mtd/spi/spansion.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Marek Vasut - Feb. 4, 2013, 5:59 p.m.
Dear Michal Simek,

was this ever applied?

> From: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
> 
> This patch corrected the first byte of idcode1 for S25FL256S SPI flash.
> 
> Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>  drivers/mtd/spi/spansion.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mtd/spi/spansion.c b/drivers/mtd/spi/spansion.c
> index 32b76e0..9288672 100644
> --- a/drivers/mtd/spi/spansion.c
> +++ b/drivers/mtd/spi/spansion.c
> @@ -97,7 +97,7 @@ static const struct spansion_spi_flash_params
> spansion_spi_flash_table[] = { .name = "S25FL129P_64K",
>  	},
>  	{
> -		.idcode1 = 0x2019,
> +		.idcode1 = 0x0219,
>  		.idcode2 = 0x4d01,
>  		.pages_per_sector = 256,
>  		.nr_sectors = 512,

Best regards,
Marek Vasut
Michal Simek - Feb. 4, 2013, 6:11 p.m.
Hi,

2013/2/4 Marek Vasut <marex@denx.de>:
> Dear Michal Simek,
>
> was this ever applied?

I have sent pull request to Tom and Mike. All patches around cf are here.

http://git.denx.de/?p=u-boot/u-boot-microblaze.git;a=shortlog;h=refs/heads/mainline/sf

Interesting that Tom applied this patch and don't the rest
"sf: stmicro: add support for N25Q064"

Thanks,
Michal
Tom Rini - Feb. 4, 2013, 8:52 p.m.
On Mon, Feb 04, 2013 at 07:11:38PM +0100, Michal Simek wrote:
> Hi,
> 
> 2013/2/4 Marek Vasut <marex@denx.de>:
> > Dear Michal Simek,
> >
> > was this ever applied?
> 
> I have sent pull request to Tom and Mike. All patches around cf are here.
> 
> http://git.denx.de/?p=u-boot/u-boot-microblaze.git;a=shortlog;h=refs/heads/mainline/sf
> 
> Interesting that Tom applied this patch and don't the rest
> "sf: stmicro: add support for N25Q064"

I had grabbed a few things that stood out to me Friday and started a
build.  Took a bit to sort out things and in the interim you made your
pull request.

Patch

diff --git a/drivers/mtd/spi/spansion.c b/drivers/mtd/spi/spansion.c
index 32b76e0..9288672 100644
--- a/drivers/mtd/spi/spansion.c
+++ b/drivers/mtd/spi/spansion.c
@@ -97,7 +97,7 @@  static const struct spansion_spi_flash_params spansion_spi_flash_table[] = {
 		.name = "S25FL129P_64K",
 	},
 	{
-		.idcode1 = 0x2019,
+		.idcode1 = 0x0219,
 		.idcode2 = 0x4d01,
 		.pages_per_sector = 256,
 		.nr_sectors = 512,