Patchwork [v9,20/20] mdf: omap-usb-host: get rid of build warning

login
register
mail settings
Submitter Roger Quadros
Date Jan. 23, 2013, 10:38 a.m.
Message ID <1358937492-8129-21-git-send-email-rogerq@ti.com>
Download mbox | patch
Permalink /patch/214885/
State New
Headers show

Comments

Roger Quadros - Jan. 23, 2013, 10:38 a.m.
Fixes the below build warning when driver is built-in.

drivers/mfd/omap-usb-host.c:750:12: warning:
‘usbhs_omap_remove’ defined but not used [-Wunused-function]

Signed-off-by: Roger Quadros <rogerq@ti.com>
Reviewed-by: Felipe Balbi <balbi@ti.com>
---
 drivers/mfd/omap-usb-host.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Mike Turquette - Jan. 23, 2013, 11:36 p.m.
Quoting Roger Quadros (2013-01-23 02:38:12)
> Fixes the below build warning when driver is built-in.
> 
> drivers/mfd/omap-usb-host.c:750:12: warning:
> ‘usbhs_omap_remove’ defined but not used [-Wunused-function]
> 
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> Reviewed-by: Felipe Balbi <balbi@ti.com>

Hi Roger,

I just noticed that $SUBJECT says "mdf" instead of "mfd" ;)

Regards,
Mike

> ---
>  drivers/mfd/omap-usb-host.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
> index b21ca76..6b5edf6 100644
> --- a/drivers/mfd/omap-usb-host.c
> +++ b/drivers/mfd/omap-usb-host.c
> @@ -791,7 +791,7 @@ static struct platform_driver usbhs_omap_driver = {
>                 .owner          = THIS_MODULE,
>                 .pm             = &usbhsomap_dev_pm_ops,
>         },
> -       .remove         = __exit_p(usbhs_omap_remove),
> +       .remove         = usbhs_omap_remove,
>  };
>  
>  MODULE_AUTHOR("Keshava Munegowda <keshava_mgowda@ti.com>");
> -- 
> 1.7.4.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Roger Quadros - Jan. 24, 2013, 9 a.m.
On 01/24/2013 01:36 AM, Mike Turquette wrote:
> Quoting Roger Quadros (2013-01-23 02:38:12)
>> Fixes the below build warning when driver is built-in.
>>
>> drivers/mfd/omap-usb-host.c:750:12: warning:
>> ‘usbhs_omap_remove’ defined but not used [-Wunused-function]
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> Reviewed-by: Felipe Balbi <balbi@ti.com>
> 
> Hi Roger,
> 
> I just noticed that $SUBJECT says "mdf" instead of "mfd" ;)
> 

Thanks Mike. I've fixed it in the pull request and i'll mail a patch as well.

cheers,
-roger.

> 
>> ---
>>  drivers/mfd/omap-usb-host.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
>> index b21ca76..6b5edf6 100644
>> --- a/drivers/mfd/omap-usb-host.c
>> +++ b/drivers/mfd/omap-usb-host.c
>> @@ -791,7 +791,7 @@ static struct platform_driver usbhs_omap_driver = {
>>                 .owner          = THIS_MODULE,
>>                 .pm             = &usbhsomap_dev_pm_ops,
>>         },
>> -       .remove         = __exit_p(usbhs_omap_remove),
>> +       .remove         = usbhs_omap_remove,
>>  };
>>  
>>  MODULE_AUTHOR("Keshava Munegowda <keshava_mgowda@ti.com>");
>> -- 
>> 1.7.4.1
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Patch

diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
index b21ca76..6b5edf6 100644
--- a/drivers/mfd/omap-usb-host.c
+++ b/drivers/mfd/omap-usb-host.c
@@ -791,7 +791,7 @@  static struct platform_driver usbhs_omap_driver = {
 		.owner		= THIS_MODULE,
 		.pm		= &usbhsomap_dev_pm_ops,
 	},
-	.remove		= __exit_p(usbhs_omap_remove),
+	.remove		= usbhs_omap_remove,
 };
 
 MODULE_AUTHOR("Keshava Munegowda <keshava_mgowda@ti.com>");