Patchwork [v2,net-next,1/2] be2net: Modify GPL Marking in all source files.

login
register
mail settings
Submitter Sarveshwar Bandi
Date Jan. 23, 2013, 6:52 a.m.
Message ID <c09a42d1-150f-4d78-b2c4-2bedec3bd577@CMEXHTCAS2.ad.emulex.com>
Download mbox | patch
Permalink /patch/214813/
State Changes Requested
Delegated to: David Miller
Headers show

Comments

Sarveshwar Bandi - Jan. 23, 2013, 6:52 a.m.
From: Vasundhara Volam <vasundhara.volam@emulex.com>

The following modifications have been made to copyright:
- years of copyright extended to include 2013
- specify EMULEX and SLI as trademarks of Emulex corporation
- specify emulex website
- Added a more detailed disclaimer " ALL EXPRESS OR IMPLIED CONDITIONS,
REPRESENTATIONS AND WARRANTIES, INCLUDING ANY IMPLIED WARRANTY OF
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE, OR NON-INFRINGEMENT,
ARE DISCLAIMED, EXCEPT TO THE EXTENT THAT SUCH DISCLAIMERS ARE HELD TO
BE LEGALLY INVALID."

Signed-off-by: Vasundhara Volam <vasundhara.volam@emulex.com>
Signed-off-by: Sarveshwar Bandi <sarveshwar.bandi@emulex.com>
---
 drivers/net/ethernet/emulex/benet/be.h         |   25 ++++++++++++++----------
 drivers/net/ethernet/emulex/benet/be_cmds.c    |   25 ++++++++++++++----------
 drivers/net/ethernet/emulex/benet/be_cmds.h    |   25 ++++++++++++++----------
 drivers/net/ethernet/emulex/benet/be_ethtool.c |   25 ++++++++++++++----------
 drivers/net/ethernet/emulex/benet/be_hw.h      |   25 ++++++++++++++----------
 drivers/net/ethernet/emulex/benet/be_main.c    |   25 ++++++++++++++----------
 drivers/net/ethernet/emulex/benet/be_roce.c    |   25 ++++++++++++++----------
 drivers/net/ethernet/emulex/benet/be_roce.h    |   25 ++++++++++++++----------
 8 files changed, 120 insertions(+), 80 deletions(-)
David Miller - Jan. 23, 2013, 7:06 a.m.
From: <sarveshwar.bandi@emulex.com>
Date: Wed, 23 Jan 2013 12:22:03 +0530

> From: Vasundhara Volam <vasundhara.volam@emulex.com>
> 
> The following modifications have been made to copyright:
> - years of copyright extended to include 2013
> - specify EMULEX and SLI as trademarks of Emulex corporation
> - specify emulex website
> - Added a more detailed disclaimer " ALL EXPRESS OR IMPLIED CONDITIONS,
> REPRESENTATIONS AND WARRANTIES, INCLUDING ANY IMPLIED WARRANTY OF
> MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE, OR NON-INFRINGEMENT,
> ARE DISCLAIMED, EXCEPT TO THE EXTENT THAT SUCH DISCLAIMERS ARE HELD TO
> BE LEGALLY INVALID."
> 
> Signed-off-by: Vasundhara Volam <vasundhara.volam@emulex.com>
> Signed-off-by: Sarveshwar Bandi <sarveshwar.bandi@emulex.com>

You're just essentially reading the contents of the patch, that's
not satisfactory.

In particular, the problem is that you aren't explaining why you're
making all of these changes.

There needs to be justification for copyright changes like this,
you are not providing them.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sarveshwar Bandi - Jan. 23, 2013, 7:28 a.m.
Dave,
Can I assume that the first 3 points are acceptable (copyright being extended, adding EMULEX/SLI as trademarks, and adding website information)?

As for the last one about disclaimer, most driver had it all the time and benet did not. It  mentions section 15 "Disclaimer of Warranty" of gpl license explicitly 
(http://www.gnu.org/licenses/gpl.html). 

Is there an issue with this?

Thanks,
Sarvesh

-----Original Message-----
From: David Miller [mailto:davem@davemloft.net] 
Sent: Wednesday, January 23, 2013 12:36 PM
To: Bandi,Sarveshwar
Cc: netdev@vger.kernel.org; Vasundhara, Volam
Subject: Re: [PATCH v2 net-next 1/2] be2net: Modify GPL Marking in all source files.

From: <sarveshwar.bandi@emulex.com>
Date: Wed, 23 Jan 2013 12:22:03 +0530

> From: Vasundhara Volam <vasundhara.volam@emulex.com>
> 
> The following modifications have been made to copyright:
> - years of copyright extended to include 2013
> - specify EMULEX and SLI as trademarks of Emulex corporation
> - specify emulex website
> - Added a more detailed disclaimer " ALL EXPRESS OR IMPLIED 
> CONDITIONS, REPRESENTATIONS AND WARRANTIES, INCLUDING ANY IMPLIED 
> WARRANTY OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE, OR 
> NON-INFRINGEMENT, ARE DISCLAIMED, EXCEPT TO THE EXTENT THAT SUCH 
> DISCLAIMERS ARE HELD TO BE LEGALLY INVALID."
> 
> Signed-off-by: Vasundhara Volam <vasundhara.volam@emulex.com>
> Signed-off-by: Sarveshwar Bandi <sarveshwar.bandi@emulex.com>

You're just essentially reading the contents of the patch, that's not satisfactory.

In particular, the problem is that you aren't explaining why you're making all of these changes.

There needs to be justification for copyright changes like this, you are not providing them.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sarveshwar Bandi - Jan. 23, 2013, 7:37 p.m.
Dave,
   Does this explanation make sense?  Would you want me to resubmit the patches?

Thanks,
Sarvesh

-----Original Message-----
From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] On Behalf Of Bandi,Sarveshwar
Sent: Wednesday, January 23, 2013 12:58 PM
To: David Miller
Cc: netdev@vger.kernel.org; Vasundhara, Volam
Subject: RE: [PATCH v2 net-next 1/2] be2net: Modify GPL Marking in all source files.

Dave,
Can I assume that the first 3 points are acceptable (copyright being extended, adding EMULEX/SLI as trademarks, and adding website information)?

As for the last one about disclaimer, most driver had it all the time and benet did not. It  mentions section 15 "Disclaimer of Warranty" of gpl license explicitly (http://www.gnu.org/licenses/gpl.html). 

Is there an issue with this?

Thanks,
Sarvesh

-----Original Message-----
From: David Miller [mailto:davem@davemloft.net]
Sent: Wednesday, January 23, 2013 12:36 PM
To: Bandi,Sarveshwar
Cc: netdev@vger.kernel.org; Vasundhara, Volam
Subject: Re: [PATCH v2 net-next 1/2] be2net: Modify GPL Marking in all source files.

From: <sarveshwar.bandi@emulex.com>
Date: Wed, 23 Jan 2013 12:22:03 +0530

> From: Vasundhara Volam <vasundhara.volam@emulex.com>
> 
> The following modifications have been made to copyright:
> - years of copyright extended to include 2013
> - specify EMULEX and SLI as trademarks of Emulex corporation
> - specify emulex website
> - Added a more detailed disclaimer " ALL EXPRESS OR IMPLIED 
> CONDITIONS, REPRESENTATIONS AND WARRANTIES, INCLUDING ANY IMPLIED 
> WARRANTY OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE, OR 
> NON-INFRINGEMENT, ARE DISCLAIMED, EXCEPT TO THE EXTENT THAT SUCH 
> DISCLAIMERS ARE HELD TO BE LEGALLY INVALID."
> 
> Signed-off-by: Vasundhara Volam <vasundhara.volam@emulex.com>
> Signed-off-by: Sarveshwar Bandi <sarveshwar.bandi@emulex.com>

You're just essentially reading the contents of the patch, that's not satisfactory.

In particular, the problem is that you aren't explaining why you're making all of these changes.

There needs to be justification for copyright changes like this, you are not providing them.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/ethernet/emulex/benet/be.h b/drivers/net/ethernet/emulex/benet/be.h
index 4eba17b..f27fe8e 100644
--- a/drivers/net/ethernet/emulex/benet/be.h
+++ b/drivers/net/ethernet/emulex/benet/be.h
@@ -1,18 +1,23 @@ 
 /*
- * Copyright (C) 2005 - 2011 Emulex
- * All rights reserved.
+ * This file is part of the Linux NIC driver for Emulex OneConnect CNA.
  *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License version 2
- * as published by the Free Software Foundation.  The full GNU General
- * Public License is included in this distribution in the file called COPYING.
+ * Copyright (C) 2005-2013 Emulex. All rights reserved.
  *
- * Contact Information:
+ * EMULEX and SLI are trademarks of Emulex.
+ * www.emulex.com
  * linux-drivers@emulex.com
  *
- * Emulex
- * 3333 Susan Street
- * Costa Mesa, CA 92626
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of version 2 of the GNU General Public License as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful.
+ * ALL EXPRESS OR IMPLIED CONDITIONS, REPRESENTATIONS AND WARRANTIES,
+ * INCLUDING ANY IMPLIED WARRANTY OF MERCHANTABILITY, FITNESS FOR A
+ * PARTICULAR PURPOSE, OR NON-INFRINGEMENT, ARE DISCLAIMED, EXCEPT TO THE
+ * EXTENT THAT SUCH DISCLAIMERS ARE HELD TO BE LEGALLY INVALID.
+ * See the GNU General Public License for more details, a copy of which
+ * can be found in the file COPYING included with this package
  */
 
 #ifndef BE_H
diff --git a/drivers/net/ethernet/emulex/benet/be_cmds.c b/drivers/net/ethernet/emulex/benet/be_cmds.c
index 8a250c3..d1222a4 100644
--- a/drivers/net/ethernet/emulex/benet/be_cmds.c
+++ b/drivers/net/ethernet/emulex/benet/be_cmds.c
@@ -1,18 +1,23 @@ 
 /*
- * Copyright (C) 2005 - 2011 Emulex
- * All rights reserved.
+ * This file is part of the Linux NIC driver for Emulex OneConnect CNA.
  *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License version 2
- * as published by the Free Software Foundation.  The full GNU General
- * Public License is included in this distribution in the file called COPYING.
+ * Copyright (C) 2005-2013 Emulex. All rights reserved.
  *
- * Contact Information:
+ * EMULEX and SLI are trademarks of Emulex.
+ * www.emulex.com
  * linux-drivers@emulex.com
  *
- * Emulex
- * 3333 Susan Street
- * Costa Mesa, CA 92626
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of version 2 of the GNU General Public License as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful.
+ * ALL EXPRESS OR IMPLIED CONDITIONS, REPRESENTATIONS AND WARRANTIES,
+ * INCLUDING ANY IMPLIED WARRANTY OF MERCHANTABILITY, FITNESS FOR A
+ * PARTICULAR PURPOSE, OR NON-INFRINGEMENT, ARE DISCLAIMED, EXCEPT TO THE
+ * EXTENT THAT SUCH DISCLAIMERS ARE HELD TO BE LEGALLY INVALID.
+ * See the GNU General Public License for more details, a copy of which
+ * can be found in the file COPYING included with this package
  */
 
 #include <linux/module.h>
diff --git a/drivers/net/ethernet/emulex/benet/be_cmds.h b/drivers/net/ethernet/emulex/benet/be_cmds.h
index d6552e1..9bd9aa5 100644
--- a/drivers/net/ethernet/emulex/benet/be_cmds.h
+++ b/drivers/net/ethernet/emulex/benet/be_cmds.h
@@ -1,18 +1,23 @@ 
 /*
- * Copyright (C) 2005 - 2011 Emulex
- * All rights reserved.
+ * This file is part of the Linux NIC driver for Emulex OneConnect CNA.
  *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License version 2
- * as published by the Free Software Foundation.  The full GNU General
- * Public License is included in this distribution in the file called COPYING.
+ * Copyright (C) 2005-2013 Emulex. All rights reserved.
  *
- * Contact Information:
+ * EMULEX and SLI are trademarks of Emulex.
+ * www.emulex.com
  * linux-drivers@emulex.com
  *
- * Emulex
- * 3333 Susan Street
- * Costa Mesa, CA 92626
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of version 2 of the GNU General Public License as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful.
+ * ALL EXPRESS OR IMPLIED CONDITIONS, REPRESENTATIONS AND WARRANTIES,
+ * INCLUDING ANY IMPLIED WARRANTY OF MERCHANTABILITY, FITNESS FOR A
+ * PARTICULAR PURPOSE, OR NON-INFRINGEMENT, ARE DISCLAIMED, EXCEPT TO THE
+ * EXTENT THAT SUCH DISCLAIMERS ARE HELD TO BE LEGALLY INVALID.
+ * See the GNU General Public License for more details, a copy of which
+ * can be found in the file COPYING included with this package
  */
 
 /*
diff --git a/drivers/net/ethernet/emulex/benet/be_ethtool.c b/drivers/net/ethernet/emulex/benet/be_ethtool.c
index 76b302f..6ea33a0 100644
--- a/drivers/net/ethernet/emulex/benet/be_ethtool.c
+++ b/drivers/net/ethernet/emulex/benet/be_ethtool.c
@@ -1,18 +1,23 @@ 
 /*
- * Copyright (C) 2005 - 2011 Emulex
- * All rights reserved.
+ * This file is part of the Linux NIC driver for Emulex OneConnect CNA.
  *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License version 2
- * as published by the Free Software Foundation.  The full GNU General
- * Public License is included in this distribution in the file called COPYING.
+ * Copyright (C) 2005-2013 Emulex. All rights reserved.
  *
- * Contact Information:
+ * EMULEX and SLI are trademarks of Emulex.
+ * www.emulex.com
  * linux-drivers@emulex.com
  *
- * Emulex
- * 3333 Susan Street
- * Costa Mesa, CA 92626
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of version 2 of the GNU General Public License as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful.
+ * ALL EXPRESS OR IMPLIED CONDITIONS, REPRESENTATIONS AND WARRANTIES,
+ * INCLUDING ANY IMPLIED WARRANTY OF MERCHANTABILITY, FITNESS FOR A
+ * PARTICULAR PURPOSE, OR NON-INFRINGEMENT, ARE DISCLAIMED, EXCEPT TO THE
+ * EXTENT THAT SUCH DISCLAIMERS ARE HELD TO BE LEGALLY INVALID.
+ * See the GNU General Public License for more details, a copy of which
+ * can be found in the file COPYING included with this package
  */
 
 #include "be.h"
diff --git a/drivers/net/ethernet/emulex/benet/be_hw.h b/drivers/net/ethernet/emulex/benet/be_hw.h
index 541d453..e490f73 100644
--- a/drivers/net/ethernet/emulex/benet/be_hw.h
+++ b/drivers/net/ethernet/emulex/benet/be_hw.h
@@ -1,18 +1,23 @@ 
 /*
- * Copyright (C) 2005 - 2011 Emulex
- * All rights reserved.
+ * This file is part of the Linux NIC driver for Emulex OneConnect CNA.
  *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License version 2
- * as published by the Free Software Foundation.  The full GNU General
- * Public License is included in this distribution in the file called COPYING.
+ * Copyright (C) 2005-2013 Emulex. All rights reserved.
  *
- * Contact Information:
+ * EMULEX and SLI are trademarks of Emulex.
+ * www.emulex.com
  * linux-drivers@emulex.com
  *
- * Emulex
- * 3333 Susan Street
- * Costa Mesa, CA 92626
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of version 2 of the GNU General Public License as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful.
+ * ALL EXPRESS OR IMPLIED CONDITIONS, REPRESENTATIONS AND WARRANTIES,
+ * INCLUDING ANY IMPLIED WARRANTY OF MERCHANTABILITY, FITNESS FOR A
+ * PARTICULAR PURPOSE, OR NON-INFRINGEMENT, ARE DISCLAIMED, EXCEPT TO THE
+ * EXTENT THAT SUCH DISCLAIMERS ARE HELD TO BE LEGALLY INVALID.
+ * See the GNU General Public License for more details, a copy of which
+ * can be found in the file COPYING included with this package
  */
 
 /********* Mailbox door bell *************/
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index 5c99570..b1cc3f2 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -1,18 +1,23 @@ 
 /*
- * Copyright (C) 2005 - 2011 Emulex
- * All rights reserved.
+ * This file is part of the Linux NIC driver for Emulex OneConnect CNA.
  *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License version 2
- * as published by the Free Software Foundation.  The full GNU General
- * Public License is included in this distribution in the file called COPYING.
+ * Copyright (C) 2005-2013 Emulex. All rights reserved.
  *
- * Contact Information:
+ * EMULEX and SLI are trademarks of Emulex.
+ * www.emulex.com
  * linux-drivers@emulex.com
  *
- * Emulex
- * 3333 Susan Street
- * Costa Mesa, CA 92626
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of version 2 of the GNU General Public License as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful.
+ * ALL EXPRESS OR IMPLIED CONDITIONS, REPRESENTATIONS AND WARRANTIES,
+ * INCLUDING ANY IMPLIED WARRANTY OF MERCHANTABILITY, FITNESS FOR A
+ * PARTICULAR PURPOSE, OR NON-INFRINGEMENT, ARE DISCLAIMED, EXCEPT TO THE
+ * EXTENT THAT SUCH DISCLAIMERS ARE HELD TO BE LEGALLY INVALID.
+ * See the GNU General Public License for more details, a copy of which
+ * can be found in the file COPYING included with this package
  */
 
 #include <linux/prefetch.h>
diff --git a/drivers/net/ethernet/emulex/benet/be_roce.c b/drivers/net/ethernet/emulex/benet/be_roce.c
index 55d32aa..ebc39a9 100644
--- a/drivers/net/ethernet/emulex/benet/be_roce.c
+++ b/drivers/net/ethernet/emulex/benet/be_roce.c
@@ -1,18 +1,23 @@ 
 /*
- * Copyright (C) 2005 - 2011 Emulex
- * All rights reserved.
+ * This file is part of the Linux NIC driver for Emulex OneConnect CNA.
  *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License version 2
- * as published by the Free Software Foundation. The full GNU General
- * Public License is included in this distribution in the file called COPYING.
+ * Copyright (C) 2005-2013 Emulex. All rights reserved.
  *
- * Contact Information:
+ * EMULEX and SLI are trademarks of Emulex.
+ * www.emulex.com
  * linux-drivers@emulex.com
  *
- * Emulex
- * 3333 Susan Street
- * Costa Mesa, CA 92626
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of version 2 of the GNU General Public License as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful.
+ * ALL EXPRESS OR IMPLIED CONDITIONS, REPRESENTATIONS AND WARRANTIES,
+ * INCLUDING ANY IMPLIED WARRANTY OF MERCHANTABILITY, FITNESS FOR A
+ * PARTICULAR PURPOSE, OR NON-INFRINGEMENT, ARE DISCLAIMED, EXCEPT TO THE
+ * EXTENT THAT SUCH DISCLAIMERS ARE HELD TO BE LEGALLY INVALID.
+ * See the GNU General Public License for more details, a copy of which
+ * can be found in the file COPYING included with this package
  */
 
 #include <linux/mutex.h>
diff --git a/drivers/net/ethernet/emulex/benet/be_roce.h b/drivers/net/ethernet/emulex/benet/be_roce.h
index db4ea80..3b57976 100644
--- a/drivers/net/ethernet/emulex/benet/be_roce.h
+++ b/drivers/net/ethernet/emulex/benet/be_roce.h
@@ -1,18 +1,23 @@ 
 /*
- * Copyright (C) 2005 - 2011 Emulex
- * All rights reserved.
+ * This file is part of the Linux NIC driver for Emulex OneConnect CNA.
  *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License version 2
- * as published by the Free Software Foundation. The full GNU General
- * Public License is included in this distribution in the file called COPYING.
+ * Copyright (C) 2005-2013 Emulex. All rights reserved.
  *
- * Contact Information:
+ * EMULEX and SLI are trademarks of Emulex.
+ * www.emulex.com
  * linux-drivers@emulex.com
  *
- * Emulex
- * 3333 Susan Street
- * Costa Mesa, CA 92626
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of version 2 of the GNU General Public License as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful.
+ * ALL EXPRESS OR IMPLIED CONDITIONS, REPRESENTATIONS AND WARRANTIES,
+ * INCLUDING ANY IMPLIED WARRANTY OF MERCHANTABILITY, FITNESS FOR A
+ * PARTICULAR PURPOSE, OR NON-INFRINGEMENT, ARE DISCLAIMED, EXCEPT TO THE
+ * EXTENT THAT SUCH DISCLAIMERS ARE HELD TO BE LEGALLY INVALID.
+ * See the GNU General Public License for more details, a copy of which
+ * can be found in the file COPYING included with this package
  */
 
 #ifndef BE_ROCE_H