From patchwork Tue Jan 22 13:56:06 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Dumazet X-Patchwork-Id: 214551 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 484B22C0080 for ; Wed, 23 Jan 2013 00:56:15 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752728Ab3AVN4M (ORCPT ); Tue, 22 Jan 2013 08:56:12 -0500 Received: from mail-pa0-f53.google.com ([209.85.220.53]:36408 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751737Ab3AVN4J (ORCPT ); Tue, 22 Jan 2013 08:56:09 -0500 Received: by mail-pa0-f53.google.com with SMTP id hz1so4067463pad.40 for ; Tue, 22 Jan 2013 05:56:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:subject:from:to:cc:in-reply-to:references:content-type :date:message-id:mime-version:x-mailer:content-transfer-encoding; bh=cRlEeNDl6xckhSQ0TaN3Cd6P6FeIzDM0/evlV2+Sr+8=; b=Ag5gngqqW/MHR+o1lajGOEBVcvVUtRDDlxZNwDrEQrPDiXaJKmqfM3P0w0rfIV5Iur eDqI5u5O4ttNhJncgIj6PcjytEklHSPVGyvK/mgdTzRfTDuFlIqwDlxeKXkp3VlK7VSk GFQ5gH+GAEcgHbP2FYy5mXTcT024wqw+aip3DV4ksOKPq0mXDMJAbNHzcQ3vnKW0A7v8 4QUavqczqNK9E7X7bPFf57y513UQ/g0o0DkUlMgrkf2J2b8m0kHbYTlhKUAo81VGoY33 DCS6V5M2ps8ppLXkfKEftocOaKY/XwdPIKtnHaugPxY9RfYrpbyEPCKMvgvJsrzFC4aQ 49Dw== X-Received: by 10.66.78.1 with SMTP id x1mr56605566paw.2.1358862969069; Tue, 22 Jan 2013 05:56:09 -0800 (PST) Received: from [172.19.241.243] ([172.19.241.243]) by mx.google.com with ESMTPS id o5sm11457079paz.32.2013.01.22.05.56.07 (version=SSLv3 cipher=RC4-SHA bits=128/128); Tue, 22 Jan 2013 05:56:08 -0800 (PST) Subject: Re: BUG in netxen_release_tx_buffers when TSO enabled on kernels >= 3.3 and <= 3.6 From: Eric Dumazet To: christoph.paasch@uclouvain.be Cc: Ian Campbell , Sony Chacko , Rajesh Borundia , David Miller , netdev@vger.kernel.org In-Reply-To: <1358861524.3464.3768.camel@edumazet-glaptop> References: <1659861.dHpGAGoXHj@cpaasch-mac> <1358861524.3464.3768.camel@edumazet-glaptop> Date: Tue, 22 Jan 2013 05:56:06 -0800 Message-ID: <1358862966.3464.3797.camel@edumazet-glaptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 2013-01-22 at 05:32 -0800, Eric Dumazet wrote: > > Something doesn't properly test MAX_SKB_FRAGS, we should track it and > fix. I guess netxen driver has a bug. Please try the following patch : Tested-by: Christoph Paasch --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c index bc165f4..695667d 100644 --- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c +++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c @@ -144,7 +144,7 @@ void netxen_release_tx_buffers(struct netxen_adapter *adapter) buffrag->length, PCI_DMA_TODEVICE); buffrag->dma = 0ULL; } - for (j = 0; j < cmd_buf->frag_count; j++) { + for (j = 1; j < cmd_buf->frag_count; j++) { buffrag++; if (buffrag->dma) { pci_unmap_page(adapter->pdev, buffrag->dma,