Patchwork data: klog.json: Handle SystemIO conflict messages

login
register
mail settings
Submitter Colin King
Date Jan. 22, 2013, 12:41 p.m.
Message ID <1358858516-24950-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/214538/
State Accepted
Headers show

Comments

Colin King - Jan. 22, 2013, 12:41 p.m.
From: Colin Ian King <colin.king@canonical.com>

Add in some helpful advice for SystemIO conflict messages.
This ACPI message was first seen in bug report LP:#1102370, so it
seems sensible to make fwts diagnose the problem rather than giving
some less than helpful error report.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 data/klog.json | 8 ++++++++
 1 file changed, 8 insertions(+)
Keng-Yu Lin - Jan. 29, 2013, 6:36 a.m.
On Tue, Jan 22, 2013 at 8:41 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add in some helpful advice for SystemIO conflict messages.
> This ACPI message was first seen in bug report LP:#1102370, so it
> seems sensible to make fwts diagnose the problem rather than giving
> some less than helpful error report.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  data/klog.json | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index d526979..1fc48be 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -75,6 +75,14 @@
>    },
>    {
>     "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_LOW",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "0x.*-0x.* SystemIO conflicts with",
> +   "advice": "A resource conflict between an ACPI OperationRegion and a native driver has been detected. By default the kernel will use a strict policy and will not allow this region to conflict and -EBUSY will be returned to the caller that was trying to allocate the already claimed region.  If an ACPI driver is available for this device then this should be used instead of a native driver, so disabling the native driver may help. One can specify kernel boot paramater acpi_enforce_resources=lax to disable these checks but it may lead to random problems and system instability.  Alternatively, one can specify acpi_enforce_resources=no and ACPI Operation Region resources will not be registered.",
> +   "label": "KlogAcpiSystemIOConflict",
> +  },
> +  {
> +   "compare_mode": "regex",
>     "log_level": "LOG_LEVEL_MEDIUM",
>     "tag": "FWTS_TAG_BIOS",
>     "pattern": "device .* has invalid IRQ.*check vendor BIOS",
> --
> 1.8.0
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Alex Hung - Jan. 31, 2013, 6:23 a.m.
On 01/22/2013 08:41 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add in some helpful advice for SystemIO conflict messages.
> This ACPI message was first seen in bug report LP:#1102370, so it
> seems sensible to make fwts diagnose the problem rather than giving
> some less than helpful error report.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index d526979..1fc48be 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -75,6 +75,14 @@
>     },
>     {
>      "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_LOW",
> +   "tag": "FWTS_TAG_ACPI",
> +   "pattern": "0x.*-0x.* SystemIO conflicts with",
> +   "advice": "A resource conflict between an ACPI OperationRegion and a native driver has been detected. By default the kernel will use a strict policy and will not allow this region to conflict and -EBUSY will be returned to the caller that was trying to allocate the already claimed region.  If an ACPI driver is available for this device then this should be used instead of a native driver, so disabling the native driver may help. One can specify kernel boot paramater acpi_enforce_resources=lax to disable these checks but it may lead to random problems and system instability.  Alternatively, one can specify acpi_enforce_resources=no and ACPI Operation Region resources will not be registered.",
> +   "label": "KlogAcpiSystemIOConflict",
> +  },
> +  {
> +   "compare_mode": "regex",
>      "log_level": "LOG_LEVEL_MEDIUM",
>      "tag": "FWTS_TAG_BIOS",
>      "pattern": "device .* has invalid IRQ.*check vendor BIOS",
>

Acked-by: Alex Hung <alex.hung@canonical.com>

Patch

diff --git a/data/klog.json b/data/klog.json
index d526979..1fc48be 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -75,6 +75,14 @@ 
   },
   {
    "compare_mode": "regex",
+   "log_level": "LOG_LEVEL_LOW",
+   "tag": "FWTS_TAG_ACPI",
+   "pattern": "0x.*-0x.* SystemIO conflicts with",
+   "advice": "A resource conflict between an ACPI OperationRegion and a native driver has been detected. By default the kernel will use a strict policy and will not allow this region to conflict and -EBUSY will be returned to the caller that was trying to allocate the already claimed region.  If an ACPI driver is available for this device then this should be used instead of a native driver, so disabling the native driver may help. One can specify kernel boot paramater acpi_enforce_resources=lax to disable these checks but it may lead to random problems and system instability.  Alternatively, one can specify acpi_enforce_resources=no and ACPI Operation Region resources will not be registered.",
+   "label": "KlogAcpiSystemIOConflict",
+  },
+  {
+   "compare_mode": "regex",
    "log_level": "LOG_LEVEL_MEDIUM",
    "tag": "FWTS_TAG_BIOS",
    "pattern": "device .* has invalid IRQ.*check vendor BIOS",